diff options
author | Pascal Rapicault | 2010-03-02 22:22:29 +0000 |
---|---|---|
committer | Pascal Rapicault | 2010-03-02 22:22:29 +0000 |
commit | b2801fcc3af758b461115d109f64b72ee72ca8b3 (patch) | |
tree | 5d341811591d024bee62b3a5340ae38b1ac215b1 /bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2 | |
parent | 23cf3181efff253b5cf57dbb3f6def4f73f3ac36 (diff) | |
download | rt.equinox.p2-b2801fcc3af758b461115d109f64b72ee72ca8b3.tar.gz rt.equinox.p2-b2801fcc3af758b461115d109f64b72ee72ca8b3.tar.xz rt.equinox.p2-b2801fcc3af758b461115d109f64b72ee72ca8b3.zip |
Move PlannerHelper to API and renaming it
Diffstat (limited to 'bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2')
33 files changed, 168 insertions, 125 deletions
diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/AbstractProvisioningTest.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/AbstractProvisioningTest.java index ca9d9e733..800390c40 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/AbstractProvisioningTest.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/AbstractProvisioningTest.java @@ -8,6 +8,9 @@ ******************************************************************************/ package org.eclipse.equinox.p2.tests; + +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import java.io.*; import java.lang.reflect.Field; import java.net.URI; @@ -969,7 +972,7 @@ public abstract class AbstractProvisioningTest extends TestCase { ProfileChangeRequest req = new ProfileChangeRequest(profile); for (int i = 0; i < ius.length; i++) { req.add(ius[i]); - req.setInstallableUnitInclusionRules(ius[i], strict ? PlannerHelper.createStrictInclusionRule(ius[i]) : PlannerHelper.createOptionalInclusionRule(ius[i])); + req.setInstallableUnitInclusionRules(ius[i], strict ? ProfileInclusionRules.createStrictInclusionRule(ius[i]) : ProfileInclusionRules.createOptionalInclusionRule(ius[i])); } IProvisioningPlan plan = planner.getProvisioningPlan(req, null, null); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/artifact/repository/ArtifactRepositoryMissingSizeData.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/artifact/repository/ArtifactRepositoryMissingSizeData.java index 082bf17e7..7fda5701d 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/artifact/repository/ArtifactRepositoryMissingSizeData.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/artifact/repository/ArtifactRepositoryMissingSizeData.java @@ -10,12 +10,13 @@ *******************************************************************************/ package org.eclipse.equinox.p2.tests.artifact.repository; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.equinox.internal.p2.engine.Phase; import org.eclipse.equinox.internal.p2.engine.PhaseSet; import org.eclipse.equinox.internal.p2.engine.phases.Sizing; -import org.eclipse.equinox.internal.provisional.p2.director.PlannerHelper; import org.eclipse.equinox.internal.provisional.p2.director.ProfileChangeRequest; import org.eclipse.equinox.p2.core.ProvisionException; import org.eclipse.equinox.p2.engine.*; @@ -53,7 +54,7 @@ public class ArtifactRepositoryMissingSizeData extends AbstractProvisioningTest IProfile profile1 = createProfile("TestProfile." + getName()); ProfileChangeRequest req = new ProfileChangeRequest(profile1); req.add(missingArtifactIU); - req.setInstallableUnitInclusionRules(missingArtifactIU, PlannerHelper.createStrictInclusionRule(missingArtifactIU)); + req.setInstallableUnitInclusionRules(missingArtifactIU, ProfileInclusionRules.createStrictInclusionRule(missingArtifactIU)); IProvisioningPlan plan = createPlanner().getProvisioningPlan(req, null, null); assertEquals(IStatus.OK, plan.getStatus().getSeverity()); @@ -71,7 +72,7 @@ public class ArtifactRepositoryMissingSizeData extends AbstractProvisioningTest IProfile profile1 = createProfile("TestProfile." + getName()); ProfileChangeRequest req = new ProfileChangeRequest(profile1); req.add(missingSizeIU); - req.setInstallableUnitInclusionRules(missingSizeIU, PlannerHelper.createStrictInclusionRule(missingSizeIU)); + req.setInstallableUnitInclusionRules(missingSizeIU, ProfileInclusionRules.createStrictInclusionRule(missingSizeIU)); IProvisioningPlan plan = createPlanner().getProvisioningPlan(req, null, null); assertEquals(IStatus.OK, plan.getStatus().getSeverity()); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/AbstractPlannerTest.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/AbstractPlannerTest.java index bf90740ff..2100fb6f5 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/AbstractPlannerTest.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/AbstractPlannerTest.java @@ -10,12 +10,13 @@ *******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import java.io.File; import java.lang.reflect.Field; import java.util.Collection; import java.util.Iterator; import org.eclipse.equinox.internal.p2.engine.*; -import org.eclipse.equinox.internal.provisional.p2.director.PlannerHelper; import org.eclipse.equinox.internal.provisional.p2.director.ProfileChangeRequest; import org.eclipse.equinox.p2.engine.*; import org.eclipse.equinox.p2.metadata.IInstallableUnit; @@ -90,7 +91,7 @@ public abstract class AbstractPlannerTest extends AbstractProvisioningTest { for (Iterator iter = optionalAdds.iterator(); iter.hasNext();) { IInstallableUnit iu = (IInstallableUnit) iter.next(); result.add(iu); - result.setInstallableUnitInclusionRules(iu, PlannerHelper.createOptionalInclusionRule(iu)); + result.setInstallableUnitInclusionRules(iu, ProfileInclusionRules.createOptionalInclusionRule(iu)); result.setInstallableUnitProfileProperty(iu, "org.eclipse.equinox.p2.type.lock", "1"); result.setInstallableUnitProfileProperty(iu, "org.eclipse.equinox.p2.reconciler.dropins", "true"); } @@ -101,7 +102,7 @@ public abstract class AbstractPlannerTest extends AbstractProvisioningTest { for (Iterator iter = strictAdds.iterator(); iter.hasNext();) { IInstallableUnit iu = (IInstallableUnit) iter.next(); result.add(iu); - result.setInstallableUnitInclusionRules(iu, PlannerHelper.createStrictInclusionRule(iu)); + result.setInstallableUnitInclusionRules(iu, ProfileInclusionRules.createStrictInclusionRule(iu)); } } diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/ActualChangeRequestTest.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/ActualChangeRequestTest.java index de2fb647c..9e62cbecc 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/ActualChangeRequestTest.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/ActualChangeRequestTest.java @@ -10,6 +10,8 @@ *******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import org.eclipse.equinox.p2.metadata.MetadataFactory; import java.util.Map; @@ -47,7 +49,7 @@ public class ActualChangeRequestTest extends AbstractProvisioningTest { profile1 = createProfile("TestProfile." + getName()); ProfileChangeRequest req = new ProfileChangeRequest(profile1); req.addInstallableUnits(new IInstallableUnit[] {b}); - req.setInstallableUnitInclusionRules(b, PlannerHelper.createStrictInclusionRule(b)); + req.setInstallableUnitInclusionRules(b, ProfileInclusionRules.createStrictInclusionRule(b)); req.setInstallableUnitProfileProperty(b, "foo", "bar"); IProvisioningPlan plan = planner.getProvisioningPlan(req, null, null); assertEquals(IStatus.OK, ((PlannerStatus) plan.getStatus()).getRequestChanges().get(b).getSeverity()); @@ -59,7 +61,7 @@ public class ActualChangeRequestTest extends AbstractProvisioningTest { //Install A ProfileChangeRequest req2 = new ProfileChangeRequest(profile1); req2.addInstallableUnits(new IInstallableUnit[] {a}); - req2.setInstallableUnitInclusionRules(a, PlannerHelper.createStrictInclusionRule(a)); + req2.setInstallableUnitInclusionRules(a, ProfileInclusionRules.createStrictInclusionRule(a)); req2.setInstallableUnitProfileProperty(a, "foo", "bar"); IProvisioningPlan plan2 = planner.getProvisioningPlan(req2, null, null); assertEquals(IStatus.OK, plan2.getStatus().getSeverity()); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/ActualChangeRequestTest2.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/ActualChangeRequestTest2.java index 0d4d74fb5..6729e3249 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/ActualChangeRequestTest2.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/ActualChangeRequestTest2.java @@ -10,6 +10,9 @@ *******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; + +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import org.eclipse.equinox.p2.metadata.MetadataFactory; import java.util.Map; @@ -49,9 +52,9 @@ public class ActualChangeRequestTest2 extends AbstractProvisioningTest { profile1 = createProfile("TestProfile." + getName()); ProfileChangeRequest req = new ProfileChangeRequest(profile1); req.addInstallableUnits(new IInstallableUnit[] {b}); - req.setInstallableUnitInclusionRules(b, PlannerHelper.createStrictInclusionRule(b)); + req.setInstallableUnitInclusionRules(b, ProfileInclusionRules.createStrictInclusionRule(b)); req.addInstallableUnits(new IInstallableUnit[] {a}); - req.setInstallableUnitInclusionRules(a, PlannerHelper.createOptionalInclusionRule(a)); + req.setInstallableUnitInclusionRules(a, ProfileInclusionRules.createOptionalInclusionRule(a)); IProvisioningPlan plan = planner.getProvisioningPlan(req, null, null); assertEquals(IStatus.OK, ((PlannerStatus) plan.getStatus()).getRequestChanges().get(b).getSeverity()); @@ -63,7 +66,7 @@ public class ActualChangeRequestTest2 extends AbstractProvisioningTest { //Install B2 ProfileChangeRequest req2 = new ProfileChangeRequest(profile1); req2.addInstallableUnits(new IInstallableUnit[] {b2}); - req2.setInstallableUnitInclusionRules(b2, PlannerHelper.createStrictInclusionRule(b2)); + req2.setInstallableUnitInclusionRules(b2, ProfileInclusionRules.createStrictInclusionRule(b2)); req2.removeInstallableUnits(new IInstallableUnit[] {b}); IProvisioningPlan plan2 = planner.getProvisioningPlan(req2, null, null); assertEquals(IStatus.OK, plan2.getStatus().getSeverity()); @@ -81,7 +84,7 @@ public class ActualChangeRequestTest2 extends AbstractProvisioningTest { //Try to Install A ProfileChangeRequest req3 = new ProfileChangeRequest(profile1); req3.addInstallableUnits(new IInstallableUnit[] {a}); - req3.setInstallableUnitInclusionRules(a, PlannerHelper.createOptionalInclusionRule(a)); + req3.setInstallableUnitInclusionRules(a, ProfileInclusionRules.createOptionalInclusionRule(a)); IProvisioningPlan plan3 = planner.getProvisioningPlan(req3, null, null); assertNotNull(((PlannerStatus) plan3.getStatus()).getRequestChanges().get(a)); assertEquals(IStatus.ERROR, ((PlannerStatus) plan3.getStatus()).getRequestChanges().get(a).getSeverity()); @@ -90,7 +93,7 @@ public class ActualChangeRequestTest2 extends AbstractProvisioningTest { //Try to Install A ProfileChangeRequest req4 = new ProfileChangeRequest(profile1); req4.addInstallableUnits(new IInstallableUnit[] {a}); - req4.setInstallableUnitInclusionRules(a, PlannerHelper.createStrictInclusionRule(a)); + req4.setInstallableUnitInclusionRules(a, ProfileInclusionRules.createStrictInclusionRule(a)); IProvisioningPlan plan4 = planner.getProvisioningPlan(req4, null, null); assertNotNull(((PlannerStatus) plan4.getStatus()).getRequestChanges().get(a)); assertEquals(IStatus.ERROR, ((PlannerStatus) plan4.getStatus()).getRequestChanges().get(a).getSeverity()); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/AddIUProperty.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/AddIUProperty.java index f7e71d6ec..ba30167da 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/AddIUProperty.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/AddIUProperty.java @@ -8,9 +8,10 @@ ******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import org.eclipse.core.runtime.IStatus; import org.eclipse.equinox.internal.p2.director.SimplePlanner; -import org.eclipse.equinox.internal.provisional.p2.director.PlannerHelper; import org.eclipse.equinox.internal.provisional.p2.director.ProfileChangeRequest; import org.eclipse.equinox.p2.engine.*; import org.eclipse.equinox.p2.engine.query.IUProfilePropertyQuery; @@ -52,7 +53,7 @@ public class AddIUProperty extends AbstractProvisioningTest { public void testWithIUProperty() { ProfileChangeRequest req = new ProfileChangeRequest(profile); req.addInstallableUnits(new IInstallableUnit[] {a1}); - req.setInstallableUnitInclusionRules(a1, PlannerHelper.createOptionalInclusionRule(a1)); + req.setInstallableUnitInclusionRules(a1, ProfileInclusionRules.createOptionalInclusionRule(a1)); IProvisioningPlan plan = planner.getProvisioningPlan(req, null, null); assertEquals(IStatus.OK, plan.getStatus().getSeverity()); assertInstallOperand(plan, a1); @@ -77,7 +78,7 @@ public class AddIUProperty extends AbstractProvisioningTest { //Add a2, making a1 optional; ProfileChangeRequest req2 = ProfileChangeRequest.createByProfileId(getAgent(), profile.getProfileId()); - req2.setInstallableUnitInclusionRules(a1, PlannerHelper.createOptionalInclusionRule(a1)); + req2.setInstallableUnitInclusionRules(a1, ProfileInclusionRules.createOptionalInclusionRule(a1)); req2.addInstallableUnits(new IInstallableUnit[] {a2}); IProvisioningPlan plan2 = planner.getProvisioningPlan(req2, null, null); assertEquals(IStatus.OK, plan.getStatus().getSeverity()); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/AllOrbit.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/AllOrbit.java index 348b89b2e..938f3b383 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/AllOrbit.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/AllOrbit.java @@ -8,11 +8,12 @@ ******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import java.util.ArrayList; import java.util.Iterator; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.NullProgressMonitor; -import org.eclipse.equinox.internal.provisional.p2.director.PlannerHelper; import org.eclipse.equinox.internal.provisional.p2.director.ProfileChangeRequest; import org.eclipse.equinox.p2.engine.*; import org.eclipse.equinox.p2.metadata.IInstallableUnit; @@ -46,7 +47,7 @@ public class AllOrbit extends AbstractProvisioningTest { for (Iterator iterator = allIUs.iterator(); iterator.hasNext();) { IInstallableUnit iu = (IInstallableUnit) iterator.next(); if (!iu.getId().equals("javax.wsdl")) - req1.setInstallableUnitInclusionRules(iu, PlannerHelper.createOptionalInclusionRule(iu)); + req1.setInstallableUnitInclusionRules(iu, ProfileInclusionRules.createOptionalInclusionRule(iu)); } IProvisioningPlan plan1 = planner.getProvisioningPlan(req1, null, null); assertEquals(IStatus.OK, plan1.getStatus().getSeverity()); @@ -82,7 +83,7 @@ public class AllOrbit extends AbstractProvisioningTest { IInstallableUnit toAdd = (IInstallableUnit) iterator.next(); if (!toAdd.getId().equals("com.ibm.icu")) { toInstall.add(toAdd); - req1.setInstallableUnitInclusionRules(toAdd, PlannerHelper.createOptionalInclusionRule(toAdd)); + req1.setInstallableUnitInclusionRules(toAdd, ProfileInclusionRules.createOptionalInclusionRule(toAdd)); } else removed++; } diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug252638.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug252638.java index 2dc891a66..23af6bae5 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug252638.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug252638.java @@ -10,6 +10,8 @@ *******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import org.eclipse.equinox.p2.metadata.MetadataFactory; import org.eclipse.core.runtime.IStatus; @@ -53,7 +55,7 @@ public class Bug252638 extends AbstractProvisioningTest { ProfileChangeRequest req2 = new ProfileChangeRequest(profile1); req2.addInstallableUnits(new IInstallableUnit[] {p1}); - req2.setInstallableUnitInclusionRules(p1, PlannerHelper.createOptionalInclusionRule(p1)); + req2.setInstallableUnitInclusionRules(p1, ProfileInclusionRules.createOptionalInclusionRule(p1)); IProvisioningPlan plan2 = planner.getProvisioningPlan(req2, null, null); assertEquals(IStatus.OK, plan2.getStatus().getCode()); assertEquals(IStatus.ERROR, ((PlannerStatus) plan2.getStatus()).getRequestChanges().get(p1).getSeverity()); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug254481dataSet1.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug254481dataSet1.java index 6dec96ae4..0608aa07e 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug254481dataSet1.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug254481dataSet1.java @@ -10,10 +10,11 @@ *******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import java.io.File; import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.equinox.internal.p2.engine.SimpleProfileRegistry; -import org.eclipse.equinox.internal.provisional.p2.director.PlannerHelper; import org.eclipse.equinox.internal.provisional.p2.director.ProfileChangeRequest; import org.eclipse.equinox.p2.engine.IProfile; import org.eclipse.equinox.p2.engine.IProvisioningPlan; @@ -51,7 +52,7 @@ public class Bug254481dataSet1 extends AbstractProvisioningTest { IInstallableUnit patch = (IInstallableUnit) c.iterator().next(); ProfileChangeRequest request = new ProfileChangeRequest(profile); request.addInstallableUnits(new IInstallableUnit[] {patch}); - request.setInstallableUnitInclusionRules(patch, PlannerHelper.createOptionalInclusionRule(patch)); + request.setInstallableUnitInclusionRules(patch, ProfileInclusionRules.createOptionalInclusionRule(patch)); IPlanner planner = createPlanner(); IProvisioningPlan plan = planner.getProvisioningPlan(request, null, new NullProgressMonitor()); assertInstallOperand(plan, patch); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug254481dataSet2.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug254481dataSet2.java index 98678da12..daeed261b 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug254481dataSet2.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug254481dataSet2.java @@ -10,10 +10,11 @@ *******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import java.io.File; import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.equinox.internal.p2.engine.SimpleProfileRegistry; -import org.eclipse.equinox.internal.provisional.p2.director.PlannerHelper; import org.eclipse.equinox.internal.provisional.p2.director.ProfileChangeRequest; import org.eclipse.equinox.p2.engine.IProfile; import org.eclipse.equinox.p2.engine.IProvisioningPlan; @@ -51,7 +52,7 @@ public class Bug254481dataSet2 extends AbstractProvisioningTest { IInstallableUnit patch = (IInstallableUnit) c.iterator().next(); ProfileChangeRequest request = new ProfileChangeRequest(profile); request.addInstallableUnits(new IInstallableUnit[] {patch}); - request.setInstallableUnitInclusionRules(patch, PlannerHelper.createOptionalInclusionRule(patch)); + request.setInstallableUnitInclusionRules(patch, ProfileInclusionRules.createOptionalInclusionRule(patch)); IPlanner planner = createPlanner(); IProvisioningPlan plan = planner.getProvisioningPlan(request, null, new NullProgressMonitor()); assertInstallOperand(plan, patch); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug255984.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug255984.java index 1b0311026..80a3dfaab 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug255984.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug255984.java @@ -10,12 +10,13 @@ *******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import org.eclipse.equinox.p2.metadata.MetadataFactory; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.equinox.internal.p2.metadata.IRequiredCapability; -import org.eclipse.equinox.internal.provisional.p2.director.PlannerHelper; import org.eclipse.equinox.internal.provisional.p2.director.ProfileChangeRequest; import org.eclipse.equinox.p2.engine.*; import org.eclipse.equinox.p2.engine.query.IUProfilePropertyQuery; @@ -49,7 +50,7 @@ public class Bug255984 extends AbstractProvisioningTest { profile1 = createProfile("TestProfile." + getName()); ProfileChangeRequest req = new ProfileChangeRequest(profile1); req.addInstallableUnits(new IInstallableUnit[] {b}); - req.setInstallableUnitInclusionRules(b, PlannerHelper.createStrictInclusionRule(b)); + req.setInstallableUnitInclusionRules(b, ProfileInclusionRules.createStrictInclusionRule(b)); req.setInstallableUnitProfileProperty(b, "foo", "bar"); IProvisioningPlan plan = planner.getProvisioningPlan(req, null, null); assertEquals(IStatus.OK, plan.getStatus().getSeverity()); @@ -60,7 +61,7 @@ public class Bug255984 extends AbstractProvisioningTest { //Install A ProfileChangeRequest req2 = new ProfileChangeRequest(profile1); req2.addInstallableUnits(new IInstallableUnit[] {a}); - req2.setInstallableUnitInclusionRules(a, PlannerHelper.createStrictInclusionRule(a)); + req2.setInstallableUnitInclusionRules(a, ProfileInclusionRules.createStrictInclusionRule(a)); req2.setInstallableUnitProfileProperty(a, "foo", "bar"); IProvisioningPlan plan2 = planner.getProvisioningPlan(req2, null, null); assertEquals(IStatus.OK, plan2.getStatus().getSeverity()); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug271067.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug271067.java index 151a37888..09e158489 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug271067.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug271067.java @@ -10,11 +10,12 @@ *******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import java.io.File; import java.lang.reflect.Field; import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.equinox.internal.p2.engine.SimpleProfileRegistry; -import org.eclipse.equinox.internal.provisional.p2.director.PlannerHelper; import org.eclipse.equinox.internal.provisional.p2.director.ProfileChangeRequest; import org.eclipse.equinox.p2.engine.*; import org.eclipse.equinox.p2.metadata.IInstallableUnit; @@ -84,12 +85,12 @@ public class Bug271067 extends AbstractProvisioningTest { installFeature1.addInstallableUnits(new IInstallableUnit[] {featureGroup, featureJar, helloIU, patch, helloPatch, patchJar}); - installFeature1.setInstallableUnitInclusionRules(featureGroup, PlannerHelper.createOptionalInclusionRule(featureGroup)); - installFeature1.setInstallableUnitInclusionRules(featureJar, PlannerHelper.createOptionalInclusionRule(featureJar)); - installFeature1.setInstallableUnitInclusionRules(helloIU, PlannerHelper.createOptionalInclusionRule(helloIU)); - installFeature1.setInstallableUnitInclusionRules(patch, PlannerHelper.createOptionalInclusionRule(patch)); - installFeature1.setInstallableUnitInclusionRules(helloPatch, PlannerHelper.createOptionalInclusionRule(helloPatch)); - installFeature1.setInstallableUnitInclusionRules(patchJar, PlannerHelper.createOptionalInclusionRule(patchJar)); + installFeature1.setInstallableUnitInclusionRules(featureGroup, ProfileInclusionRules.createOptionalInclusionRule(featureGroup)); + installFeature1.setInstallableUnitInclusionRules(featureJar, ProfileInclusionRules.createOptionalInclusionRule(featureJar)); + installFeature1.setInstallableUnitInclusionRules(helloIU, ProfileInclusionRules.createOptionalInclusionRule(helloIU)); + installFeature1.setInstallableUnitInclusionRules(patch, ProfileInclusionRules.createOptionalInclusionRule(patch)); + installFeature1.setInstallableUnitInclusionRules(helloPatch, ProfileInclusionRules.createOptionalInclusionRule(helloPatch)); + installFeature1.setInstallableUnitInclusionRules(patchJar, ProfileInclusionRules.createOptionalInclusionRule(patchJar)); IProvisioningPlan feature1Plan = createPlanner().getProvisioningPlan(installFeature1, new ProvisioningContext(), null); assertOK("installation of feature1 and patch", createEngine().perform(feature1Plan, new NullProgressMonitor())); @@ -101,9 +102,9 @@ public class Bug271067 extends AbstractProvisioningTest { ProfileChangeRequest installFeature2 = new ProfileChangeRequest(getProfile(profileLoadedId)); installFeature2.addInstallableUnits(new IInstallableUnit[] {featureGroup2, helloIU2, featureJar2}); - installFeature2.setInstallableUnitInclusionRules(featureGroup2, PlannerHelper.createOptionalInclusionRule(featureGroup2)); - installFeature2.setInstallableUnitInclusionRules(helloIU2, PlannerHelper.createOptionalInclusionRule(helloIU2)); - installFeature2.setInstallableUnitInclusionRules(featureJar2, PlannerHelper.createOptionalInclusionRule(featureJar2)); + installFeature2.setInstallableUnitInclusionRules(featureGroup2, ProfileInclusionRules.createOptionalInclusionRule(featureGroup2)); + installFeature2.setInstallableUnitInclusionRules(helloIU2, ProfileInclusionRules.createOptionalInclusionRule(helloIU2)); + installFeature2.setInstallableUnitInclusionRules(featureJar2, ProfileInclusionRules.createOptionalInclusionRule(featureJar2)); IProvisioningPlan feature2Plan = createPlanner().getProvisioningPlan(installFeature2, new ProvisioningContext(), null); assertOK("installation of feature2", createEngine().perform(feature2Plan, new NullProgressMonitor())); @@ -117,9 +118,9 @@ public class Bug271067 extends AbstractProvisioningTest { ProfileChangeRequest installFeature2 = new ProfileChangeRequest(getProfile(profileLoadedId)); installFeature2.addInstallableUnits(new IInstallableUnit[] {featureGroup2, helloIU2, featureJar2}); - installFeature2.setInstallableUnitInclusionRules(featureGroup2, PlannerHelper.createOptionalInclusionRule(featureGroup2)); - installFeature2.setInstallableUnitInclusionRules(helloIU2, PlannerHelper.createOptionalInclusionRule(helloIU2)); - installFeature2.setInstallableUnitInclusionRules(featureJar2, PlannerHelper.createOptionalInclusionRule(featureJar2)); + installFeature2.setInstallableUnitInclusionRules(featureGroup2, ProfileInclusionRules.createOptionalInclusionRule(featureGroup2)); + installFeature2.setInstallableUnitInclusionRules(helloIU2, ProfileInclusionRules.createOptionalInclusionRule(helloIU2)); + installFeature2.setInstallableUnitInclusionRules(featureJar2, ProfileInclusionRules.createOptionalInclusionRule(featureJar2)); IProvisioningPlan feature2Plan = createPlanner().getProvisioningPlan(installFeature2, new ProvisioningContext(), null); assertOK("installation of feature2", createEngine().perform(feature2Plan, new NullProgressMonitor())); @@ -135,12 +136,12 @@ public class Bug271067 extends AbstractProvisioningTest { installFeature1.addInstallableUnits(new IInstallableUnit[] {featureGroup, featureJar, helloIU, patch, helloPatch, patchJar}); - installFeature1.setInstallableUnitInclusionRules(featureGroup, PlannerHelper.createOptionalInclusionRule(featureGroup)); - installFeature1.setInstallableUnitInclusionRules(featureJar, PlannerHelper.createOptionalInclusionRule(featureJar)); - installFeature1.setInstallableUnitInclusionRules(helloIU, PlannerHelper.createOptionalInclusionRule(helloIU)); - installFeature1.setInstallableUnitInclusionRules(patch, PlannerHelper.createOptionalInclusionRule(patch)); - installFeature1.setInstallableUnitInclusionRules(helloPatch, PlannerHelper.createOptionalInclusionRule(helloPatch)); - installFeature1.setInstallableUnitInclusionRules(patchJar, PlannerHelper.createOptionalInclusionRule(patchJar)); + installFeature1.setInstallableUnitInclusionRules(featureGroup, ProfileInclusionRules.createOptionalInclusionRule(featureGroup)); + installFeature1.setInstallableUnitInclusionRules(featureJar, ProfileInclusionRules.createOptionalInclusionRule(featureJar)); + installFeature1.setInstallableUnitInclusionRules(helloIU, ProfileInclusionRules.createOptionalInclusionRule(helloIU)); + installFeature1.setInstallableUnitInclusionRules(patch, ProfileInclusionRules.createOptionalInclusionRule(patch)); + installFeature1.setInstallableUnitInclusionRules(helloPatch, ProfileInclusionRules.createOptionalInclusionRule(helloPatch)); + installFeature1.setInstallableUnitInclusionRules(patchJar, ProfileInclusionRules.createOptionalInclusionRule(patchJar)); IProvisioningPlan feature1Plan = createPlanner().getProvisioningPlan(installFeature1, new ProvisioningContext(), null); assertOK("installation of feature1 and patch", createEngine().perform(feature1Plan, new NullProgressMonitor())); @@ -161,16 +162,16 @@ public class Bug271067 extends AbstractProvisioningTest { ProfileChangeRequest installEverything = new ProfileChangeRequest(getProfile(profileLoadedId)); installEverything.addInstallableUnits(new IInstallableUnit[] {featureGroup2, helloIU2, featureJar2, featureGroup, featureJar, helloIU, patch, helloPatch, patchJar}); - installEverything.setInstallableUnitInclusionRules(featureGroup2, PlannerHelper.createOptionalInclusionRule(featureGroup2)); - installEverything.setInstallableUnitInclusionRules(helloIU2, PlannerHelper.createOptionalInclusionRule(helloIU2)); - installEverything.setInstallableUnitInclusionRules(featureJar2, PlannerHelper.createOptionalInclusionRule(featureJar2)); - - installEverything.setInstallableUnitInclusionRules(featureGroup, PlannerHelper.createOptionalInclusionRule(featureGroup)); - installEverything.setInstallableUnitInclusionRules(featureJar, PlannerHelper.createOptionalInclusionRule(featureJar)); - installEverything.setInstallableUnitInclusionRules(helloIU, PlannerHelper.createOptionalInclusionRule(helloIU)); - installEverything.setInstallableUnitInclusionRules(patch, PlannerHelper.createOptionalInclusionRule(patch)); - installEverything.setInstallableUnitInclusionRules(helloPatch, PlannerHelper.createOptionalInclusionRule(helloPatch)); - installEverything.setInstallableUnitInclusionRules(patchJar, PlannerHelper.createOptionalInclusionRule(patchJar)); + installEverything.setInstallableUnitInclusionRules(featureGroup2, ProfileInclusionRules.createOptionalInclusionRule(featureGroup2)); + installEverything.setInstallableUnitInclusionRules(helloIU2, ProfileInclusionRules.createOptionalInclusionRule(helloIU2)); + installEverything.setInstallableUnitInclusionRules(featureJar2, ProfileInclusionRules.createOptionalInclusionRule(featureJar2)); + + installEverything.setInstallableUnitInclusionRules(featureGroup, ProfileInclusionRules.createOptionalInclusionRule(featureGroup)); + installEverything.setInstallableUnitInclusionRules(featureJar, ProfileInclusionRules.createOptionalInclusionRule(featureJar)); + installEverything.setInstallableUnitInclusionRules(helloIU, ProfileInclusionRules.createOptionalInclusionRule(helloIU)); + installEverything.setInstallableUnitInclusionRules(patch, ProfileInclusionRules.createOptionalInclusionRule(patch)); + installEverything.setInstallableUnitInclusionRules(helloPatch, ProfileInclusionRules.createOptionalInclusionRule(helloPatch)); + installEverything.setInstallableUnitInclusionRules(patchJar, ProfileInclusionRules.createOptionalInclusionRule(patchJar)); IProvisioningPlan plan = createPlanner().getProvisioningPlan(installEverything, new ProvisioningContext(), null); assertOK("installation of feature1 and patch", createEngine().perform(plan, new NullProgressMonitor())); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug272251.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug272251.java index 425ac84d6..c65e49444 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug272251.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug272251.java @@ -10,10 +10,11 @@ *******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import java.io.File; import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.equinox.internal.p2.engine.SimpleProfileRegistry; -import org.eclipse.equinox.internal.provisional.p2.director.PlannerHelper; import org.eclipse.equinox.internal.provisional.p2.director.ProfileChangeRequest; import org.eclipse.equinox.p2.engine.IProfile; import org.eclipse.equinox.p2.engine.IProvisioningPlan; @@ -54,7 +55,7 @@ public class Bug272251 extends AbstractProvisioningTest { IInstallableUnit patch = (IInstallableUnit) c.iterator().next(); ProfileChangeRequest request = new ProfileChangeRequest(profile); request.addInstallableUnits(new IInstallableUnit[] {patch}); - request.setInstallableUnitInclusionRules(patch, PlannerHelper.createStrictInclusionRule(patch)); + request.setInstallableUnitInclusionRules(patch, ProfileInclusionRules.createStrictInclusionRule(patch)); IPlanner planner = createPlanner(); IProvisioningPlan plan = planner.getProvisioningPlan(request, null, new NullProgressMonitor()); assertOK("Plan OK", plan.getStatus()); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug278668.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug278668.java index c82d1f5e3..ac74bb4f0 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug278668.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug278668.java @@ -1,12 +1,13 @@ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import org.eclipse.equinox.p2.metadata.MetadataFactory; import java.util.ArrayList; import java.util.Properties; import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.equinox.internal.p2.metadata.IRequiredCapability; -import org.eclipse.equinox.internal.provisional.p2.director.PlannerHelper; import org.eclipse.equinox.internal.provisional.p2.director.ProfileChangeRequest; import org.eclipse.equinox.p2.engine.*; import org.eclipse.equinox.p2.metadata.*; @@ -92,8 +93,8 @@ public class Bug278668 extends AbstractProvisioningTest { ProfileChangeRequest request4 = new ProfileChangeRequest(profile); request4.addInstallableUnits(new IInstallableUnit[] {(IInstallableUnit) c.iterator().next(), (IInstallableUnit) c2.iterator().next()}); - request4.setInstallableUnitInclusionRules((IInstallableUnit) c.iterator().next(), PlannerHelper.createOptionalInclusionRule((IInstallableUnit) c.iterator().next())); - request4.setInstallableUnitInclusionRules((IInstallableUnit) c2.iterator().next(), PlannerHelper.createOptionalInclusionRule((IInstallableUnit) c2.iterator().next())); + request4.setInstallableUnitInclusionRules((IInstallableUnit) c.iterator().next(), ProfileInclusionRules.createOptionalInclusionRule((IInstallableUnit) c.iterator().next())); + request4.setInstallableUnitInclusionRules((IInstallableUnit) c2.iterator().next(), ProfileInclusionRules.createOptionalInclusionRule((IInstallableUnit) c2.iterator().next())); IPlanner planner4 = createPlanner(); IProvisioningPlan plan4 = planner4.getProvisioningPlan(request4, null, new NullProgressMonitor()); assertOK("Plan OK", plan4.getStatus()); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug300104.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug300104.java index 7f27979e3..93fe6098f 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug300104.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug300104.java @@ -10,9 +10,11 @@ *******************************************************************************/
package org.eclipse.equinox.p2.tests.planner;
+
+import org.eclipse.equinox.p2.planner.ProfileInclusionRules;
+
import java.io.File;
import org.eclipse.core.runtime.NullProgressMonitor;
-import org.eclipse.equinox.internal.provisional.p2.director.PlannerHelper;
import org.eclipse.equinox.internal.provisional.p2.director.ProfileChangeRequest;
import org.eclipse.equinox.p2.core.*;
import org.eclipse.equinox.p2.engine.*;
@@ -94,8 +96,8 @@ public class Bug300104 extends AbstractProvisioningTest { installFeature1.addInstallableUnits(new IInstallableUnit[] {featureGroup, featureJar, helloIU});
installFeature1.setInstallableUnitInclusionRules(featureGroup, createInclusionRule(featureGroup, optional));
- installFeature1.setInstallableUnitInclusionRules(featureJar, PlannerHelper.createOptionalInclusionRule(featureJar));
- installFeature1.setInstallableUnitInclusionRules(helloIU, PlannerHelper.createOptionalInclusionRule(helloIU));
+ installFeature1.setInstallableUnitInclusionRules(featureJar, ProfileInclusionRules.createOptionalInclusionRule(featureJar));
+ installFeature1.setInstallableUnitInclusionRules(helloIU, ProfileInclusionRules.createOptionalInclusionRule(helloIU));
IProvisioningPlan feature1Plan = getPlannerService().getProvisioningPlan(installFeature1, new ProvisioningContext(), null);
assertOK("installation of feature1", getEngineService().perform(feature1Plan, new NullProgressMonitor()));
@@ -111,7 +113,7 @@ public class Bug300104 extends AbstractProvisioningTest { }
private String createInclusionRule(IInstallableUnit unit, boolean optional) {
- return optional ? PlannerHelper.createOptionalInclusionRule(unit) : PlannerHelper.createStrictInclusionRule(unit);
+ return optional ? ProfileInclusionRules.createOptionalInclusionRule(unit) : ProfileInclusionRules.createStrictInclusionRule(unit);
}
private void applyHelloPatch1() throws ProvisionException {
@@ -131,9 +133,9 @@ public class Bug300104 extends AbstractProvisioningTest { installFeature1.addInstallableUnits(new IInstallableUnit[] {featureGroup, featureJar, helloIU});
- installFeature1.setInstallableUnitInclusionRules(featureGroup, PlannerHelper.createOptionalInclusionRule(featureGroup));
- installFeature1.setInstallableUnitInclusionRules(featureJar, PlannerHelper.createOptionalInclusionRule(featureJar));
- installFeature1.setInstallableUnitInclusionRules(helloIU, PlannerHelper.createOptionalInclusionRule(helloIU));
+ installFeature1.setInstallableUnitInclusionRules(featureGroup, ProfileInclusionRules.createOptionalInclusionRule(featureGroup));
+ installFeature1.setInstallableUnitInclusionRules(featureJar, ProfileInclusionRules.createOptionalInclusionRule(featureJar));
+ installFeature1.setInstallableUnitInclusionRules(helloIU, ProfileInclusionRules.createOptionalInclusionRule(helloIU));
IProvisioningPlan feature1Plan = getPlannerService().getProvisioningPlan(installFeature1, new ProvisioningContext(), null);
assertOK("installation of feature1", getEngineService().perform(feature1Plan, new NullProgressMonitor()));
@@ -162,10 +164,10 @@ public class Bug300104 extends AbstractProvisioningTest { installFeature1.addInstallableUnits(new IInstallableUnit[] {featureGroup, featureJar, helloIU, hello2IU});
- installFeature1.setInstallableUnitInclusionRules(featureGroup, PlannerHelper.createOptionalInclusionRule(featureGroup));
- installFeature1.setInstallableUnitInclusionRules(featureJar, PlannerHelper.createOptionalInclusionRule(featureJar));
- installFeature1.setInstallableUnitInclusionRules(helloIU, PlannerHelper.createOptionalInclusionRule(helloIU));
- installFeature1.setInstallableUnitInclusionRules(hello2IU, PlannerHelper.createOptionalInclusionRule(hello2IU));
+ installFeature1.setInstallableUnitInclusionRules(featureGroup, ProfileInclusionRules.createOptionalInclusionRule(featureGroup));
+ installFeature1.setInstallableUnitInclusionRules(featureJar, ProfileInclusionRules.createOptionalInclusionRule(featureJar));
+ installFeature1.setInstallableUnitInclusionRules(helloIU, ProfileInclusionRules.createOptionalInclusionRule(helloIU));
+ installFeature1.setInstallableUnitInclusionRules(hello2IU, ProfileInclusionRules.createOptionalInclusionRule(hello2IU));
IProvisioningPlan feature1Plan = getPlannerService().getProvisioningPlan(installFeature1, new ProvisioningContext(), null);
assertOK("installation of feature1", getEngineService().perform(feature1Plan, new NullProgressMonitor()));
diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug302582d.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug302582d.java index 3f7a4e33a..0ac5badb6 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug302582d.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/Bug302582d.java @@ -10,10 +10,11 @@ *******************************************************************************/
package org.eclipse.equinox.p2.tests.planner;
+import org.eclipse.equinox.p2.planner.ProfileInclusionRules;
+
import java.io.File;
import java.util.Iterator;
import org.eclipse.core.runtime.NullProgressMonitor;
-import org.eclipse.equinox.internal.provisional.p2.director.PlannerHelper;
import org.eclipse.equinox.internal.provisional.p2.director.ProfileChangeRequest;
import org.eclipse.equinox.p2.core.*;
import org.eclipse.equinox.p2.engine.IProfileRegistry;
@@ -86,7 +87,7 @@ public class Bug302582d extends AbstractProvisioningTest { Iterator it = ius.iterator();
while (it.hasNext()) {
IInstallableUnit iu = (IInstallableUnit) it.next();
- pcr.setInstallableUnitInclusionRules(iu, PlannerHelper.createOptionalInclusionRule(iu));
+ pcr.setInstallableUnitInclusionRules(iu, ProfileInclusionRules.createOptionalInclusionRule(iu));
}
return pcr;
}
diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/InclusionRuleTest.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/InclusionRuleTest.java index b37913882..7638d4ed5 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/InclusionRuleTest.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/InclusionRuleTest.java @@ -8,8 +8,9 @@ ******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import org.eclipse.core.runtime.IStatus; -import org.eclipse.equinox.internal.provisional.p2.director.PlannerHelper; import org.eclipse.equinox.internal.provisional.p2.director.ProfileChangeRequest; import org.eclipse.equinox.p2.engine.*; import org.eclipse.equinox.p2.metadata.IInstallableUnit; @@ -55,7 +56,7 @@ public class InclusionRuleTest extends AbstractProvisioningTest { //Make a1 optional. ProfileChangeRequest req2 = new ProfileChangeRequest(profile1); - req2.setInstallableUnitInclusionRules(a1, PlannerHelper.createOptionalInclusionRule(a1)); + req2.setInstallableUnitInclusionRules(a1, ProfileInclusionRules.createOptionalInclusionRule(a1)); IProvisioningPlan plan2 = planner.getProvisioningPlan(req2, null, null); assertEquals(IStatus.OK, plan2.getStatus().getSeverity()); engine.perform(plan2, null); @@ -101,7 +102,7 @@ public class InclusionRuleTest extends AbstractProvisioningTest { //Make a1 optional. ProfileChangeRequest req2 = new ProfileChangeRequest(profile2); - req2.setInstallableUnitInclusionRules(a1, PlannerHelper.createOptionalInclusionRule(a1)); + req2.setInstallableUnitInclusionRules(a1, ProfileInclusionRules.createOptionalInclusionRule(a1)); IProvisioningPlan plan2 = planner.getProvisioningPlan(req2, null, null); assertEquals(IStatus.OK, plan2.getStatus().getSeverity()); engine.perform(plan2, null); @@ -141,7 +142,7 @@ public class InclusionRuleTest extends AbstractProvisioningTest { //Make a1 optional. ProfileChangeRequest req2 = new ProfileChangeRequest(profile3); - req2.setInstallableUnitInclusionRules(a1, PlannerHelper.createOptionalInclusionRule(a1)); + req2.setInstallableUnitInclusionRules(a1, ProfileInclusionRules.createOptionalInclusionRule(a1)); IProvisioningPlan plan2 = planner.getProvisioningPlan(req2, null, null); assertEquals(IStatus.OK, plan2.getStatus().getSeverity()); engine.perform(plan2, null); @@ -179,7 +180,7 @@ public class InclusionRuleTest extends AbstractProvisioningTest { //Install a1 and a2 marking a1 optional ProfileChangeRequest req = new ProfileChangeRequest(profile4); req.addInstallableUnits(new IInstallableUnit[] {a1, a2}); - req.setInstallableUnitInclusionRules(a1, PlannerHelper.createOptionalInclusionRule(a1)); + req.setInstallableUnitInclusionRules(a1, ProfileInclusionRules.createOptionalInclusionRule(a1)); IProvisioningPlan plan = planner.getProvisioningPlan(req, null, null); assertEquals(IStatus.OK, plan.getStatus().getSeverity()); engine.perform(plan, null); @@ -188,7 +189,7 @@ public class InclusionRuleTest extends AbstractProvisioningTest { //Make a1 optional, this is a no-op since a1 is not in the system ProfileChangeRequest req2 = new ProfileChangeRequest(profile4); - req2.setInstallableUnitInclusionRules(a1, PlannerHelper.createOptionalInclusionRule(a1)); + req2.setInstallableUnitInclusionRules(a1, ProfileInclusionRules.createOptionalInclusionRule(a1)); IProvisioningPlan plan2 = planner.getProvisioningPlan(req2, null, null); assertEquals(IStatus.OK, plan2.getStatus().getSeverity()); engine.perform(plan2, null); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTest11.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTest11.java index 4e7aace0d..56107c677 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTest11.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTest11.java @@ -10,11 +10,12 @@ *******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import org.eclipse.equinox.p2.metadata.MetadataFactory; import org.eclipse.core.runtime.IStatus; import org.eclipse.equinox.internal.p2.metadata.IRequiredCapability; -import org.eclipse.equinox.internal.provisional.p2.director.PlannerHelper; import org.eclipse.equinox.internal.provisional.p2.director.ProfileChangeRequest; import org.eclipse.equinox.p2.engine.*; import org.eclipse.equinox.p2.metadata.*; @@ -51,7 +52,7 @@ public class PatchTest11 extends AbstractProvisioningTest { //The result is a bit counter intuitive but correct. Only A1 and P1 are installed. No be get installed since the dependency on B is filtered out. ProfileChangeRequest req2 = new ProfileChangeRequest(profile1); req2.addInstallableUnits(new IInstallableUnit[] {a1, p1}); - req2.setInstallableUnitInclusionRules(p1, PlannerHelper.createOptionalInclusionRule(p1)); + req2.setInstallableUnitInclusionRules(p1, ProfileInclusionRules.createOptionalInclusionRule(p1)); IProvisioningPlan plan2 = planner.getProvisioningPlan(req2, null, null); assertTrue(IStatus.ERROR != plan2.getStatus().getSeverity()); assertNoOperand(plan2, b1); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTest12.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTest12.java index 5ee2f9b89..fe3b460c6 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTest12.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTest12.java @@ -10,6 +10,8 @@ *******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import org.eclipse.equinox.p2.metadata.MetadataFactory; import java.util.Set; @@ -54,7 +56,7 @@ public class PatchTest12 extends AbstractProvisioningTest { //the only thing that ends up being installed are A 1.0.0 and B 1.0.0 ProfileChangeRequest req2 = new ProfileChangeRequest(profile1); req2.addInstallableUnits(new IInstallableUnit[] {a1, p1}); - req2.setInstallableUnitInclusionRules(p1, PlannerHelper.createOptionalInclusionRule(p1)); + req2.setInstallableUnitInclusionRules(p1, ProfileInclusionRules.createOptionalInclusionRule(p1)); IProvisioningPlan plan2 = planner.getProvisioningPlan(req2, null, null); assertTrue(IStatus.ERROR != plan2.getStatus().getSeverity()); assertNoOperand(plan2, p1); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTest3.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTest3.java index aafe6ba1f..30b348e46 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTest3.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTest3.java @@ -10,11 +10,12 @@ *******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import org.eclipse.equinox.p2.metadata.MetadataFactory; import org.eclipse.core.runtime.IStatus; import org.eclipse.equinox.internal.p2.metadata.IRequiredCapability; -import org.eclipse.equinox.internal.provisional.p2.director.PlannerHelper; import org.eclipse.equinox.internal.provisional.p2.director.ProfileChangeRequest; import org.eclipse.equinox.p2.engine.*; import org.eclipse.equinox.p2.metadata.*; @@ -69,7 +70,7 @@ public class PatchTest3 extends AbstractProvisioningTest { //Install p1, this should cause b1 to be uninstalled and b2 to be used instead ProfileChangeRequest req2 = new ProfileChangeRequest(profile1); req2.addInstallableUnits(new IInstallableUnit[] {p1}); - req2.setInstallableUnitInclusionRules(p1, PlannerHelper.createOptionalInclusionRule(p1)); + req2.setInstallableUnitInclusionRules(p1, ProfileInclusionRules.createOptionalInclusionRule(p1)); IProvisioningPlan plan2 = planner.getProvisioningPlan(req2, null, null); assertTrue(IStatus.ERROR != plan2.getStatus().getSeverity()); assertInstallOperand(plan2, p1); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTest4.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTest4.java index e37a0ab2c..ed875c47e 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTest4.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTest4.java @@ -10,11 +10,12 @@ *******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import org.eclipse.equinox.p2.metadata.MetadataFactory; import org.eclipse.core.runtime.IStatus; import org.eclipse.equinox.internal.p2.metadata.IRequiredCapability; -import org.eclipse.equinox.internal.provisional.p2.director.PlannerHelper; import org.eclipse.equinox.internal.provisional.p2.director.ProfileChangeRequest; import org.eclipse.equinox.p2.engine.*; import org.eclipse.equinox.p2.metadata.*; @@ -79,7 +80,7 @@ public class PatchTest4 extends AbstractProvisioningTest { //Install p1, this will cause C2 and D2 to be installed ProfileChangeRequest req2 = new ProfileChangeRequest(profile1); req2.addInstallableUnits(new IInstallableUnit[] {p1}); - req2.setInstallableUnitInclusionRules(p1, PlannerHelper.createOptionalInclusionRule(p1)); + req2.setInstallableUnitInclusionRules(p1, ProfileInclusionRules.createOptionalInclusionRule(p1)); IProvisioningPlan plan2 = planner.getProvisioningPlan(req2, null, null); assertTrue(IStatus.ERROR != plan2.getStatus().getSeverity()); assertInstallOperand(plan2, b2); @@ -112,7 +113,7 @@ public class PatchTest4 extends AbstractProvisioningTest { //Install p2, this should cause b1 to be uninstalled and b2 to be used instead ProfileChangeRequest req2 = new ProfileChangeRequest(profile1); req2.addInstallableUnits(new IInstallableUnit[] {p2}); - req2.setInstallableUnitInclusionRules(p1, PlannerHelper.createOptionalInclusionRule(p1)); + req2.setInstallableUnitInclusionRules(p1, ProfileInclusionRules.createOptionalInclusionRule(p1)); IProvisioningPlan plan2 = planner.getProvisioningPlan(req2, null, null); assertTrue(IStatus.ERROR != plan2.getStatus().getSeverity()); assertInstallOperand(plan2, b2); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTestMultiplePatch3.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTestMultiplePatch3.java index 1c42b003c..8460d69b5 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTestMultiplePatch3.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTestMultiplePatch3.java @@ -10,10 +10,11 @@ *******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import org.eclipse.equinox.p2.metadata.MetadataFactory; import org.eclipse.equinox.internal.p2.metadata.IRequiredCapability; -import org.eclipse.equinox.internal.provisional.p2.director.PlannerHelper; import org.eclipse.equinox.internal.provisional.p2.director.ProfileChangeRequest; import org.eclipse.equinox.p2.engine.IProfile; import org.eclipse.equinox.p2.engine.IProvisioningPlan; @@ -70,7 +71,7 @@ public class PatchTestMultiplePatch3 extends AbstractProvisioningTest { req.addInstallableUnits(new IInstallableUnit[] {p2Feature}); req.addInstallableUnits(new IInstallableUnit[] {pp1}); req.addInstallableUnits(new IInstallableUnit[] {pp2}); - req.setInstallableUnitInclusionRules(pp2, PlannerHelper.createOptionalInclusionRule(pp2)); + req.setInstallableUnitInclusionRules(pp2, ProfileInclusionRules.createOptionalInclusionRule(pp2)); IProvisioningPlan plan = planner.getProvisioningPlan(req, null, null); assertOK("Planning should be ok", plan.getStatus()); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTestUpdate.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTestUpdate.java index ad8562668..8797477bc 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTestUpdate.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTestUpdate.java @@ -10,6 +10,8 @@ *******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import org.eclipse.equinox.p2.metadata.MetadataFactory; import java.util.Set; @@ -76,7 +78,7 @@ public class PatchTestUpdate extends AbstractProvisioningTest { //The update of the feature is expected to fail because the patches are installed without flexibility (strict mode) ProfileChangeRequest req1 = new ProfileChangeRequest(profile1); req1.addInstallableUnits(new IInstallableUnit[] {p2Feature20}); - req1.setInstallableUnitInclusionRules(p2Feature20, PlannerHelper.createStrictInclusionRule(p2Feature20)); + req1.setInstallableUnitInclusionRules(p2Feature20, ProfileInclusionRules.createStrictInclusionRule(p2Feature20)); req1.removeInstallableUnits(new IInstallableUnit[] {p2Feature}); IProvisioningPlan plan = planner.getProvisioningPlan(req1, null, null); assertEquals(IStatus.ERROR, plan.getStatus().getSeverity()); @@ -86,7 +88,7 @@ public class PatchTestUpdate extends AbstractProvisioningTest { //The update of the feature is expected to fail because the patches are installed without flexibility (strict mode) ProfileChangeRequest req1 = new ProfileChangeRequest(profile1); req1.addInstallableUnits(new IInstallableUnit[] {p2Feature20}); - req1.setInstallableUnitInclusionRules(p2Feature20, PlannerHelper.createStrictInclusionRule(p2Feature20)); + req1.setInstallableUnitInclusionRules(p2Feature20, ProfileInclusionRules.createStrictInclusionRule(p2Feature20)); req1.removeInstallableUnits(new IInstallableUnit[] {p2Feature}); ProvisioningPlan plan = (ProvisioningPlan) planner.getProvisioningPlan(req1, null, null); assertEquals(IStatus.ERROR, plan.getStatus().getSeverity()); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTestUpdate2.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTestUpdate2.java index 548297a32..f48ff46b0 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTestUpdate2.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTestUpdate2.java @@ -10,11 +10,12 @@ *******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import org.eclipse.equinox.p2.metadata.MetadataFactory; import org.eclipse.core.runtime.IStatus; import org.eclipse.equinox.internal.p2.metadata.IRequiredCapability; -import org.eclipse.equinox.internal.provisional.p2.director.PlannerHelper; import org.eclipse.equinox.internal.provisional.p2.director.ProfileChangeRequest; import org.eclipse.equinox.p2.engine.*; import org.eclipse.equinox.p2.metadata.*; @@ -77,7 +78,7 @@ public class PatchTestUpdate2 extends AbstractProvisioningTest { //The update of the feature is expected to work and to cause the uninstallation of the patch since it is installed optionally ProfileChangeRequest req1 = new ProfileChangeRequest(profile1); req1.addInstallableUnits(new IInstallableUnit[] {p2Feature20}); - req1.setInstallableUnitInclusionRules(p2Feature20, PlannerHelper.createStrictInclusionRule(p2Feature20)); + req1.setInstallableUnitInclusionRules(p2Feature20, ProfileInclusionRules.createStrictInclusionRule(p2Feature20)); req1.removeInstallableUnits(new IInstallableUnit[] {p2Feature}); IProvisioningPlan plan = planner.getProvisioningPlan(req1, null, null); assertEquals(true, IStatus.ERROR != plan.getStatus().getSeverity()); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTestUpdate3.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTestUpdate3.java index b3600086c..52f721ef4 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTestUpdate3.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTestUpdate3.java @@ -10,12 +10,13 @@ *******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import org.eclipse.equinox.p2.metadata.MetadataFactory; import java.net.URI; import org.eclipse.core.runtime.IStatus; import org.eclipse.equinox.internal.p2.metadata.IRequiredCapability; -import org.eclipse.equinox.internal.provisional.p2.director.PlannerHelper; import org.eclipse.equinox.internal.provisional.p2.director.ProfileChangeRequest; import org.eclipse.equinox.p2.engine.*; import org.eclipse.equinox.p2.metadata.*; @@ -84,7 +85,7 @@ public class PatchTestUpdate3 extends AbstractProvisioningTest { //The update of the feature will cause the patch pp2 to be uninstalled because its lifecycle is no longer matched. pp1 stays because its lifecycle is still applicable ProfileChangeRequest req1 = new ProfileChangeRequest(getProfile("TestProfile." + getName())); req1.addInstallableUnits(new IInstallableUnit[] {p2Feature20}); - req1.setInstallableUnitInclusionRules(p2Feature20, PlannerHelper.createStrictInclusionRule(p2Feature20)); + req1.setInstallableUnitInclusionRules(p2Feature20, ProfileInclusionRules.createStrictInclusionRule(p2Feature20)); req1.removeInstallableUnits(new IInstallableUnit[] {p2Feature}); IProvisioningPlan plan = planner.getProvisioningPlan(req1, null, null); assertEquals(true, IStatus.ERROR != plan.getStatus().getSeverity()); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTestUpdate4.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTestUpdate4.java index 6c77ad0f1..655b0c040 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTestUpdate4.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/PatchTestUpdate4.java @@ -10,11 +10,12 @@ *******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import org.eclipse.equinox.p2.metadata.MetadataFactory; import org.eclipse.core.runtime.IStatus; import org.eclipse.equinox.internal.p2.metadata.IRequiredCapability; -import org.eclipse.equinox.internal.provisional.p2.director.PlannerHelper; import org.eclipse.equinox.internal.provisional.p2.director.ProfileChangeRequest; import org.eclipse.equinox.p2.engine.*; import org.eclipse.equinox.p2.metadata.*; @@ -71,7 +72,7 @@ public class PatchTestUpdate4 extends AbstractProvisioningTest { //The update will *not* remove the patch because the lifecycle is wide open (VersionRange.emptyRange) ProfileChangeRequest req1 = new ProfileChangeRequest(profile1); req1.addInstallableUnits(new IInstallableUnit[] {p2Feature20}); - req1.setInstallableUnitInclusionRules(p2Feature20, PlannerHelper.createStrictInclusionRule(p2Feature20)); + req1.setInstallableUnitInclusionRules(p2Feature20, ProfileInclusionRules.createStrictInclusionRule(p2Feature20)); req1.removeInstallableUnits(new IInstallableUnit[] {p2Feature}); IProvisioningPlan plan = planner.getProvisioningPlan(req1, null, null); assertEquals(true, IStatus.ERROR != plan.getStatus().getSeverity()); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/SDKPatchingTest1.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/SDKPatchingTest1.java index 12dac1385..c69d051b6 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/SDKPatchingTest1.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/SDKPatchingTest1.java @@ -10,6 +10,8 @@ *******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import org.eclipse.equinox.p2.metadata.MetadataFactory; import java.io.File; @@ -17,7 +19,6 @@ import java.util.ArrayList; import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.equinox.internal.p2.engine.SimpleProfileRegistry; import org.eclipse.equinox.internal.p2.metadata.IRequiredCapability; -import org.eclipse.equinox.internal.provisional.p2.director.PlannerHelper; import org.eclipse.equinox.internal.provisional.p2.director.ProfileChangeRequest; import org.eclipse.equinox.p2.engine.*; import org.eclipse.equinox.p2.metadata.*; @@ -56,7 +57,7 @@ public class SDKPatchingTest1 extends AbstractProvisioningTest { ctx.setExtraIUs(newIUs); ProfileChangeRequest request = new ProfileChangeRequest(profile); request.addInstallableUnits(new IInstallableUnit[] {patchInstallingCommon}); - request.setInstallableUnitInclusionRules(patchInstallingCommon, PlannerHelper.createOptionalInclusionRule(patchInstallingCommon)); + request.setInstallableUnitInclusionRules(patchInstallingCommon, ProfileInclusionRules.createOptionalInclusionRule(patchInstallingCommon)); IPlanner planner = createPlanner(); IProvisioningPlan plan = planner.getProvisioningPlan(request, ctx, new NullProgressMonitor()); assertOK("Installation plan", plan.getStatus()); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/SDKPatchingTest2.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/SDKPatchingTest2.java index 1f3429e78..ee15292c3 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/SDKPatchingTest2.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/SDKPatchingTest2.java @@ -10,6 +10,8 @@ *******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import org.eclipse.equinox.p2.metadata.MetadataFactory; import java.io.File; @@ -17,7 +19,6 @@ import java.util.ArrayList; import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.equinox.internal.p2.engine.SimpleProfileRegistry; import org.eclipse.equinox.internal.p2.metadata.IRequiredCapability; -import org.eclipse.equinox.internal.provisional.p2.director.PlannerHelper; import org.eclipse.equinox.internal.provisional.p2.director.ProfileChangeRequest; import org.eclipse.equinox.p2.engine.*; import org.eclipse.equinox.p2.metadata.*; @@ -75,8 +76,8 @@ public class SDKPatchingTest2 extends AbstractProvisioningTest { ProfileChangeRequest request = new ProfileChangeRequest(profile); request.addInstallableUnits(new IInstallableUnit[] {patchInstallingJDTLaunching, patchInstallingDebugUI}); - request.setInstallableUnitInclusionRules(patchInstallingJDTLaunching, PlannerHelper.createOptionalInclusionRule(patchInstallingJDTLaunching)); - request.setInstallableUnitInclusionRules(patchInstallingDebugUI, PlannerHelper.createOptionalInclusionRule(patchInstallingDebugUI)); + request.setInstallableUnitInclusionRules(patchInstallingJDTLaunching, ProfileInclusionRules.createOptionalInclusionRule(patchInstallingJDTLaunching)); + request.setInstallableUnitInclusionRules(patchInstallingDebugUI, ProfileInclusionRules.createOptionalInclusionRule(patchInstallingDebugUI)); IPlanner planner = createPlanner(); IProvisioningPlan plan = planner.getProvisioningPlan(request, ctx, new NullProgressMonitor()); assertOK("Installation plan", plan.getStatus()); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/SimpleOptionalTest5.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/SimpleOptionalTest5.java index a2d47b656..9a2bc0f1b 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/SimpleOptionalTest5.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/SimpleOptionalTest5.java @@ -10,8 +10,9 @@ *******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import org.eclipse.core.runtime.NullProgressMonitor; -import org.eclipse.equinox.internal.provisional.p2.director.PlannerHelper; import org.eclipse.equinox.internal.provisional.p2.director.ProfileChangeRequest; import org.eclipse.equinox.p2.engine.*; import org.eclipse.equinox.p2.metadata.IInstallableUnit; @@ -43,15 +44,15 @@ public class SimpleOptionalTest5 extends AbstractProvisioningTest { public void test2() { ProfileChangeRequest req = new ProfileChangeRequest(profile); req.addInstallableUnits(new IInstallableUnit[] {a1, a2}); - req.setInstallableUnitInclusionRules(a1, PlannerHelper.createOptionalInclusionRule(a1)); - req.setInstallableUnitInclusionRules(a2, PlannerHelper.createOptionalInclusionRule(a2)); + req.setInstallableUnitInclusionRules(a1, ProfileInclusionRules.createOptionalInclusionRule(a1)); + req.setInstallableUnitInclusionRules(a2, ProfileInclusionRules.createOptionalInclusionRule(a2)); IProvisioningPlan plan = planner.getProvisioningPlan(req, null, null); engine.perform(plan, new NullProgressMonitor()); assertProfileContains("foo", profile, new IInstallableUnit[] {a1, a2}); ProfileChangeRequest req4 = new ProfileChangeRequest(profile); req4.addInstallableUnits(new IInstallableUnit[] {a2}); - req4.setInstallableUnitInclusionRules(a2, PlannerHelper.createOptionalInclusionRule(a2)); + req4.setInstallableUnitInclusionRules(a2, ProfileInclusionRules.createOptionalInclusionRule(a2)); IProvisioningPlan plan4 = planner.getProvisioningPlan(req4, null, null); engine.perform(plan4, new NullProgressMonitor()); assertProfileContains("foo", profile, new IInstallableUnit[] {a1, a2}); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/SimulatedSharedInstallTest.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/SimulatedSharedInstallTest.java index 072768c4b..5dc6525d5 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/SimulatedSharedInstallTest.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/SimulatedSharedInstallTest.java @@ -10,6 +10,8 @@ *******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import org.eclipse.equinox.p2.metadata.MetadataFactory; import java.net.URI; @@ -49,7 +51,7 @@ public class SimulatedSharedInstallTest extends AbstractProvisioningTest { ProfileChangeRequest request = new ProfileChangeRequest(profile); request.setAbsoluteMode(true); request.addInstallableUnits(new IInstallableUnit[] {a1}); - request.setInstallableUnitInclusionRules(a1, PlannerHelper.createStrictInclusionRule(a1)); + request.setInstallableUnitInclusionRules(a1, ProfileInclusionRules.createStrictInclusionRule(a1)); final ProvisioningContext context = new ProvisioningContext(new URI[0]); IProvisioningPlan plan = planner.getProvisioningPlan(request, context, new NullProgressMonitor()); assertEquals(IStatus.OK, engine.perform(plan, new NullProgressMonitor()).getSeverity()); @@ -68,7 +70,7 @@ public class SimulatedSharedInstallTest extends AbstractProvisioningTest { ProfileChangeRequest request = new ProfileChangeRequest(profile); request.setAbsoluteMode(true); request.addInstallableUnits(new IInstallableUnit[] {c1}); - request.setInstallableUnitInclusionRules(c1, PlannerHelper.createStrictInclusionRule(c1)); + request.setInstallableUnitInclusionRules(c1, ProfileInclusionRules.createStrictInclusionRule(c1)); final ProvisioningContext context = new ProvisioningContext(new URI[0]); IProvisioningPlan plan = planner.getProvisioningPlan(request, context, new NullProgressMonitor()); assertEquals(IStatus.OK, engine.perform(plan, new NullProgressMonitor()).getSeverity()); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/SingletonOptionallyInstalled.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/SingletonOptionallyInstalled.java index 4edbfac3d..829f6a9de 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/SingletonOptionallyInstalled.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/SingletonOptionallyInstalled.java @@ -10,8 +10,9 @@ *******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import org.eclipse.core.runtime.NullProgressMonitor; -import org.eclipse.equinox.internal.provisional.p2.director.PlannerHelper; import org.eclipse.equinox.internal.provisional.p2.director.ProfileChangeRequest; import org.eclipse.equinox.p2.engine.*; import org.eclipse.equinox.p2.metadata.IInstallableUnit; @@ -43,28 +44,28 @@ public class SingletonOptionallyInstalled extends AbstractProvisioningTest { public void test1() { ProfileChangeRequest req = new ProfileChangeRequest(profile); req.addInstallableUnits(new IInstallableUnit[] {a1}); - req.setInstallableUnitInclusionRules(a1, PlannerHelper.createOptionalInclusionRule(a1)); + req.setInstallableUnitInclusionRules(a1, ProfileInclusionRules.createOptionalInclusionRule(a1)); IProvisioningPlan plan = planner.getProvisioningPlan(req, null, null); engine.perform(plan, new NullProgressMonitor()); assertProfileContains("foo", profile, new IInstallableUnit[] {a1}); ProfileChangeRequest req2 = new ProfileChangeRequest(profile); req2.addInstallableUnits(new IInstallableUnit[] {a2}); - req2.setInstallableUnitInclusionRules(a2, PlannerHelper.createOptionalInclusionRule(a2)); + req2.setInstallableUnitInclusionRules(a2, ProfileInclusionRules.createOptionalInclusionRule(a2)); IProvisioningPlan plan2 = planner.getProvisioningPlan(req2, null, null); engine.perform(plan2, new NullProgressMonitor()); assertProfileContains("foo", profile, new IInstallableUnit[] {a2}); ProfileChangeRequest req3 = new ProfileChangeRequest(profile); req3.addInstallableUnits(new IInstallableUnit[] {a1}); - req3.setInstallableUnitInclusionRules(a1, PlannerHelper.createOptionalInclusionRule(a1)); + req3.setInstallableUnitInclusionRules(a1, ProfileInclusionRules.createOptionalInclusionRule(a1)); IProvisioningPlan plan3 = planner.getProvisioningPlan(req3, null, null); engine.perform(plan3, new NullProgressMonitor()); assertProfileContains("foo", profile, new IInstallableUnit[] {a2}); //Here we really expect a2 ProfileChangeRequest req4 = new ProfileChangeRequest(profile); req4.addInstallableUnits(new IInstallableUnit[] {a2}); - req4.setInstallableUnitInclusionRules(a2, PlannerHelper.createOptionalInclusionRule(a2)); + req4.setInstallableUnitInclusionRules(a2, ProfileInclusionRules.createOptionalInclusionRule(a2)); IProvisioningPlan plan4 = planner.getProvisioningPlan(req4, null, null); engine.perform(plan4, new NullProgressMonitor()); assertProfileContains("foo", profile, new IInstallableUnit[] {a2}); @@ -74,15 +75,15 @@ public class SingletonOptionallyInstalled extends AbstractProvisioningTest { public void test2() { ProfileChangeRequest req = new ProfileChangeRequest(profile); req.addInstallableUnits(new IInstallableUnit[] {a1, a2}); - req.setInstallableUnitInclusionRules(a1, PlannerHelper.createOptionalInclusionRule(a1)); - req.setInstallableUnitInclusionRules(a2, PlannerHelper.createOptionalInclusionRule(a2)); + req.setInstallableUnitInclusionRules(a1, ProfileInclusionRules.createOptionalInclusionRule(a1)); + req.setInstallableUnitInclusionRules(a2, ProfileInclusionRules.createOptionalInclusionRule(a2)); IProvisioningPlan plan = planner.getProvisioningPlan(req, null, null); engine.perform(plan, new NullProgressMonitor()); assertProfileContains("foo", profile, new IInstallableUnit[] {a2}); ProfileChangeRequest req4 = new ProfileChangeRequest(profile); req4.addInstallableUnits(new IInstallableUnit[] {a2}); - req4.setInstallableUnitInclusionRules(a2, PlannerHelper.createOptionalInclusionRule(a2)); + req4.setInstallableUnitInclusionRules(a2, ProfileInclusionRules.createOptionalInclusionRule(a2)); IProvisioningPlan plan4 = planner.getProvisioningPlan(req4, null, null); engine.perform(plan4, new NullProgressMonitor()); assertProfileContains("foo", profile, new IInstallableUnit[] {a2}); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/SingletonOptionallyInstalled2.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/SingletonOptionallyInstalled2.java index 3d71179d2..0e220aa9d 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/SingletonOptionallyInstalled2.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/SingletonOptionallyInstalled2.java @@ -10,8 +10,9 @@ *******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import org.eclipse.core.runtime.NullProgressMonitor; -import org.eclipse.equinox.internal.provisional.p2.director.PlannerHelper; import org.eclipse.equinox.internal.provisional.p2.director.ProfileChangeRequest; import org.eclipse.equinox.p2.engine.*; import org.eclipse.equinox.p2.metadata.IInstallableUnit; @@ -43,15 +44,15 @@ public class SingletonOptionallyInstalled2 extends AbstractProvisioningTest { public void test2() { ProfileChangeRequest req = new ProfileChangeRequest(profile); req.addInstallableUnits(new IInstallableUnit[] {a1, a2}); - req.setInstallableUnitInclusionRules(a1, PlannerHelper.createOptionalInclusionRule(a1)); - req.setInstallableUnitInclusionRules(a2, PlannerHelper.createOptionalInclusionRule(a2)); + req.setInstallableUnitInclusionRules(a1, ProfileInclusionRules.createOptionalInclusionRule(a1)); + req.setInstallableUnitInclusionRules(a2, ProfileInclusionRules.createOptionalInclusionRule(a2)); IProvisioningPlan plan = planner.getProvisioningPlan(req, null, null); engine.perform(plan, new NullProgressMonitor()); assertProfileContains("foo", profile, new IInstallableUnit[] {a2}); ProfileChangeRequest req4 = new ProfileChangeRequest(profile); req4.addInstallableUnits(new IInstallableUnit[] {a2}); - req4.setInstallableUnitInclusionRules(a2, PlannerHelper.createOptionalInclusionRule(a2)); + req4.setInstallableUnitInclusionRules(a2, ProfileInclusionRules.createOptionalInclusionRule(a2)); IProvisioningPlan plan4 = planner.getProvisioningPlan(req4, null, null); engine.perform(plan4, new NullProgressMonitor()); assertProfileContains("foo", profile, new IInstallableUnit[] {a2}); diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/TwoVersionsOfWSDL.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/TwoVersionsOfWSDL.java index 3f43f7327..7464371c1 100644 --- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/TwoVersionsOfWSDL.java +++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/planner/TwoVersionsOfWSDL.java @@ -8,9 +8,10 @@ ******************************************************************************/ package org.eclipse.equinox.p2.tests.planner; +import org.eclipse.equinox.p2.planner.ProfileInclusionRules; + import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.NullProgressMonitor; -import org.eclipse.equinox.internal.provisional.p2.director.PlannerHelper; import org.eclipse.equinox.internal.provisional.p2.director.ProfileChangeRequest; import org.eclipse.equinox.p2.engine.*; import org.eclipse.equinox.p2.metadata.IInstallableUnit; @@ -44,8 +45,8 @@ public class TwoVersionsOfWSDL extends AbstractProvisioningTest { //Ensure that p1 causes a1 to resolve ProfileChangeRequest req1 = new ProfileChangeRequest(profile1); req1.addInstallableUnits(new IInstallableUnit[] {wsdl15, wsdl14}); - req1.setInstallableUnitInclusionRules(wsdl15, PlannerHelper.createStrictInclusionRule(wsdl15)); - req1.setInstallableUnitInclusionRules(wsdl14, PlannerHelper.createStrictInclusionRule(wsdl14)); + req1.setInstallableUnitInclusionRules(wsdl15, ProfileInclusionRules.createStrictInclusionRule(wsdl15)); + req1.setInstallableUnitInclusionRules(wsdl14, ProfileInclusionRules.createStrictInclusionRule(wsdl14)); IProvisioningPlan plan1 = planner.getProvisioningPlan(req1, null, null); assertEquals(IStatus.OK, plan1.getStatus().getSeverity()); assertInstallOperand(plan1, wsdl15); |