Bug 509401 - Don't hide I/O problems in ChecksumProducer's computeMD5(File)

If caller doesn't care about I/O problems during checksum calculation,
neither should computeMD5 method.

The only two callers, RecreateRepositoryApplication and PublisherHelper,
now catch such exceptions (to preserve original behavior) and log them
to make troubleshooting easier.

Change-Id: I1e82ac45cc958f4ffc3ed969a50cfa68aec3c8fc
Signed-off-by: Mykola Nikishov <mn@mn.com.ua>

1 files changed, 6 insertions, 5 deletions

diff --git a/bundles/org.eclipse.equinox.p2.repository/src/org/eclipse/equinox/internal/p2/repository/helpers/ChecksumProducer.java b/bundles/org.eclipse.equinox.p2.repository/src/org/eclipse/equinox/internal/p2/repository/helpers/ChecksumProducer.java
index 4296a53fa..fc8cabec6 100644
--- a/bundles/org.eclipse.equinox.p2.repository/src/org/eclipse/equinox/internal/p2/repository/helpers/ChecksumProducer.java
+++ b/bundles/org.eclipse.equinox.p2.repository/src/org/eclipse/equinox/internal/p2/repository/helpers/ChecksumProducer.java
@@ -18,9 +18,12 @@ import java.security.NoSuchAlgorithmException;
 
 public class ChecksumProducer {
 
-	public static String computeMD5(File file) {
-		if (file == null || file.isDirectory() || !file.exists())
-			return null;
+	/**
+	 * @param file should not be <code>null</code>
+	 * @return MD5 checksum of the file or <code>null</code> in case of NoSuchAlgorithmException
+	 * @throws IOException
+	 */
+	public static String computeMD5(File file) throws IOException {
 		InputStream fis = null;
 		try {
 			MessageDigest md5Checker = MessageDigest.getInstance("MD5"); //$NON-NLS-1$
@@ -41,8 +44,6 @@ public class ChecksumProducer {
 			return buf.toString();
 		} catch (NoSuchAlgorithmException e) {
 			return null;
-		} catch (IOException e) {
-			return null;
 		} finally {
 			if (fis != null)
 				try {