diff options
author | Eike Stepper | 2015-05-05 10:43:37 +0000 |
---|---|---|
committer | Pascal Rapicault | 2016-01-02 21:37:54 +0000 |
commit | 2608885d67a3a99406a8cf1bc660241c3574dcfa (patch) | |
tree | eede74565ebabede00dc799b91b5ef2ed20cd45d /bundles/org.eclipse.equinox.p2.metadata.repository | |
parent | d9057d09f6b96fd8b9988299d3eb5131f9a79a98 (diff) | |
download | rt.equinox.p2-2608885d67a3a99406a8cf1bc660241c3574dcfa.tar.gz rt.equinox.p2-2608885d67a3a99406a8cf1bc660241c3574dcfa.tar.xz rt.equinox.p2-2608885d67a3a99406a8cf1bc660241c3574dcfa.zip |
Bug 466249 - Propagate more exceptions to ease problem analysis
We often get problem reports with stack traces that "end" somewhere in
p2 even though it's obvious from looking at these places that there was
a causing exception. These causing exceptions are often not propagated
with the new exception that p2 creates and throws. I'm not sure if
that's on purpose or just an oversight. I've prepared a proposal to
enhance these places and make it easier to analyze the problems that
users report.
Change-Id: Iaa53448c53c18301113b42dbe80558eccec49e8e
Signed-off-by: Eike Stepper <stepper@esc-net.de>
Diffstat (limited to 'bundles/org.eclipse.equinox.p2.metadata.repository')
2 files changed, 14 insertions, 5 deletions
diff --git a/bundles/org.eclipse.equinox.p2.metadata.repository/src/org/eclipse/equinox/internal/p2/metadata/repository/MetadataRepositoryIO.java b/bundles/org.eclipse.equinox.p2.metadata.repository/src/org/eclipse/equinox/internal/p2/metadata/repository/MetadataRepositoryIO.java index 6ee813b62..485594bab 100644 --- a/bundles/org.eclipse.equinox.p2.metadata.repository/src/org/eclipse/equinox/internal/p2/metadata/repository/MetadataRepositoryIO.java +++ b/bundles/org.eclipse.equinox.p2.metadata.repository/src/org/eclipse/equinox/internal/p2/metadata/repository/MetadataRepositoryIO.java @@ -211,10 +211,15 @@ public class MetadataRepositoryIO { theRepository = repositoryHandler.getRepository(); } } catch (SAXException e) { - if (!(e.getException() instanceof OperationCanceledException)) - throw new IOException(e.getMessage()); + if (!(e.getException() instanceof OperationCanceledException)) { + IOException ioException = new IOException(e.getMessage()); + ioException.initCause(e); + throw ioException; + } } catch (ParserConfigurationException e) { - throw new IOException(e.getMessage()); + IOException ioException = new IOException(e.getMessage()); + ioException.initCause(e); + throw ioException; } finally { monitor.done(); stream.close(); diff --git a/bundles/org.eclipse.equinox.p2.metadata.repository/src/org/eclipse/equinox/p2/metadata/io/IUDeserializer.java b/bundles/org.eclipse.equinox.p2.metadata.repository/src/org/eclipse/equinox/p2/metadata/io/IUDeserializer.java index 0f8493bae..63ace1841 100644 --- a/bundles/org.eclipse.equinox.p2.metadata.repository/src/org/eclipse/equinox/p2/metadata/io/IUDeserializer.java +++ b/bundles/org.eclipse.equinox.p2.metadata.repository/src/org/eclipse/equinox/p2/metadata/io/IUDeserializer.java @@ -66,9 +66,13 @@ public class IUDeserializer { } throw new IOException(status.toString()); } catch (ParserConfigurationException configException) { - throw new IOException(configException.getMessage()); + IOException ioException = new IOException(configException.getMessage()); + ioException.initCause(configException); + throw ioException; } catch (SAXException saxException) { - throw new IOException(saxException.getMessage()); + IOException ioException = new IOException(saxException.getMessage()); + ioException.initCause(saxException); + throw ioException; } } |