Skip to main content
diff options
authorAlex Blewitt2016-03-16 01:30:35 +0000
committerAlex Blewitt2016-04-19 08:34:01 +0000
commitbff55f297a5c1f61add01419da9671cfea908c46 (patch)
treec1438bc3be529485b3965a66c4a4cc1893d2320c /bundles/org.eclipse.equinox.p2.discovery
parent30aa50233fe07edc71b6729f7690454170215932 (diff)
Bug 489706 - Replace new Integer() with Integer.valueOf()I20160419-0800
There are a lot of new Integer() calls in the P2 codebase, which results in many duplicate values of Integer being stored, particularly when performing updates or checks. Integer.valueOf() performs this caching already, which means that it's unnecessary to call new Integer() and instead can call Integer.valueOf(). In the places where the int value is being used directly, the call can be further optimised to Integer.parseInt() instead. Replace calls to new Integer() with Integer.valueOf() or .parseInt() as appropriate. Change-Id: Ic760e66084c856fc90cb7c8a358007c975213638 Signed-off-by: Alex Blewitt <>
Diffstat (limited to 'bundles/org.eclipse.equinox.p2.discovery')
1 files changed, 2 insertions, 2 deletions
diff --git a/bundles/org.eclipse.equinox.p2.discovery/src/org/eclipse/equinox/internal/p2/discovery/util/ b/bundles/org.eclipse.equinox.p2.discovery/src/org/eclipse/equinox/internal/p2/discovery/util/
index f2aa2c04f..bf2f1bb3c 100644
--- a/bundles/org.eclipse.equinox.p2.discovery/src/org/eclipse/equinox/internal/p2/discovery/util/
+++ b/bundles/org.eclipse.equinox.p2.discovery/src/org/eclipse/equinox/internal/p2/discovery/util/
@@ -1,5 +1,5 @@
- * Copyright (c) 2009, 2010 Tasktop Technologies and others.
+ * Copyright (c) 2009, 2016 Tasktop Technologies and others.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0
* which accompanies this distribution, and is available at
@@ -32,7 +32,7 @@ public class CatalogCategoryComparator implements Comparator<CatalogCategory> {
// don't have to worry about format, since they were already validated
// note that higher relevance appears first, thus the reverse order of
// the comparison.
- i = new Integer(r2).compareTo(new Integer(r1));
+ i = Integer.valueOf(r2).compareTo(Integer.valueOf(r1));
} else if (r1 == null && r2 != null) {
return 1;
} else if (r2 == null && r1 != null) {

Back to the top