Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMickael Istria2021-11-04 10:48:49 +0000
committerMickael Istria2021-11-04 13:11:00 +0000
commit80ecce3078ec0e9d64f2eab13d705aff2ffebe96 (patch)
tree12737f781a3773cc1ef83cf9abb389a48d07ad3f
parent0b62cb8dd14b40cac16c8ecf2db864cffd975578 (diff)
downloadrt.equinox.p2-80ecce3078ec0e9d64f2eab13d705aff2ffebe96.tar.gz
rt.equinox.p2-80ecce3078ec0e9d64f2eab13d705aff2ffebe96.tar.xz
rt.equinox.p2-80ecce3078ec0e9d64f2eab13d705aff2ffebe96.zip
Use Hex string for PGP key ids in labels
Change-Id: Iaa169362fc406dfc2ae0b0ba24ccaa5dc16d701d Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/187304 Tested-by: Equinox Bot <equinox-bot@eclipse.org> Reviewed-by: Mickael Istria <mistria@redhat.com>
-rw-r--r--bundles/org.eclipse.equinox.p2.artifact.repository/src/org/eclipse/equinox/internal/p2/artifact/processors/pgp/PGPSignatureVerifier.java2
-rw-r--r--bundles/org.eclipse.equinox.p2.engine/src/org/eclipse/equinox/internal/p2/engine/phases/CertificateChecker.java2
-rw-r--r--bundles/org.eclipse.equinox.p2.ui/META-INF/MANIFEST.MF2
-rw-r--r--bundles/org.eclipse.equinox.p2.ui/pom.xml2
-rw-r--r--bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/TrustCertificateDialog.java4
5 files changed, 6 insertions, 6 deletions
diff --git a/bundles/org.eclipse.equinox.p2.artifact.repository/src/org/eclipse/equinox/internal/p2/artifact/processors/pgp/PGPSignatureVerifier.java b/bundles/org.eclipse.equinox.p2.artifact.repository/src/org/eclipse/equinox/internal/p2/artifact/processors/pgp/PGPSignatureVerifier.java
index 3813b2d48..05bbc2398 100644
--- a/bundles/org.eclipse.equinox.p2.artifact.repository/src/org/eclipse/equinox/internal/p2/artifact/processors/pgp/PGPSignatureVerifier.java
+++ b/bundles/org.eclipse.equinox.p2.artifact.repository/src/org/eclipse/equinox/internal/p2/artifact/processors/pgp/PGPSignatureVerifier.java
@@ -133,7 +133,7 @@ public final class PGPSignatureVerifier extends ProcessingStep {
PGPPublicKey publicKey = keystore.getKey(signature.getKeyID());
if (publicKey == null) {
setStatus(new Status(IStatus.ERROR, Activator.ID,
- NLS.bind(Messages.Error_publicKeyNotFound, signature.getKeyID())));
+ NLS.bind(Messages.Error_publicKeyNotFound, Long.toHexString(signature.getKeyID()))));
return;
}
try {
diff --git a/bundles/org.eclipse.equinox.p2.engine/src/org/eclipse/equinox/internal/p2/engine/phases/CertificateChecker.java b/bundles/org.eclipse.equinox.p2.engine/src/org/eclipse/equinox/internal/p2/engine/phases/CertificateChecker.java
index 12bb4cee8..511f3e5f6 100644
--- a/bundles/org.eclipse.equinox.p2.engine/src/org/eclipse/equinox/internal/p2/engine/phases/CertificateChecker.java
+++ b/bundles/org.eclipse.equinox.p2.engine/src/org/eclipse/equinox/internal/p2/engine/phases/CertificateChecker.java
@@ -164,7 +164,7 @@ public class CertificateChecker {
if (DebugHelper.DEBUG_CERTIFICATE_CHECKER_UNTRUSTED && !untrustedPGPKeys.isEmpty()) {
StringBuilder message = new StringBuilder("The following PGP Keys are untrusted:\n"); //$NON-NLS-1$
for (PGPPublicKey untrustedKey : untrustedPGPKeys) {
- message.append(untrustedKey.getKeyID() + "\n"); //$NON-NLS-1$
+ message.append(Long.toHexString(untrustedKey.getKeyID()) + "\n"); //$NON-NLS-1$
message.append(" used by the following artifacts:\n"); //$NON-NLS-1$
for (Entry<IArtifactDescriptor, Collection<PGPPublicKey>> entry : untrustedPGPArtifacts.entrySet()) {
if (entry.getValue().stream().anyMatch(signer -> signer.getKeyID() == untrustedKey.getKeyID())) {
diff --git a/bundles/org.eclipse.equinox.p2.ui/META-INF/MANIFEST.MF b/bundles/org.eclipse.equinox.p2.ui/META-INF/MANIFEST.MF
index f5f8f384b..429c0b980 100644
--- a/bundles/org.eclipse.equinox.p2.ui/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.equinox.p2.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %bundleName
Bundle-SymbolicName: org.eclipse.equinox.p2.ui;singleton:=true
-Bundle-Version: 2.7.200.qualifier
+Bundle-Version: 2.7.300.qualifier
Bundle-Activator: org.eclipse.equinox.internal.p2.ui.ProvUIActivator
Bundle-Vendor: %providerName
Bundle-Localization: plugin
diff --git a/bundles/org.eclipse.equinox.p2.ui/pom.xml b/bundles/org.eclipse.equinox.p2.ui/pom.xml
index 068ec71e3..85a4f9eee 100644
--- a/bundles/org.eclipse.equinox.p2.ui/pom.xml
+++ b/bundles/org.eclipse.equinox.p2.ui/pom.xml
@@ -19,6 +19,6 @@
</parent>
<groupId>org.eclipse.equinox</groupId>
<artifactId>org.eclipse.equinox.p2.ui</artifactId>
- <version>2.7.200-SNAPSHOT</version>
+ <version>2.7.300-SNAPSHOT</version>
<packaging>eclipse-plugin</packaging>
</project>
diff --git a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/TrustCertificateDialog.java b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/TrustCertificateDialog.java
index a37911a92..4c4fc386e 100644
--- a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/TrustCertificateDialog.java
+++ b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/TrustCertificateDialog.java
@@ -187,7 +187,7 @@ public class TrustCertificateDialog extends SelectionDialog {
} else if (o instanceof PGPPublicKey) {
PGPPublicKey key = (PGPPublicKey) o;
destination.setFilterExtensions(new String[] { "*.asc" }); //$NON-NLS-1$
- destination.setFileName(key.getKeyID() + ".asc"); //$NON-NLS-1$
+ destination.setFileName(Long.toHexString(key.getKeyID()) + ".asc"); //$NON-NLS-1$
String path = destination.open();
if (path == null) {
return;
@@ -229,7 +229,7 @@ public class TrustCertificateDialog extends SelectionDialog {
TableViewerColumn idColumn = new TableViewerColumn(listViewer, SWT.NONE);
idColumn.getColumn().setWidth(200);
idColumn.getColumn().setText(ProvUIMessages.TrustCertificateDialog_Id);
- idColumn.setLabelProvider(new PGPOrX509ColumnLabelProvider(key -> Long.toString(key.getKeyID()),
+ idColumn.setLabelProvider(new PGPOrX509ColumnLabelProvider(key -> Long.toHexString(key.getKeyID()),
cert -> cert.getSerialNumber().toString()));
TableViewerColumn signerColumn = new TableViewerColumn(listViewer, SWT.NONE);
signerColumn.getColumn().setText(ProvUIMessages.TrustCertificateDialog_Name);

Back to the top