Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexander Kurtakov2021-10-07 07:03:39 +0000
committerAlexander Kurtakov2021-10-07 17:36:00 +0000
commit96d18a09a5250272c6742fa19d5342fbf100bb56 (patch)
tree75c0693df7f9de066c44da00d492e98c79a1a0cb
parent6dde74440392ceaedef52216f3c4483b607699bf (diff)
downloadrt.equinox.p2-I20211009-1800.tar.gz
rt.equinox.p2-I20211009-1800.tar.xz
rt.equinox.p2-I20211009-1800.zip
Give real message when status is not OK in DownloadManagerTestI20211011-1800I20211010-1800I20211009-1800I20211008-1800I20211007-1800
Current "OK" message is totally meaningless Change-Id: Ifd104fa3de7234d1a4cd9580e143f69acb709a22 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com> Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.p2/+/186262 Tested-by: Equinox Bot <equinox-bot@eclipse.org>
-rw-r--r--bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/engine/DownloadManagerTest.java13
1 files changed, 8 insertions, 5 deletions
diff --git a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/engine/DownloadManagerTest.java b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/engine/DownloadManagerTest.java
index 908bb64e9..bd344be8b 100644
--- a/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/engine/DownloadManagerTest.java
+++ b/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/engine/DownloadManagerTest.java
@@ -1,5 +1,5 @@
/*******************************************************************************
- * Copyright (c) 2007, 2017 IBM Corporation and others.
+ * Copyright (c) 2007, 2021 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
@@ -17,7 +17,10 @@ import java.net.URI;
import java.net.URISyntaxException;
import junit.framework.Test;
import junit.framework.TestSuite;
-import org.eclipse.core.runtime.*;
+import org.eclipse.core.runtime.IProgressMonitor;
+import org.eclipse.core.runtime.IStatus;
+import org.eclipse.core.runtime.Status;
+import org.eclipse.core.runtime.URIUtil;
import org.eclipse.equinox.internal.p2.engine.DownloadManager;
import org.eclipse.equinox.p2.engine.ProvisioningContext;
import org.eclipse.equinox.p2.metadata.IArtifactKey;
@@ -177,7 +180,7 @@ public class DownloadManagerTest extends AbstractProvisioningTest {
IArtifactRequest[] requests = new IArtifactRequest[] {createArtifactRequest()};
manager.add(requests);
IStatus result = manager.start(null);
- assertTrue("1.0", result.isOK());
+ assertTrue(result.getMessage(), result.isOK());
// Right now the provisioning context adds these to the manager so
// we have to remove them so as not to affect other tests.
@@ -197,7 +200,7 @@ public class DownloadManagerTest extends AbstractProvisioningTest {
IArtifactRequest[] requests = new IArtifactRequest[] {createArtifactRequest()};
manager.add(requests);
IStatus result = manager.start(null);
- assertTrue("1.0", result.isOK());
+ assertTrue(result.getMessage(), result.isOK());
// Right now the provisioning context adds these to the manager so
// we have to remove them so as not to affect other tests.
@@ -224,7 +227,7 @@ public class DownloadManagerTest extends AbstractProvisioningTest {
IArtifactRequest[] requests = new IArtifactRequest[] {createArtifactRequest()};
manager.add(requests);
IStatus result = manager.start(null);
- assertTrue("1.0", result.isOK());
+ assertTrue(result.getMessage(), result.isOK());
// Right now the provisioning context adds these to the manager so
// we have to remove them so as not to affect other tests.

Back to the top