diff options
| author | Carsten Hammer | 2020-11-01 13:42:46 +0000 |
|---|---|---|
| committer | Carsten Hammer | 2021-03-27 17:05:21 +0000 |
| commit | 74a19e4480eaba4c3426f02f6154bc9180045e50 (patch) | |
| tree | a8cf75acf73610dbc2e47ccaadbca5a38f2890ae | |
| parent | 1e5d4493d0884afc6d6f4a8789aa0eb79f23b7dc (diff) | |
| download | rt.equinox.p2-74a19e4480eaba4c3426f02f6154bc9180045e50.tar.gz rt.equinox.p2-74a19e4480eaba4c3426f02f6154bc9180045e50.tar.xz rt.equinox.p2-74a19e4480eaba4c3426f02f6154bc9180045e50.zip | |
Bug: org.eclipse.equinox.internal.p2.ui.sdk.scheduler.PreviousConfigurationFinder$IdentifierI20210327-1800
defines equals and uses Object.hashCode()
This class overrides equals(Object), but does notoverride hashCode(),
and inherits the implementation of hashCode() from java.lang.Object
(which returnsthe identity hash code, an arbitrary value assigned to the
objectby the VM). Therefore, the class is very likely to violate
theinvariant that equal objects must have equal hashcodes.
If you don't think instances of this class will ever be inserted into a
HashMap/HashTable, the recommended hashCode implementation to use is:
public int hashCode() {
assert false : "hashCode not designed";
return 42; // any arbitrary constant will do
}
Rank: Troubling (14), confidence: High
Pattern: HE_EQUALS_USE_HASHCODE
Type: HE, Category: BAD_PRACTICE (Bad practice)
Change-Id: Ie4e1a6dc1d71882a48721cf3f79ba16be4c947f4
Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
3 files changed, 7 insertions, 2 deletions
diff --git a/bundles/org.eclipse.equinox.p2.ui.sdk.scheduler/META-INF/MANIFEST.MF b/bundles/org.eclipse.equinox.p2.ui.sdk.scheduler/META-INF/MANIFEST.MF index 905c3b1d9..132794346 100644 --- a/bundles/org.eclipse.equinox.p2.ui.sdk.scheduler/META-INF/MANIFEST.MF +++ b/bundles/org.eclipse.equinox.p2.ui.sdk.scheduler/META-INF/MANIFEST.MF @@ -2,7 +2,7 @@ Manifest-Version: 1.0 Bundle-ManifestVersion: 2 Bundle-Name: %bundleName Bundle-SymbolicName: org.eclipse.equinox.p2.ui.sdk.scheduler;singleton:=true -Bundle-Version: 1.5.0.qualifier +Bundle-Version: 1.5.100.qualifier Bundle-Activator: org.eclipse.equinox.internal.p2.ui.sdk.scheduler.AutomaticUpdatePlugin Bundle-Vendor: %providerName Bundle-Localization: plugin diff --git a/bundles/org.eclipse.equinox.p2.ui.sdk.scheduler/pom.xml b/bundles/org.eclipse.equinox.p2.ui.sdk.scheduler/pom.xml index bebe70fe1..a393c25e6 100644 --- a/bundles/org.eclipse.equinox.p2.ui.sdk.scheduler/pom.xml +++ b/bundles/org.eclipse.equinox.p2.ui.sdk.scheduler/pom.xml @@ -9,6 +9,6 @@ </parent> <groupId>org.eclipse.equinox</groupId> <artifactId>org.eclipse.equinox.p2.ui.sdk.scheduler</artifactId> - <version>1.5.0-SNAPSHOT</version> + <version>1.5.100-SNAPSHOT</version> <packaging>eclipse-plugin</packaging> </project> diff --git a/bundles/org.eclipse.equinox.p2.ui.sdk.scheduler/src/org/eclipse/equinox/internal/p2/ui/sdk/scheduler/PreviousConfigurationFinder.java b/bundles/org.eclipse.equinox.p2.ui.sdk.scheduler/src/org/eclipse/equinox/internal/p2/ui/sdk/scheduler/PreviousConfigurationFinder.java index f435ef242..a87721308 100644 --- a/bundles/org.eclipse.equinox.p2.ui.sdk.scheduler/src/org/eclipse/equinox/internal/p2/ui/sdk/scheduler/PreviousConfigurationFinder.java +++ b/bundles/org.eclipse.equinox.p2.ui.sdk.scheduler/src/org/eclipse/equinox/internal/p2/ui/sdk/scheduler/PreviousConfigurationFinder.java @@ -93,6 +93,11 @@ public class PreviousConfigurationFinder { } @Override + public int hashCode() { + return Objects.hash(major, minor, service); + } + + @Override public String toString() { return "" + major + '.' + minor + '.' + service; //$NON-NLS-1$ } |