diff options
author | Lars Vogel | 2019-08-14 09:55:04 +0000 |
---|---|---|
committer | Lars Vogel | 2019-08-14 12:19:30 +0000 |
commit | cf4181e8df433626800d33ea43d06fcc57761024 (patch) | |
tree | 75cb855efc49b281456c2bea6bb79b708dd6b784 | |
parent | 6d9b69b122af2394d4ffb432a979b5ae819bd69e (diff) | |
download | rt.equinox.p2-cf4181e8df433626800d33ea43d06fcc57761024.tar.gz rt.equinox.p2-cf4181e8df433626800d33ea43d06fcc57761024.tar.xz rt.equinox.p2-cf4181e8df433626800d33ea43d06fcc57761024.zip |
Use StringBuilder in org.eclipse.equinox.p2.uiI20190814-1800
Change-Id: I5be51b9af66543e64a20c1078eadb743b68a5d09
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
13 files changed, 14 insertions, 14 deletions
diff --git a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/UpdateManagerCompatibility.java b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/UpdateManagerCompatibility.java index b2e78262a..ab481eddd 100644 --- a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/UpdateManagerCompatibility.java +++ b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/UpdateManagerCompatibility.java @@ -256,7 +256,7 @@ public class UpdateManagerCompatibility { } private static String getWritableXMLString(String value) { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); if (value == null) return buf.toString(); for (int i = 0; i < value.length(); i++) { diff --git a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/AvailableIUsPage.java b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/AvailableIUsPage.java index 4fba0afbe..e07c2ff6b 100644 --- a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/AvailableIUsPage.java +++ b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/AvailableIUsPage.java @@ -617,7 +617,7 @@ public class AvailableIUsPage extends ProvisioningWizardPage implements ISelecta // Now look for IU's java.util.List<IInstallableUnit> selected = getSelectedIUs(); if (selected.size() == 1) { - StringBuffer result = new StringBuffer(); + StringBuilder result = new StringBuilder(); String filterString = availableIUGroup.getFilterString(); String description = selected.get(0).getProperty(IInstallableUnit.PROP_DESCRIPTION, null); if (description != null) { diff --git a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/CopyUtils.java b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/CopyUtils.java index 54fc8bded..e1d2c2a51 100644 --- a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/CopyUtils.java +++ b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/CopyUtils.java @@ -35,7 +35,7 @@ public class CopyUtils { private static final String CONTROL_ID = "org.eclipse.equinox.p2.ui.CopyControlId"; //$NON-NLS-1$ public static String getIndentedClipboardText(Object[] elements, IUDetailsLabelProvider labelProvider) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); for (int i = 0; i < elements.length; i++) { if (i > 0) buffer.append(NEWLINE); @@ -74,7 +74,7 @@ public class CopyUtils { } } - private static void appendIndention(StringBuffer buffer, Object element) { + private static void appendIndention(StringBuilder buffer, Object element) { Object parent; while (element instanceof ProvElement && (parent = ((ProvElement) element).getParent(element)) != null) { buffer.append(NESTING_INDENT); diff --git a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/SelectableIUsPage.java b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/SelectableIUsPage.java index 7a66fe517..f7a80f761 100644 --- a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/SelectableIUsPage.java +++ b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/SelectableIUsPage.java @@ -280,7 +280,7 @@ public class SelectableIUsPage extends ResolutionStatusPage implements IResoluti @Override protected String getClipboardText(Control control) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); Object[] elements = getSelectedElements(); for (int i = 0; i < elements.length; i++) { if (i > 0) diff --git a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/UpdateSingleIUPage.java b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/UpdateSingleIUPage.java index db3a65f1e..920a3fa43 100644 --- a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/UpdateSingleIUPage.java +++ b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/UpdateSingleIUPage.java @@ -80,7 +80,7 @@ public class UpdateSingleIUPage extends ProvisioningWizardPage { } private String getUpdateText(IInstallableUnit iu) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(new IUDetailsLabelProvider().getClipboardText(getUpdate().replacement, CopyUtils.DELIMITER)); buffer.append(CopyUtils.NEWLINE); buffer.append(CopyUtils.NEWLINE); diff --git a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/misc/StringMatcher.java b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/misc/StringMatcher.java index f6c5ade56..990bb9e83 100644 --- a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/misc/StringMatcher.java +++ b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/misc/StringMatcher.java @@ -289,7 +289,7 @@ public class StringMatcher { Vector<String> temp = new Vector<>(); int pos = 0; - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); while (pos < fLength) { char c = fPattern.charAt(pos++); switch (c) { diff --git a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/model/CategoryElement.java b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/model/CategoryElement.java index 5d7a19aba..4bcfd6489 100644 --- a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/model/CategoryElement.java +++ b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/model/CategoryElement.java @@ -167,7 +167,7 @@ public class CategoryElement extends RemoteQueriedElement implements IIUElement IInstallableUnit iu = getIU(); if (iu == null) return "NULL"; //$NON-NLS-1$ - StringBuffer result = new StringBuffer(); + StringBuilder result = new StringBuilder(); result.append("Category Element - "); //$NON-NLS-1$ result.append(getMergeKey(iu)); result.append(" (merging IUs: "); //$NON-NLS-1$ diff --git a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/model/MetadataRepositoryElement.java b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/model/MetadataRepositoryElement.java index a1a9295e8..2bbe0b19b 100644 --- a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/model/MetadataRepositoryElement.java +++ b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/model/MetadataRepositoryElement.java @@ -234,7 +234,7 @@ public class MetadataRepositoryElement extends RootElement implements IRepositor @Override public String toString() { - StringBuffer result = new StringBuffer(); + StringBuilder result = new StringBuilder(); result.append("Metadata Repository Element - "); //$NON-NLS-1$ result.append(URIUtil.toUnencodedString(location)); if (hasQueryable()) diff --git a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/viewers/IUDetailsLabelProvider.java b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/viewers/IUDetailsLabelProvider.java index cce455c06..588cbba71 100644 --- a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/viewers/IUDetailsLabelProvider.java +++ b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/viewers/IUDetailsLabelProvider.java @@ -207,7 +207,7 @@ public class IUDetailsLabelProvider extends ColumnLabelProvider implements ITabl } public String getClipboardText(Object element, String columnDelimiter) { - StringBuffer result = new StringBuffer(); + StringBuilder result = new StringBuilder(); for (int i = 0; i < columnConfig.length; i++) { if (i != 0) result.append(columnDelimiter); diff --git a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/viewers/IUDragAdapter.java b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/viewers/IUDragAdapter.java index 9979ad1eb..cc071c6ef 100644 --- a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/viewers/IUDragAdapter.java +++ b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/viewers/IUDragAdapter.java @@ -63,7 +63,7 @@ public class IUDragAdapter extends DragSourceAdapter { } // Get a text description of each IU and set as the drag data - final StringBuffer buffer = new StringBuffer(); + final StringBuilder buffer = new StringBuilder(); for (int i = 0; i < ius.length; i++) { buffer.append(ius[i].toString()); diff --git a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/viewers/RepositoryDetailsLabelProvider.java b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/viewers/RepositoryDetailsLabelProvider.java index 59d85ab36..959799bc6 100644 --- a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/viewers/RepositoryDetailsLabelProvider.java +++ b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/viewers/RepositoryDetailsLabelProvider.java @@ -94,7 +94,7 @@ public class RepositoryDetailsLabelProvider extends LabelProvider implements ITa } public String getClipboardText(Object element, String columnDelimiter) { - StringBuffer result = new StringBuffer(); + StringBuilder result = new StringBuilder(); result.append(getColumnText(element, COL_NAME)); result.append(columnDelimiter); result.append(getColumnText(element, COL_LOCATION)); diff --git a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/p2/ui/AcceptLicensesWizardPage.java b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/p2/ui/AcceptLicensesWizardPage.java index 571db6925..011e4d59e 100644 --- a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/p2/ui/AcceptLicensesWizardPage.java +++ b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/p2/ui/AcceptLicensesWizardPage.java @@ -155,7 +155,7 @@ public class AcceptLicensesWizardPage extends WizardPage { IUColumnConfig versionColumn; static String getIUName(IInstallableUnit iu) { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); String name = iu.getProperty(IInstallableUnit.PROP_NAME, null); if (name != null) buf.append(name); diff --git a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/p2/ui/RepositoryManipulationPage.java b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/p2/ui/RepositoryManipulationPage.java index 73e02c7e0..8955bf7ff 100644 --- a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/p2/ui/RepositoryManipulationPage.java +++ b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/p2/ui/RepositoryManipulationPage.java @@ -902,7 +902,7 @@ public class RepositoryManipulationPage extends PreferencePage implements IWorkb if (elements.length == 0) elements = getElements(); String text = ""; //$NON-NLS-1$ - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); for (int i = 0; i < elements.length; i++) { buffer.append(labelProvider.getClipboardText(elements[i], CopyUtils.DELIMITER)); if (i > 0) |