Bug 235654: Use all the selected elements, not just the visible ones

This changeset modifies the Install New Software dialog to use all the
selected items, not just the visible ones when installing software. 
This means that if the text filter is hiding elements that were already
selected, they will still be installed.

2 files changed, 10 insertions, 3 deletions

diff --git a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/AvailableIUGroup.java b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/AvailableIUGroup.java
index abce9ddbd..26cc67738 100644
--- a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/AvailableIUGroup.java
+++ b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/AvailableIUGroup.java
@@ -300,7 +300,7 @@ public class AvailableIUGroup extends StructuredIUGroup {
 	 * @return the array of checked IU's
 	 */
 	public IInstallableUnit[] getCheckedLeafIUs() {
-		Object[] selections = filteredTree.getCheckboxTreeViewer().getCheckedElements();
+		Object[] selections = filteredTree.getCheckedElements(); // Get all the elements that have been selected, not just the visible ones
 		if (selections.length == 0)
 			return new IInstallableUnit[0];
 		ArrayList<IInstallableUnit> leaves = new ArrayList<IInstallableUnit>(selections.length);
diff --git a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/DelayedFilterCheckboxTree.java b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/DelayedFilterCheckboxTree.java
index ea3bbc23b..2ebc6b531 100644
--- a/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/DelayedFilterCheckboxTree.java
+++ b/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/DelayedFilterCheckboxTree.java
@@ -48,7 +48,7 @@ public class DelayedFilterCheckboxTree extends FilteredTree {
 	WorkbenchJob filterJob;
 	boolean ignoreFiltering = true;
 	Object viewerInput;
-	ArrayList<Object> checkState = new ArrayList<Object>();
+	HashSet<Object> checkState = new HashSet<Object>();
 	Set<Object> expanded = new HashSet<Object>();
 	ContainerCheckedTreeViewer checkboxViewer;
 
@@ -276,7 +276,7 @@ public class DelayedFilterCheckboxTree extends FilteredTree {
 		ContainerCheckedTreeViewer v = (ContainerCheckedTreeViewer) getViewer();
 		Object[] checked = v.getCheckedElements();
 		if (checkState == null)
-			checkState = new ArrayList<Object>(checked.length);
+			checkState = new HashSet<Object>(checked.length);
 		for (int i = 0; i < checked.length; i++)
 			if (!v.getGrayed(checked[i]) && contentProvider.getChildren(checked[i]).length == 0)
 				if (!checkState.contains(checked[i]))
@@ -329,4 +329,11 @@ public class DelayedFilterCheckboxTree extends FilteredTree {
 	protected long getRefreshJobDelay() {
 		return FILTER_DELAY;
 	}
+
+	public Object[] getCheckedElements() {
+		if (this.checkState != null) {
+			return this.checkState.toArray();
+		}
+		return new Object[0];
+	}
 }
\ No newline at end of file