diff options
author | Thomas Watson | 2009-06-12 20:24:55 +0000 |
---|---|---|
committer | Thomas Watson | 2009-06-12 20:24:55 +0000 |
commit | 8d495f4a0076d0ee9fc29c408905d125ae088184 (patch) | |
tree | 869b922dbadca47e2abe421d466ad2f2fad2f424 | |
parent | 726c842e6d22f2d5a41c007ec0157647ce85b950 (diff) | |
download | rt.equinox.framework-8d495f4a0076d0ee9fc29c408905d125ae088184.tar.gz rt.equinox.framework-8d495f4a0076d0ee9fc29c408905d125ae088184.tar.xz rt.equinox.framework-8d495f4a0076d0ee9fc29c408905d125ae088184.zip |
Bug 279401 Two small bugs
2 files changed, 5 insertions, 6 deletions
diff --git a/bundles/org.eclipse.osgi/eclipseAdaptor/src/org/eclipse/core/runtime/adaptor/EclipseLog.java b/bundles/org.eclipse.osgi/eclipseAdaptor/src/org/eclipse/core/runtime/adaptor/EclipseLog.java index 5de78bd8a..c5097e4b8 100644 --- a/bundles/org.eclipse.osgi/eclipseAdaptor/src/org/eclipse/core/runtime/adaptor/EclipseLog.java +++ b/bundles/org.eclipse.osgi/eclipseAdaptor/src/org/eclipse/core/runtime/adaptor/EclipseLog.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2004, 2008 IBM Corporation and others. + * Copyright (c) 2004, 2009 IBM Corporation and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Eclipse Public License v1.0 * which accompanies this distribution, and is available at @@ -335,7 +335,7 @@ public class EclipseLog implements FrameworkLog { backupIdx = 0; } setOutput(newFile, null, append); - FrameworkProperties.setProperty(EclipseStarter.PROP_LOGFILE, newFile.getAbsolutePath()); + FrameworkProperties.setProperty(EclipseStarter.PROP_LOGFILE, newFile == null ? "" : newFile.getAbsolutePath()); //$NON-NLS-1$ } public synchronized File getFile() { diff --git a/bundles/org.eclipse.osgi/eclipseAdaptor/src/org/eclipse/core/runtime/adaptor/EclipseStarter.java b/bundles/org.eclipse.osgi/eclipseAdaptor/src/org/eclipse/core/runtime/adaptor/EclipseStarter.java index 17910e0a2..3f797d1f5 100644 --- a/bundles/org.eclipse.osgi/eclipseAdaptor/src/org/eclipse/core/runtime/adaptor/EclipseStarter.java +++ b/bundles/org.eclipse.osgi/eclipseAdaptor/src/org/eclipse/core/runtime/adaptor/EclipseStarter.java @@ -699,11 +699,10 @@ public class EclipseStarter { private static boolean refreshPackages(Bundle[] bundles) { ServiceReference packageAdminRef = context.getServiceReference(PackageAdmin.class.getName()); PackageAdmin packageAdmin = null; - if (packageAdminRef != null) { + if (packageAdminRef != null) packageAdmin = (PackageAdmin) context.getService(packageAdminRef); - if (packageAdmin == null) - return false; - } + if (packageAdmin == null) + return false; // TODO this is such a hack it is silly. There are still cases for race conditions etc // but this should allow for some progress... final Semaphore semaphore = new Semaphore(0); |