1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
|
/*******************************************************************************
* Copyright (c) 2011, 2013 VMware Inc.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
* which accompanies this distribution, and is available at
* https://www.eclipse.org/legal/epl-2.0/
*
* SPDX-License-Identifier: EPL-2.0
*
* Contributors:
* VMware Inc. - initial contribution
*******************************************************************************/
package org.eclipse.equinox.region.internal.tests.hook;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import java.util.*;
import org.eclipse.equinox.region.*;
import org.eclipse.equinox.region.internal.tests.RegionReflectionUtils;
import org.eclipse.virgo.teststubs.osgi.framework.StubBundle;
import org.eclipse.virgo.teststubs.osgi.framework.StubBundleContext;
import org.junit.*;
import org.osgi.framework.*;
import org.osgi.framework.hooks.bundle.CollisionHook;
public class RegionBundleCollisionHookTests {
private static final String BUNDLE_X = "X";
private static final Version BUNDLE_VERSION = new Version("0");
private long bundleId;
private static final String REGION_A = "RegionA";
private static final String BUNDLE_A = "BundleA";
private static final String REGION_B = "RegionB";
private static final String BUNDLE_B = "BundleB";
private static final String REGION_C = "RegionC";
private static final String BUNDLE_C = "BundleC";
private static final String REGION_D = "RegionD";
private static final String BUNDLE_D = "BundleD";
private RegionDigraph digraph;
private CollisionHook collisionFindHook;
private Map<String, Region> regions;
private Map<String, Bundle> bundles;
private Collection<Bundle> candidates;
private ThreadLocal<Region> threadLocal;
@Before
public void setUp() throws Exception {
this.bundleId = 1L;
this.regions = new HashMap<String, Region>();
this.bundles = new HashMap<String, Bundle>();
StubBundle stubSystemBundle = new StubBundle(0L, "osgi.framework", new Version("0"), "loc");
StubBundleContext stubBundleContext = new StubBundleContext();
stubBundleContext.addInstalledBundle(stubSystemBundle);
this.threadLocal = new ThreadLocal<Region>();
this.digraph = RegionReflectionUtils.newStandardRegionDigraph(stubBundleContext, this.threadLocal);
this.collisionFindHook = RegionReflectionUtils.newRegionBundleCollisionHook(this.digraph, this.threadLocal);
this.candidates = new HashSet<Bundle>();
// Create regions A, B, C, D containing bundles A, B, C, D, respectively.
createRegion(REGION_A, BUNDLE_A);
createRegion(REGION_B, BUNDLE_B);
createRegion(REGION_C, BUNDLE_C);
createRegion(REGION_D, BUNDLE_D);
createBundle(BUNDLE_X);
}
@After
public void tearDown() throws Exception {
// nothing
}
@Test
public void testCollisionInSameRegion() {
this.candidates.add(bundle(BUNDLE_A));
this.collisionFindHook.filterCollisions(CollisionHook.INSTALLING, bundle(BUNDLE_A), this.candidates);
assertTrue(this.candidates.contains(bundle(BUNDLE_A)));
this.collisionFindHook.filterCollisions(CollisionHook.UPDATING, bundle(BUNDLE_A), this.candidates);
assertTrue(this.candidates.contains(bundle(BUNDLE_A)));
}
@Test
public void testCollsionInDisconnectedRegion() {
this.candidates.add(bundle(BUNDLE_B));
this.collisionFindHook.filterCollisions(CollisionHook.INSTALLING, bundle(BUNDLE_A), this.candidates);
assertFalse(this.candidates.contains(bundle(BUNDLE_B)));
this.candidates.add(bundle(BUNDLE_B));
this.collisionFindHook.filterCollisions(CollisionHook.UPDATING, bundle(BUNDLE_A), this.candidates);
assertFalse(this.candidates.contains(bundle(BUNDLE_B)));
}
@Test
public void testCollisionConnectedRegionAllowed() throws BundleException, InvalidSyntaxException {
RegionFilter filter = createFilter(BUNDLE_B);
region(REGION_A).connectRegion(region(REGION_B), filter);
this.candidates.add(bundle(BUNDLE_B));
this.collisionFindHook.filterCollisions(CollisionHook.INSTALLING, bundle(BUNDLE_A), this.candidates);
assertTrue(this.candidates.contains(bundle(BUNDLE_B)));
this.candidates.add(bundle(BUNDLE_B));
this.collisionFindHook.filterCollisions(CollisionHook.UPDATING, bundle(BUNDLE_A), this.candidates);
assertTrue(this.candidates.contains(bundle(BUNDLE_B)));
}
@Test
public void testCollisionConnectedRegionFiltering() throws BundleException, InvalidSyntaxException {
region(REGION_A).connectRegion(region(REGION_B), createFilter(BUNDLE_A));
Bundle aDuplicate = createBundle(BUNDLE_A, false);
region(REGION_B).addBundle(aDuplicate);
this.candidates.add(bundle(BUNDLE_B));
this.candidates.add(aDuplicate);
this.collisionFindHook.filterCollisions(CollisionHook.INSTALLING, bundle(BUNDLE_A), this.candidates);
assertFalse(this.candidates.contains(bundle(BUNDLE_B)));
assertTrue(this.candidates.contains(aDuplicate));
this.candidates.add(bundle(BUNDLE_B));
this.collisionFindHook.filterCollisions(CollisionHook.UPDATING, bundle(BUNDLE_A), this.candidates);
assertFalse(this.candidates.contains(bundle(BUNDLE_B)));
assertTrue(this.candidates.contains(aDuplicate));
}
@Test
public void testCollsionTransitive() throws BundleException, InvalidSyntaxException {
region(REGION_A).connectRegion(region(REGION_B), createFilter(BUNDLE_C));
region(REGION_B).connectRegion(region(REGION_C), createFilter(BUNDLE_C));
region(REGION_C).addBundle(bundle(BUNDLE_X));
this.candidates.add(bundle(BUNDLE_B));
this.candidates.add(bundle(BUNDLE_C));
this.candidates.add(bundle(BUNDLE_X));
this.collisionFindHook.filterCollisions(CollisionHook.INSTALLING, bundle(BUNDLE_A), this.candidates);
assertTrue(this.candidates.contains(bundle(BUNDLE_C)));
assertFalse(this.candidates.contains(bundle(BUNDLE_B)));
assertFalse(this.candidates.contains(bundle(BUNDLE_X)));
}
@Test
public void testCollisionInCyclicGraph() throws BundleException, InvalidSyntaxException {
region(REGION_D).addBundle(bundle(BUNDLE_X));
region(REGION_A).connectRegion(region(REGION_B), createFilter(BUNDLE_D, BUNDLE_X));
region(REGION_B).connectRegion(region(REGION_A), createFilter());
region(REGION_B).connectRegion(region(REGION_D), createFilter(BUNDLE_D));
region(REGION_D).connectRegion(region(REGION_B), createFilter());
region(REGION_B).connectRegion(region(REGION_C), createFilter(BUNDLE_X));
region(REGION_C).connectRegion(region(REGION_B), createFilter());
region(REGION_C).connectRegion(region(REGION_D), createFilter(BUNDLE_X));
region(REGION_D).connectRegion(region(REGION_C), createFilter());
region(REGION_A).connectRegion(region(REGION_C), createFilter());
region(REGION_C).connectRegion(region(REGION_A), createFilter());
region(REGION_D).connectRegion(region(REGION_A), createFilter());
region(REGION_A).connectRegion(region(REGION_D), createFilter());
// Collide from region A.
this.candidates.add(bundle(BUNDLE_B));
this.candidates.add(bundle(BUNDLE_C));
this.candidates.add(bundle(BUNDLE_D));
this.candidates.add(bundle(BUNDLE_X));
this.collisionFindHook.filterCollisions(CollisionHook.INSTALLING, bundle(BUNDLE_A), this.candidates);
assertEquals(2, this.candidates.size());
assertTrue(this.candidates.contains(bundle(BUNDLE_D)));
assertTrue(this.candidates.contains(bundle(BUNDLE_X)));
this.candidates.add(bundle(BUNDLE_B));
this.candidates.add(bundle(BUNDLE_C));
this.collisionFindHook.filterCollisions(CollisionHook.UPDATING, bundle(BUNDLE_A), this.candidates);
assertEquals(2, this.candidates.size());
assertTrue(this.candidates.contains(bundle(BUNDLE_D)));
assertTrue(this.candidates.contains(bundle(BUNDLE_X)));
// Collide from region B
this.candidates.add(bundle(BUNDLE_B));
this.candidates.add(bundle(BUNDLE_C));
this.candidates.add(bundle(BUNDLE_D));
this.candidates.add(bundle(BUNDLE_X));
this.collisionFindHook.filterCollisions(CollisionHook.INSTALLING, bundle(BUNDLE_B), this.candidates);
assertEquals(3, this.candidates.size());
assertTrue(this.candidates.contains(bundle(BUNDLE_B)));
assertTrue(this.candidates.contains(bundle(BUNDLE_D)));
assertTrue(this.candidates.contains(bundle(BUNDLE_X)));
this.candidates.add(bundle(BUNDLE_C));
this.collisionFindHook.filterCollisions(CollisionHook.UPDATING, bundle(BUNDLE_B), this.candidates);
assertEquals(3, this.candidates.size());
assertTrue(this.candidates.contains(bundle(BUNDLE_B)));
assertTrue(this.candidates.contains(bundle(BUNDLE_D)));
assertTrue(this.candidates.contains(bundle(BUNDLE_X)));
}
@Test
public void testCollisionFromBundleInNoRegion() {
this.candidates.add(bundle(BUNDLE_A));
Bundle stranger = createBundle("stranger");
this.collisionFindHook.filterCollisions(CollisionHook.INSTALLING, stranger, this.candidates);
assertTrue(this.candidates.contains(bundle(BUNDLE_A)));
this.collisionFindHook.filterCollisions(CollisionHook.UPDATING, stranger, this.candidates);
assertTrue(this.candidates.contains(bundle(BUNDLE_A)));
}
private Region createRegion(String regionName, String... bundleSymbolicNames) throws BundleException {
Region region = this.digraph.createRegion(regionName);
for (String bundleSymbolicName : bundleSymbolicNames) {
Bundle stubBundle = createBundle(bundleSymbolicName);
region.addBundle(stubBundle);
}
this.regions.put(regionName, region);
return region;
}
private Region region(String regionName) {
return this.regions.get(regionName);
}
private RegionFilter createFilter(String... bundleSymbolicNames) throws InvalidSyntaxException {
Collection<String> filters = new ArrayList<String>(bundleSymbolicNames.length);
for (String bundleSymbolicName : bundleSymbolicNames) {
filters.add('(' + RegionFilter.VISIBLE_BUNDLE_NAMESPACE + '=' + bundleSymbolicName + ')');
}
RegionFilterBuilder builder = digraph.createRegionFilterBuilder();
for (String filter : filters) {
builder.allow(RegionFilter.VISIBLE_BUNDLE_NAMESPACE, filter);
}
return builder.build();
}
private Bundle createBundle(String bundleSymbolicName) {
return createBundle(bundleSymbolicName, true);
}
private Bundle createBundle(String bundleSymbolicName, boolean cache) {
Bundle stubBundle = new StubBundle(this.bundleId++, bundleSymbolicName, BUNDLE_VERSION, "loc:" + bundleSymbolicName);
if (cache)
this.bundles.put(bundleSymbolicName, stubBundle);
return stubBundle;
}
private Bundle bundle(String bundleSymbolicName) {
Bundle bundleA = this.bundles.get(bundleSymbolicName);
return bundleA;
}
}
|
