[dogfooding][cleanup] Use new StringBuffer -> StringBuilderY20210810-0820Y20210810-0500Y20210805-0800Y20210804-1030Y20210730-0530Y20210729-0800Y20210727-0800I20210811-1800I20210810-1800I20210809-1800I20210808-1800I20210807-1800I20210806-1800I20210805-1800I20210804-1800I20210804-0930I20210730-1800I20210729-1800I20210729-0050I20210728-1800I20210727-1800I20210726-1800

cleanup for tests.model

To ensure that the new JDT cleanup works correctly for clients we should
run it also on our own code base. This help to ensure that the cleanup
works fine and helps us to cleanup our own code base.

From the commit message of the cleanup:

- create a cleanup to replace usage of StringBuffer with
  StringBuilder.  The two are equivalent, but StringBuffer is
  thread-safe and synchronized which makes it slower than
  StringBuilder which was introduced in Java 1.5.


To avoid API changes, we should only use the local variable change.

Change-Id: Ie6c677c4ac8d0c3a7fa4305d2770fe5783df6473
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
Reviewed-on: https://git.eclipse.org/r/c/equinox/rt.equinox.bundles/+/182678
Tested-by: Equinox Bot <equinox-bot@eclipse.org>

2 files changed, 2 insertions, 2 deletions

diff --git a/bundles/org.eclipse.equinox.preferences/src/org/eclipse/core/internal/preferences/EclipsePreferences.java b/bundles/org.eclipse.equinox.preferences/src/org/eclipse/core/internal/preferences/EclipsePreferences.java
index a5eb8ad08..e039a9b16 100644
--- a/bundles/org.eclipse.equinox.preferences/src/org/eclipse/core/internal/preferences/EclipsePreferences.java
+++ b/bundles/org.eclipse.equinox.preferences/src/org/eclipse/core/internal/preferences/EclipsePreferences.java
@@ -1217,7 +1217,7 @@ public class EclipsePreferences implements IEclipsePreferences, IScope {
 	}
 
 	public String toDeepDebugString() {
-		final StringBuffer buffer = new StringBuffer();
+		final StringBuilder buffer = new StringBuilder();
 		IPreferenceNodeVisitor visitor = (IEclipsePreferences node) -> {
 			buffer.append(node);
 			buffer.append('\n');
diff --git a/bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/CryptoData.java b/bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/CryptoData.java
index 4e9703bab..c7e59a25c 100644
--- a/bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/CryptoData.java
+++ b/bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/CryptoData.java
@@ -93,7 +93,7 @@ public class CryptoData {
 
 	@Override
 	public String toString() {
-		StringBuffer encryptedText = (moduleID == null) ? new StringBuffer() : new StringBuffer(moduleID);
+		StringBuilder encryptedText = (moduleID == null) ? new StringBuilder() : new StringBuilder(moduleID);
 		encryptedText.append(MODULE_ID_SEPARATOR);
 		if (iv != null) {
 			encryptedText.append(Base64.encode(iv));