diff options
| author | Carsten Hammer | 2020-11-01 10:57:53 +0000 |
|---|---|---|
| committer | Thomas Watson | 2020-11-02 15:33:59 +0000 |
| commit | c20ed2fa9145516f41a8ad9650a04488539db747 (patch) | |
| tree | c60c8bd58ff6a59ec72776bc40127546b1b19f29 | |
| parent | 6aeac91aa91276d5a3a9721291290d4136edf3e3 (diff) | |
| download | rt.equinox.bundles-c20ed2fa9145516f41a8ad9650a04488539db747.tar.gz rt.equinox.bundles-c20ed2fa9145516f41a8ad9650a04488539db747.tar.xz rt.equinox.bundles-c20ed2fa9145516f41a8ad9650a04488539db747.zip | |
Bug: Useless condition: it's known that status != -1 at this pointY20201102-1200
This condition always produces the same result as the value of the
involved variable that was narrowed before. Probably something else was
meant or the condition can be removed.
Rank: Troubling (14), confidence: High
Pattern: UC_USELESS_CONDITION
Type: UC, Category: STYLE (Dodgy code)
Change-Id: I787e38b7d4d955ef73d7a8cf5b1c5a2479a2d8f5
Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
| -rw-r--r-- | bundles/org.eclipse.equinox.http.servlet/src/org/eclipse/equinox/http/servlet/internal/servlet/ResponseStateHandler.java | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/bundles/org.eclipse.equinox.http.servlet/src/org/eclipse/equinox/http/servlet/internal/servlet/ResponseStateHandler.java b/bundles/org.eclipse.equinox.http.servlet/src/org/eclipse/equinox/http/servlet/internal/servlet/ResponseStateHandler.java index 149375a74..f5bd5c783 100644 --- a/bundles/org.eclipse.equinox.http.servlet/src/org/eclipse/equinox/http/servlet/internal/servlet/ResponseStateHandler.java +++ b/bundles/org.eclipse.equinox.http.servlet/src/org/eclipse/equinox/http/servlet/internal/servlet/ResponseStateHandler.java @@ -302,11 +302,6 @@ public class ResponseStateHandler { return; } - if (status == -1) { - // There's nothing more we can do here. - return; - } - HttpServletResponse wrappedResponse = (HttpServletResponse)responseWrapper.getResponse(); if (wrappedResponse.isCommitted()) { |