Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCarsten Hammer2020-11-01 11:45:12 +0000
committerCarsten Hammer2020-11-07 18:18:57 +0000
commitf6d40224153ea9561afbf7f5fc2e2e330029d0e8 (patch)
tree64f2f57b7deab9835d468d25585591882b6427ba
parent3f6a2a020f7a7235cfba18e1969a2edbdadb0462 (diff)
downloadrt.equinox.bundles-f6d40224153ea9561afbf7f5fc2e2e330029d0e8.tar.gz
rt.equinox.bundles-f6d40224153ea9561afbf7f5fc2e2e330029d0e8.tar.xz
rt.equinox.bundles-f6d40224153ea9561afbf7f5fc2e2e330029d0e8.zip
Bug: Possible null pointer dereference of identifier in
org.eclipse.core.internal.registry.ExtensionRegistry.addExtensionPoint(String, IContributor, boolean, String, String, Object) There is a branch of statement that, if executed, guarantees that a null value will be dereferenced, which would generate a NullPointerException when the code is executed. Of course, the problem might be that the branch or statement is infeasible and that the null pointer exception can't ever be executed; deciding that is beyond the ability of SpotBugs. Rank: Scary (6), confidence: High Pattern: NP_NULL_ON_SOME_PATH Type: NP, Category: CORRECTNESS (Correctness) Bug introduced in commit 83dc53593d83b80e40b8a874184772cc554f1324 Author: DJ Houghton <dj> 2006-02-16 03:10:00 Committer: DJ Houghton <dj> 2006-02-16 03:10:00 Parent: 62670144db68b8d4e23f14b4a1661b306c0c07ea (Bug 126344 - Simplify the new registry migration process) Child: fdf4ae81c01c37857f9f915106f1a75586e17304 (Bug 127783 - Clean up RegistryStrategy from the org.eclipse.equinox.registry) Branches: change/141820/21, change/144155/1, change/144155/2, change/144155/3, enhancedforloop, master, master2, tostringonarray, origin/bug183883, origin/jetty6, origin/M5_32_branch, origin/master, origin/OSGI_R4_3_Wiring, origin/parsing-on-resolve, origin/R3_2_maintenance, origin/R3_3_maintenance, origin/R3_4_maintenance, origin/R3_5_maintenance, origin/R3_6_maintenance, origin/R3_7_maintenance, origin/R3_8_maintenance, origin/R3_9_maintenance and 17 more branches Tags: v20060215a Bug 112856 - Bundles should be able to contribute extension point to other namespaces Change-Id: I620e4a3c961297b02929dfffbf49111fe7dc4e31 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
-rw-r--r--bundles/org.eclipse.equinox.registry/src/org/eclipse/core/internal/registry/ExtensionRegistry.java1
1 files changed, 1 insertions, 0 deletions
diff --git a/bundles/org.eclipse.equinox.registry/src/org/eclipse/core/internal/registry/ExtensionRegistry.java b/bundles/org.eclipse.equinox.registry/src/org/eclipse/core/internal/registry/ExtensionRegistry.java
index a2aac66c2..717c6fc92 100644
--- a/bundles/org.eclipse.equinox.registry/src/org/eclipse/core/internal/registry/ExtensionRegistry.java
+++ b/bundles/org.eclipse.equinox.registry/src/org/eclipse/core/internal/registry/ExtensionRegistry.java
@@ -1137,6 +1137,7 @@ public class ExtensionRegistry implements IExtensionRegistry, IDynamicExtensionR
if (identifier == null) {
String message = NLS.bind(RegistryMessages.create_failedExtensionPoint, label);
log(new Status(IStatus.ERROR, RegistryMessages.OWNER_NAME, 0, message, null));
+ throw new NullPointerException(message);
}
if (schemaReference == null)
schemaReference = ""; //$NON-NLS-1$

Back to the top