Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCarsten Hammer2019-09-14 20:22:59 +0000
committerLars Vogel2019-10-02 16:32:08 +0000
commit568c75287e0e28e0aed2c884b6e162e1c3e9d634 (patch)
treee658146e9eae43ab8a742ffbe5e44333c91869e1
parent54302a972c36c4094d8ad6034d919425a9599f80 (diff)
downloadrt.equinox.bundles-568c75287e0e28e0aed2c884b6e162e1c3e9d634.tar.gz
rt.equinox.bundles-568c75287e0e28e0aed2c884b6e162e1c3e9d634.tar.xz
rt.equinox.bundles-568c75287e0e28e0aed2c884b6e162e1c3e9d634.zip
Use StringBuilder instead of StringBuffer where possible.I20191002-1800
Change-Id: I72d83f2dcf0e3b360c8d1a752dd3f978ad6bfc0b Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
-rw-r--r--bundles/org.eclipse.equinox.bidi.tests/src/org/eclipse/equinox/bidi/internal/tests/StructuredTextTestBase.java2
-rw-r--r--bundles/org.eclipse.equinox.bidi/src/org/eclipse/equinox/bidi/StructuredTextProcessor.java2
-rw-r--r--bundles/org.eclipse.equinox.compendium.tests/src/org/eclipse/equinox/metatype/tests/AbstractTest.java2
-rwxr-xr-xbundles/org.eclipse.equinox.console.ssh/src/org/eclipse/equinox/console/ssh/SshCommand.java2
-rw-r--r--bundles/org.eclipse.equinox.coordinator/osgi/org/osgi/service/coordinator/CoordinationPermission.java2
-rw-r--r--bundles/org.eclipse.equinox.ds.tests/src/org/eclipse/equinox/ds/tests/tbc/DSEvent.java2
-rw-r--r--bundles/org.eclipse.equinox.http.servlet.tests/src/org/eclipse/equinox/http/servlet/tests/util/ServletRequestAdvisor.java4
-rw-r--r--bundles/org.eclipse.equinox.metatype/src/org/eclipse/equinox/metatype/impl/ValueTokenizer.java4
-rw-r--r--bundles/org.eclipse.equinox.preferences/src/org/eclipse/core/internal/preferences/ExportedPreferences.java2
-rw-r--r--bundles/org.eclipse.equinox.preferences/src/org/eclipse/core/internal/preferences/ImmutableMap.java2
-rw-r--r--bundles/org.eclipse.equinox.preferences/src/org/eclipse/core/internal/preferences/PrefsMessages.java2
-rw-r--r--bundles/org.eclipse.equinox.region/src/org/eclipse/equinox/internal/region/StandardRegionDigraph.java2
-rw-r--r--bundles/org.eclipse.equinox.security.ui/src/org/eclipse/equinox/internal/security/ui/X509CertificateAttributeContentProvider.java6
-rw-r--r--bundles/org.eclipse.equinox.security.ui/src/org/eclipse/equinox/internal/security/ui/storage/TabPassword.java2
-rw-r--r--bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/PasswordManagement.java4
-rw-r--r--bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/SecurePreferencesMapper.java2
-rw-r--r--bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/SecurePreferencesRoot.java2
-rw-r--r--bundles/org.eclipse.equinox.servletbridge/src/org/eclipse/equinox/servletbridge/CloseableURLClassLoader.java2
18 files changed, 23 insertions, 23 deletions
diff --git a/bundles/org.eclipse.equinox.bidi.tests/src/org/eclipse/equinox/bidi/internal/tests/StructuredTextTestBase.java b/bundles/org.eclipse.equinox.bidi.tests/src/org/eclipse/equinox/bidi/internal/tests/StructuredTextTestBase.java
index d8ed9a63f..2d3af054b 100644
--- a/bundles/org.eclipse.equinox.bidi.tests/src/org/eclipse/equinox/bidi/internal/tests/StructuredTextTestBase.java
+++ b/bundles/org.eclipse.equinox.bidi.tests/src/org/eclipse/equinox/bidi/internal/tests/StructuredTextTestBase.java
@@ -99,7 +99,7 @@ public class StructuredTextTestBase {
if (array == null) {
return "null";
}
- StringBuffer sb = new StringBuffer(50);
+ StringBuilder sb = new StringBuilder(50);
int len = array.length;
for (int i = 0; i < len; i++) {
sb.append(array[i]);
diff --git a/bundles/org.eclipse.equinox.bidi/src/org/eclipse/equinox/bidi/StructuredTextProcessor.java b/bundles/org.eclipse.equinox.bidi/src/org/eclipse/equinox/bidi/StructuredTextProcessor.java
index 944c025fa..7330a018e 100644
--- a/bundles/org.eclipse.equinox.bidi/src/org/eclipse/equinox/bidi/StructuredTextProcessor.java
+++ b/bundles/org.eclipse.equinox.bidi/src/org/eclipse/equinox/bidi/StructuredTextProcessor.java
@@ -180,7 +180,7 @@ public final class StructuredTextProcessor {
if ((str == null) || (str.length() <= 1))
return str;
- StringBuffer buf = new StringBuffer();
+ StringBuilder buf = new StringBuilder();
int strLen = str.length();
for (int i = 0; i < strLen; i++) {
char c = str.charAt(i);
diff --git a/bundles/org.eclipse.equinox.compendium.tests/src/org/eclipse/equinox/metatype/tests/AbstractTest.java b/bundles/org.eclipse.equinox.compendium.tests/src/org/eclipse/equinox/metatype/tests/AbstractTest.java
index a173cf4f7..5d0bec222 100644
--- a/bundles/org.eclipse.equinox.compendium.tests/src/org/eclipse/equinox/metatype/tests/AbstractTest.java
+++ b/bundles/org.eclipse.equinox.compendium.tests/src/org/eclipse/equinox/metatype/tests/AbstractTest.java
@@ -111,7 +111,7 @@ public abstract class AbstractTest {
if (value == null || value.length() == 0) {
return value;
}
- StringBuffer result = new StringBuffer(value.length() + 20);
+ StringBuilder result = new StringBuilder(value.length() + 20);
for (int i = 0; i < value.length(); i++) {
char c = value.charAt(i);
if (c == ',' || c == '\\' || Character.isWhitespace(c)) {
diff --git a/bundles/org.eclipse.equinox.console.ssh/src/org/eclipse/equinox/console/ssh/SshCommand.java b/bundles/org.eclipse.equinox.console.ssh/src/org/eclipse/equinox/console/ssh/SshCommand.java
index 064909ef6..1b8c6efa9 100755
--- a/bundles/org.eclipse.equinox.console.ssh/src/org/eclipse/equinox/console/ssh/SshCommand.java
+++ b/bundles/org.eclipse.equinox.console.ssh/src/org/eclipse/equinox/console/ssh/SshCommand.java
@@ -241,7 +241,7 @@ public class SshCommand {
}
private void printHelp() {
- StringBuffer help = new StringBuffer();
+ StringBuilder help = new StringBuilder();
help.append("ssh - start simple ssh server");
help.append("\n");
help.append("Usage: ssh start | stop [-port port] [-host host]");
diff --git a/bundles/org.eclipse.equinox.coordinator/osgi/org/osgi/service/coordinator/CoordinationPermission.java b/bundles/org.eclipse.equinox.coordinator/osgi/org/osgi/service/coordinator/CoordinationPermission.java
index a74635527..03240f79a 100644
--- a/bundles/org.eclipse.equinox.coordinator/osgi/org/osgi/service/coordinator/CoordinationPermission.java
+++ b/bundles/org.eclipse.equinox.coordinator/osgi/org/osgi/service/coordinator/CoordinationPermission.java
@@ -395,7 +395,7 @@ public final class CoordinationPermission extends BasicPermission {
public String getActions() {
String result = actions;
if (result == null) {
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
boolean comma = false;
int mask = action_mask;
diff --git a/bundles/org.eclipse.equinox.ds.tests/src/org/eclipse/equinox/ds/tests/tbc/DSEvent.java b/bundles/org.eclipse.equinox.ds.tests/src/org/eclipse/equinox/ds/tests/tbc/DSEvent.java
index 2b3848aac..f7ae9638b 100644
--- a/bundles/org.eclipse.equinox.ds.tests/src/org/eclipse/equinox/ds/tests/tbc/DSEvent.java
+++ b/bundles/org.eclipse.equinox.ds.tests/src/org/eclipse/equinox/ds/tests/tbc/DSEvent.java
@@ -88,7 +88,7 @@ public class DSEvent implements Comparable {
@Override
public String toString() {
- StringBuffer buf = new StringBuffer("DSEvent[");
+ StringBuilder buf = new StringBuilder("DSEvent[");
buf.append("time=" + this.time + ";action=");
buf.append(getActionAsString());
buf.append(";object=" + (this.object != null ? this.object.toString() : "null"));
diff --git a/bundles/org.eclipse.equinox.http.servlet.tests/src/org/eclipse/equinox/http/servlet/tests/util/ServletRequestAdvisor.java b/bundles/org.eclipse.equinox.http.servlet.tests/src/org/eclipse/equinox/http/servlet/tests/util/ServletRequestAdvisor.java
index 408c23f0b..caa91e65f 100644
--- a/bundles/org.eclipse.equinox.http.servlet.tests/src/org/eclipse/equinox/http/servlet/tests/util/ServletRequestAdvisor.java
+++ b/bundles/org.eclipse.equinox.http.servlet.tests/src/org/eclipse/equinox/http/servlet/tests/util/ServletRequestAdvisor.java
@@ -79,7 +79,7 @@ public class ServletRequestAdvisor extends Object {
}
private String createUrlSpec(String value, boolean isHttps) {
- StringBuffer buffer = new StringBuffer(100);
+ StringBuilder buffer = new StringBuilder(100);
String protocol = "http://"; //$NON-NLS-1$
if (isHttps) {
protocol = "https://";
@@ -104,7 +104,7 @@ public class ServletRequestAdvisor extends Object {
private String drain(InputStream stream) throws IOException {
byte[] bytes = new byte[100];
- StringBuffer buffer = new StringBuffer(500);
+ StringBuilder buffer = new StringBuilder(500);
int length;
while ((length = stream.read(bytes)) != -1) {
String chunk = new String(bytes, 0, length);
diff --git a/bundles/org.eclipse.equinox.metatype/src/org/eclipse/equinox/metatype/impl/ValueTokenizer.java b/bundles/org.eclipse.equinox.metatype/src/org/eclipse/equinox/metatype/impl/ValueTokenizer.java
index 014eb5050..c39ab521f 100644
--- a/bundles/org.eclipse.equinox.metatype/src/org/eclipse/equinox/metatype/impl/ValueTokenizer.java
+++ b/bundles/org.eclipse.equinox.metatype/src/org/eclipse/equinox/metatype/impl/ValueTokenizer.java
@@ -39,7 +39,7 @@ public class ValueTokenizer {
// whitespace characters. Whitespace between two non-whitespace
// characters may or may not be escaped. Also, any character may be
// escaped. The escape character is '\'. The delimiter is ','.
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
// Loop over the characters within the input string and extract each
// value token.
for (int i = 0; i < values_str.length(); i++) {
@@ -136,7 +136,7 @@ public class ValueTokenizer {
if (values.size() == 1) {
return values.get(0);
}
- StringBuffer buffer = new StringBuffer(values.get(0));
+ StringBuilder buffer = new StringBuilder(values.get(0));
for (int i = 1; i < values.size(); i++) {
buffer.append(',');
buffer.append(values.get(i));
diff --git a/bundles/org.eclipse.equinox.preferences/src/org/eclipse/core/internal/preferences/ExportedPreferences.java b/bundles/org.eclipse.equinox.preferences/src/org/eclipse/core/internal/preferences/ExportedPreferences.java
index 6403ef179..0201b86e8 100644
--- a/bundles/org.eclipse.equinox.preferences/src/org/eclipse/core/internal/preferences/ExportedPreferences.java
+++ b/bundles/org.eclipse.equinox.preferences/src/org/eclipse/core/internal/preferences/ExportedPreferences.java
@@ -71,7 +71,7 @@ public class ExportedPreferences extends EclipsePreferences implements IExported
*/
@Override
public String toString() {
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
if (isExportRoot)
buffer.append("* "); //$NON-NLS-1$
buffer.append(absolutePath());
diff --git a/bundles/org.eclipse.equinox.preferences/src/org/eclipse/core/internal/preferences/ImmutableMap.java b/bundles/org.eclipse.equinox.preferences/src/org/eclipse/core/internal/preferences/ImmutableMap.java
index 1e7164a54..dc93f069b 100644
--- a/bundles/org.eclipse.equinox.preferences/src/org/eclipse/core/internal/preferences/ImmutableMap.java
+++ b/bundles/org.eclipse.equinox.preferences/src/org/eclipse/core/internal/preferences/ImmutableMap.java
@@ -281,7 +281,7 @@ public abstract class ImmutableMap implements Cloneable {
@Override
public String toString() {
- StringBuffer s = new StringBuffer();
+ StringBuilder s = new StringBuilder();
String[] keys = keys();
for (int i = 0, length = keys.length; i < length; i++)
s.append(keys[i]).append(" -> ").append(get(keys[i])).append("\n"); //$NON-NLS-2$ //$NON-NLS-1$
diff --git a/bundles/org.eclipse.equinox.preferences/src/org/eclipse/core/internal/preferences/PrefsMessages.java b/bundles/org.eclipse.equinox.preferences/src/org/eclipse/core/internal/preferences/PrefsMessages.java
index d99185231..ba2b2fbb8 100644
--- a/bundles/org.eclipse.equinox.preferences/src/org/eclipse/core/internal/preferences/PrefsMessages.java
+++ b/bundles/org.eclipse.equinox.preferences/src/org/eclipse/core/internal/preferences/PrefsMessages.java
@@ -69,7 +69,7 @@ public class PrefsMessages extends NLS {
* Pre-pend the message with the current date and the name of the current thread.
*/
public static void message(String message) {
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
buffer.append(new Date(System.currentTimeMillis()));
buffer.append(" - ["); //$NON-NLS-1$
buffer.append(Thread.currentThread().getName());
diff --git a/bundles/org.eclipse.equinox.region/src/org/eclipse/equinox/internal/region/StandardRegionDigraph.java b/bundles/org.eclipse.equinox.region/src/org/eclipse/equinox/internal/region/StandardRegionDigraph.java
index 68fa2ab1a..4bbdc43de 100644
--- a/bundles/org.eclipse.equinox.region/src/org/eclipse/equinox/internal/region/StandardRegionDigraph.java
+++ b/bundles/org.eclipse.equinox.region/src/org/eclipse/equinox/internal/region/StandardRegionDigraph.java
@@ -323,7 +323,7 @@ public final class StandardRegionDigraph implements BundleIdToRegionMapping, Reg
@Override
public String toString() {
synchronized (this.monitor) {
- StringBuffer s = new StringBuffer();
+ StringBuilder s = new StringBuilder();
boolean first = true;
s.append("RegionDigraph{"); //$NON-NLS-1$
for (Region r : this) {
diff --git a/bundles/org.eclipse.equinox.security.ui/src/org/eclipse/equinox/internal/security/ui/X509CertificateAttributeContentProvider.java b/bundles/org.eclipse.equinox.security.ui/src/org/eclipse/equinox/internal/security/ui/X509CertificateAttributeContentProvider.java
index 2a55f735e..258a5526f 100644
--- a/bundles/org.eclipse.equinox.security.ui/src/org/eclipse/equinox/internal/security/ui/X509CertificateAttributeContentProvider.java
+++ b/bundles/org.eclipse.equinox.security.ui/src/org/eclipse/equinox/internal/security/ui/X509CertificateAttributeContentProvider.java
@@ -118,7 +118,7 @@ public class X509CertificateAttributeContentProvider implements IStructuredConte
elements.add(sigAlgoItem);
boolean keyUsagesArray[] = theCert.getKeyUsage();
- StringBuffer keyUsages = new StringBuffer();
+ StringBuilder keyUsages = new StringBuilder();
//
// Only set the string field, If we got some data
if (keyUsagesArray != null && keyUsagesArray.length > 0) {
@@ -158,7 +158,7 @@ public class X509CertificateAttributeContentProvider implements IStructuredConte
}
int basicCnstrnts = theCert.getBasicConstraints();
Integer basicConstraint = Integer.valueOf(basicCnstrnts);
- StringBuffer basicCnstrntsBfr = new StringBuffer();
+ StringBuilder basicCnstrntsBfr = new StringBuilder();
if (basicCnstrnts == -1) {
// Not a CA
basicCnstrntsBfr.append(SecurityUIMsg.LABEL_NAMECONSTRAINTS_NOTCA + listDelim);
@@ -178,7 +178,7 @@ public class X509CertificateAttributeContentProvider implements IStructuredConte
List<String> exKeyUsg;
try {
exKeyUsg = theCert.getExtendedKeyUsage();
- StringBuffer exKeyUsgBfr = new StringBuffer();
+ StringBuilder exKeyUsgBfr = new StringBuilder();
if (exKeyUsg != null && exKeyUsg.size() > 0) {
for (Iterator<String> exKeyUsgIter = exKeyUsg.iterator(); exKeyUsgIter.hasNext();) {
exKeyUsgBfr.append((exKeyUsgIter.next()) + listDelim);
diff --git a/bundles/org.eclipse.equinox.security.ui/src/org/eclipse/equinox/internal/security/ui/storage/TabPassword.java b/bundles/org.eclipse.equinox.security.ui/src/org/eclipse/equinox/internal/security/ui/storage/TabPassword.java
index a3345a2b2..07bd6b9bd 100644
--- a/bundles/org.eclipse.equinox.security.ui/src/org/eclipse/equinox/internal/security/ui/storage/TabPassword.java
+++ b/bundles/org.eclipse.equinox.security.ui/src/org/eclipse/equinox/internal/security/ui/storage/TabPassword.java
@@ -277,7 +277,7 @@ public class TabPassword {
if (!providerModified)
return;
// save current selection
- StringBuffer tmp = new StringBuffer();
+ StringBuilder tmp = new StringBuilder();
boolean first = true;
TableItem[] items = providerTable.getItems();
for (TableItem item : items) {
diff --git a/bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/PasswordManagement.java b/bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/PasswordManagement.java
index dbe42fb91..3b0977c81 100644
--- a/bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/PasswordManagement.java
+++ b/bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/PasswordManagement.java
@@ -152,12 +152,12 @@ public class PasswordManagement {
*/
static private String mashPassword(String[] answers) {
// form a string composing answers
- StringBuffer tmp = new StringBuffer();
+ StringBuilder tmp = new StringBuilder();
for (String answer : answers) {
tmp.append(answer.trim());
}
// mix it up
- StringBuffer mix = new StringBuffer();
+ StringBuilder mix = new StringBuilder();
int pos = tmp.length() - 1;
for (int i = 0; i <= pos; i++) {
mix.append(tmp.charAt(i));
diff --git a/bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/SecurePreferencesMapper.java b/bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/SecurePreferencesMapper.java
index 4c0a7a36a..5be2f62a0 100644
--- a/bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/SecurePreferencesMapper.java
+++ b/bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/SecurePreferencesMapper.java
@@ -180,7 +180,7 @@ public class SecurePreferencesMapper {
BufferedReader is = null;
try {
is = new BufferedReader(new FileReader(file));
- StringBuffer buffer = new StringBuffer();
+ StringBuilder buffer = new StringBuilder();
for (;;) { // this eliminates new line characters but that's fine
String tmp = is.readLine();
if (tmp == null)
diff --git a/bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/SecurePreferencesRoot.java b/bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/SecurePreferencesRoot.java
index a0ab7a76c..102f7c0eb 100644
--- a/bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/SecurePreferencesRoot.java
+++ b/bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/SecurePreferencesRoot.java
@@ -407,7 +407,7 @@ public class SecurePreferencesRoot extends SecurePreferences implements IStorage
long num1 = rand.nextInt(10000);
long num2 = rand.nextInt(10000);
- StringBuffer tmp = new StringBuffer();
+ StringBuilder tmp = new StringBuilder();
tmp.append(num1);
tmp.append('\t');
tmp.append(num2);
diff --git a/bundles/org.eclipse.equinox.servletbridge/src/org/eclipse/equinox/servletbridge/CloseableURLClassLoader.java b/bundles/org.eclipse.equinox.servletbridge/src/org/eclipse/equinox/servletbridge/CloseableURLClassLoader.java
index 30ed33113..464e1d689 100644
--- a/bundles/org.eclipse.equinox.servletbridge/src/org/eclipse/equinox/servletbridge/CloseableURLClassLoader.java
+++ b/bundles/org.eclipse.equinox.servletbridge/src/org/eclipse/equinox/servletbridge/CloseableURLClassLoader.java
@@ -241,7 +241,7 @@ public class CloseableURLClassLoader extends URLClassLoader {
*/
private static String ensureUNCPath(String path) {
int len = path.length();
- StringBuffer result = new StringBuffer(len);
+ StringBuilder result = new StringBuilder(len);
for (int i = 0; i < 4; i++) {
// if we have hit the first non-slash character, add another leading slash
if (i >= len || result.length() > 0 || path.charAt(i) != '/')

Back to the top