Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2022-07-27Delete mylyn integrationMatthias Sohn8-699/+0
Mylyn isn't maintained any longer and was removed from Eclipse 2022-06. Hence remove it from EGit. Bug: 562482 Change-Id: I26a95f15c192d7ab3cfab777922ad955497a30dc
2021-09-29[releng] Switch to BREE Java 11Thomas Wolf1-4/+4
Update the BREE in all MANIFEST.MF and .classpaths to JavaSE-11. Update root pom.xml to use --release 11, and to compile against the egit-4.17 target by default. Update the JDT compiler settings. Update tycho to 2.4.0 and the JBoss tycho tools to 2.2.0. Require maven 3.6.3. (3.8.2 is not installed on CI yet?) Remove pack200. Bump spotbugs to 4.4.1; the previously used 3.1.2 uses a groovy version that performs illegal reflective accesses that are forbidden in later Java versions. egit-4.17 corresponds to Eclipse 2020-09, which is the first Eclipse version that required Java 11, and which is EGit's new baseline as of EGit 6.0. In the Oomph setup, use egit-4.18 as default. Eclipse 2020-09 had a critical bug on OS X that shows up in a child Eclipse even on OS X 10.14.6 and that breaks table rendering with custom painting (bug 565969), which breaks the rendering of the EGit history view. Hence developers are encouraged to use a target platform newer than egit-4.17. The CI build will still compile against that platform to ensure that EGit works on its baseline version. Adapt tests so that they work with either target platform. Eclipse platform changed the message in a TitleAreaDialog from Text to Label in 4.18 (bug 564535) and changed it back to Text in 4.21 (bug 574071). This makes SWTBot tests for this message dependent on the JFace version, and causes particular trouble in WizardDialogs. Make TestUtil.processUIEvents() a no-op: running event loops in tests may block the tests if there is an asyncExec queued that opens a modal dialog. Adapt tests not to rely on UI event processing. Fix one bug in GenerateHistoryJob which sometimes didn't update the history view if there were no commits found at all. Add a null check in SpellCheckableMessageArea to work around an NPE occurring on gtk, where apparently forceFocus() may get called on a disposed widget. Bug: 576238 Change-Id: I50b3d6d912e5cce2b5f9fd907c8c66cbde70be73 Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
2019-12-28Enable and execute cleanup "Push down negations"Michael Keppler1-1/+1
Push down negations to make reading of complex expressions with negations easier. Also enable the cleanup as a save action. There is a bug in the cleanup (not adding braces around instanceof expressions), but whenever that occurs, the developer can just add the braces manually, and the bug will not occur again for that location. Therefore that bug should not stop us from using the cleanup. Change-Id: I1a5026304b080b0ccebe06e6829857b784541f99 Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
2019-12-27Upgrade project properties to 2019-12 formatMichael Keppler2-1/+7
Open and save all project property pages to have new values stored explicitly in version control. There are no functional changes (i.e. all lines must be added, or must be a version increment). This change does not guarantee that the properties are the same for all projects in the repository. Change-Id: I39e0bf55811d27ba71ae2adda9010ac26b60bc75 Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
2019-09-21Migrate JDT project settings to 2019-09 formatMichael Keppler2-1/+19
There is no change in settings. All the newly added lines are the default values (e.g. iterate all project property pages and apply without changing any value). Be aware that the projects currently do not use identical settings everywhere. That can be cleaned up later. Change-Id: I1d574ca5336abe1a2ee9cfa74a54700f25cb730d Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
2019-04-08upgrade jdt preferencesMichael Keppler2-1/+43
Upgrade JDT preferences to current versions (by means of browsing the project preference pages). There are no changes in preference values. Change-Id: I50367fba1b83d7d2ff5d4f08b1eb4bc37e94288a Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
2018-10-15Releng: Store all project settings explicitlyMichael Keppler3-3/+61
We use project specific properties in many projects. However, the files containing them are old, therefore they do not contain all the keys and values that have been added in newer Eclipse releases. This change makes all those missing settings explicit. All project properties have been opened in the UI and the "Apply" button has been used without changing any controls. We should therefore see only additions in the diff, no changes in values. The main intention of this change is to reduce the noise for actual changes of settings which are intended to be applied afterwards. If that is accepted, I will do the same on jgit and egit-github. The removal of JDT settings in org.eclipse.egit is intentional. That is a PDE project without Java nature. Change-Id: I1b6d56b2f38e85ec8842076a1aa462a990d09f3f Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
2018-09-23Fix Mylyn commit message templateMichael Keppler1-1/+1
The commit message template contains a superfluous blank at the end of the first line, which is deleted by this change. This is only relevant for egit contributors, not for egit users. Change-Id: I2ebaefe80ecaf5a9373575ec7ebdca7201af3e0d Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>
2017-08-31[releng] Remove "always use braces" from Eclipse save actionsThomas Wolf1-1/+1
The setting applies to the full file, not just the edited lines, and would thus lead to many edits unrelated to a change, increasing the potential for unnecessary conflicts. Change-Id: I25452f72a4164fbdd951ae9d38f689f8dffd73ab Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
2017-08-26Enhance Eclipse save actionsMatthias Sohn1-7/+7
Add the following Eclipse save actions executed when saving modified lines. This should help to reduce manual work needed to maintain a clean and consistent code style: - organize imports - always use braces around blocks - add missing @Deprecated annotations - remove - unused imports - unnecessary $NON-NLS$ tags - redundant type arguments Change-Id: I66a459421b954752232d8c0031ffcec36ae20ec5 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2016-09-20Change EGit minimum execution environment to JavaSE-1.8Matthias Sohn1-3/+3
Bug: 500059 JGit-Dependency: I47f3f6749a67da52029f84e002d9b155ed56d2b7 Change-Id: I7c13a9617fb32774842dc146dab564d15d5033af Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2015-11-16Switching to JGit nullness annotationsAndrey Loskutov1-2/+2
Change-Id: I0f514f8a79dc6110632e0529047bbee42d3841c1 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2015-11-15Follow JGit, use org.eclipse.jgit.annotations.Nullable in EGit tooAndrey Loskutov1-1/+3
Since the commit deb853cb691caf55affe1e4fbfad29b670591140 jgit uses its own Nullable annotation type, so JDT fails to catch NP violations in EGit code which uses default Nullable type from JDT. This looks like a bug in JDT NP analysis, but till it is fixed we better use the JGit version of Nullable. Other annotations aren't affected yet, since JGit didn't defined it's own version of NonNull and NonNullByDefault. Change-Id: I7f6cbce9633e7552ee22ea6a9e7c1836c67a7ad4 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2015-09-21Use save action to add missing @Override annotations on saveMatthias Sohn1-3/+9
Change-Id: I3c55808a0279ac10a23be40739306259091037d8 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2015-06-23Enable NPE analysis in EGitAndrey Loskutov1-3/+6
Bug: 470641 Change-Id: Ib4d0ead90b30a2ce55c016aefd0927e41b9838cb Signed-off-by: Andrey Loskutov <loskutov@gmx.de> Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2015-02-10Set minimum required Java version to Java 7Matthias Sohn1-3/+3
Also update the installation instructions. Bug: 458476 Change-Id: I7a2b20bb7d5ec71d63feeb068078bc4a94fa2f24 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2013-01-07Use compiler settings from JGit (mostly)Robin Rosenberg3-27/+57
Change-Id: Id594dc712bf08d8b04e9340ab154b897b95d0819
2012-07-08Enforce the use of Java5 API:s only (with a few exceptions)Robin Rosenberg1-0/+94
This only works with Eclipse 3.6 and newer and requires installation of new package. Documentation is not very good, but there is a blog about it here: http://eclipseandjazz.blogspot.com/2011/10/of-invalid-references-to-system.html API checking is especially useful on OS X where Java5 is not readily available. Change-Id: I574e8c8b2e1b4cad2675b482268cdc98b35da38a
2012-07-03Don't treat optional problems like fatal errorsDani Megert1-2/+20
Change-Id: I21a0a988e32cf0876945e0cd511ed6bafc9c4740 Signed-off-by: Dani Megert <Daniel_Megert@ch.ibm.com>
2012-04-27Revert "Save Actions for removing braces of one-line statements"Robin Stocker1-4/+3
This reverts commit f95c105980fc8dc1c356665bb796f256d62bf1ca. The problem with the save action is that it also results in removed braces for the if in the following example: if (foo) try { bar(); } finally { baz(); } Which, altough it's a single statement, isn't recommended because it's longer than one line and confusing. See I1279030286ef177f3360ff70660a9365e4f3119a for the exact reasons. Change-Id: I4564e3d312fe3663d22ac784de83408509275219 Signed-off-by: Robin Stocker <robin@nibor.org>
2012-01-22Save Actions for removing braces of one-line statementsRobin Stocker1-3/+4
The EGit/JGit code style is to write the following: if (cond) { doSomething(); } as follows: if (cond) doSomething(); As this may need getting used to and as it comes up frequently in reviews, automate it by configuring it as a Java Editor Save Action on the projects. Change-Id: I9e998aa40f50bfa13a1d9887d267e0ecc9833ec9 Signed-off-by: Robin Stocker <robin@nibor.org>
2011-09-05Use commit message best practices for Mylyn Commit templateBenjamin Muskalla2-0/+7
We should use a template for Mylyn commit messages that matches with our guidelines for commit messages. http://wiki.eclipse.org/EGit/Contributor_Guide#Commit_message_guidelines Bug: 337401 Change-Id: I677134d6939b371a9f5a51e4e3b751da5e2bd547 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2011-01-21Add project level settingsChris Aniszczyk4-1/+408
Change-Id: Iebcb4b0703ed681c57b876334be5fd00027e880b Signed-off-by: Chris Aniszczyk <caniszczyk@gmail.com>
2011-01-17Add initial EGit Mylyn integrationChris Aniszczyk1-0/+8
Generates the commit dialog message by getting the active mylyn task. The commit message is generated by combinging the title with description and commit message template defined in the mylyn preferences. Bug: 306001 Change-Id: I344546626c8cb089c019db08afa400e4847e6fc4 Signed-off-by: Chris Aniszczyk <caniszczyk@gmail.com> Signed-off-by: Benjamin Muskalla <benjamin.muskalla@tasktop.com>

    Back to the top