Improve the patch wizard's text and image enhance its presentation

The wording of certain messages has been corrected and mnemonics
has been introduced to enhance accessibility. The wizard now also
uses the same title area image that the CVS plug-in uses.

Change-Id: Ia4777f18c5aec73983ceebb9ff12553cd24a2c20

4 files changed, 13 insertions, 8 deletions

diff --git a/org.eclipse.egit.ui/icons/wizban/createpatch_wizban.png b/org.eclipse.egit.ui/icons/wizban/createpatch_wizban.png
new file mode 100644
index 0000000000..d028e21fbb
--- /dev/null
+++ b/org.eclipse.egit.ui/icons/wizban/createpatch_wizban.png
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/UIIcons.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/UIIcons.java
index d005c107ce..1d44048ac5 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/UIIcons.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/UIIcons.java
@@ -76,6 +76,9 @@ public class UIIcons {
 	/** Disabled, unchecked, checkbox image */
 	public static final ImageDescriptor CHECKBOX_DISABLED_UNCHECKED;
 
+	/** Create Patch Wizard banner */
+	public static final ImageDescriptor WIZBAN_CREATE_PATCH;
+
 	/** Import Wizard banner */
 	public static final ImageDescriptor WIZBAN_IMPORT_REPO;
 
@@ -141,6 +144,7 @@ public class UIIcons {
 		ELCL16_COMPARE_VIEW = map("elcl16/compare_view.gif"); //$NON-NLS-1$
 		ELCL16_NEXT = map("elcl16/next.gif"); //$NON-NLS-1$
 		ELCL16_PREVIOUS = map("elcl16/previous.gif"); //$NON-NLS-1$
+		WIZBAN_CREATE_PATCH = map("wizban/createpatch_wizban.png"); //$NON-NLS-1$
 		WIZBAN_IMPORT_REPO = map("wizban/import_wiz.png"); //$NON-NLS-1$
 		WIZBAN_CONNECT_REPO = map("wizban/newconnect_wizban.png"); //$NON-NLS-1$
 		ELCL16_COMMIT = map("elcl16/commit.gif"); //$NON-NLS-1$
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java
index 85e8706795..45c5d86e14 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitCreatePatchWizard.java
@@ -30,6 +30,7 @@ import org.eclipse.core.runtime.IPath;
 import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.core.runtime.Path;
 import org.eclipse.egit.ui.Activator;
+import org.eclipse.egit.ui.UIIcons;
 import org.eclipse.egit.ui.UIText;
 import org.eclipse.jface.dialogs.IDialogConstants;
 import org.eclipse.jface.operation.IRunnableWithProgress;
@@ -116,13 +117,13 @@ public class GitCreatePatchWizard extends Wizard {
 		String pageTitle = UIText.GitCreatePatchWizard_SelectLocationTitle;
 		String pageDescription = UIText.GitCreatePatchWizard_SelectLocationDescription;
 
-		locationPage = new LocationPage(pageTitle, pageTitle, null);
+		locationPage = new LocationPage(pageTitle, pageTitle, UIIcons.WIZBAN_CREATE_PATCH);
 		locationPage.setDescription(pageDescription);
 		addPage(locationPage);
 
 		pageTitle = UIText.GitCreatePatchWizard_SelectOptionsTitle;
 		pageDescription = UIText.GitCreatePatchWizard_SelectOptionsDescription;
-		optionsPage = new OptionsPage(pageTitle, pageTitle, null);
+		optionsPage = new OptionsPage(pageTitle, pageTitle, UIIcons.WIZBAN_CREATE_PATCH);
 		optionsPage.setDescription(pageDescription);
 		addPage(optionsPage);
 	}
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties
index 232a28330a..904cb84fcd 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/uitext.properties
@@ -651,14 +651,14 @@ GitCreateGeneralProjectPage_FileExistsInDirMessage=A {0} file already exists in
 GitCreateGeneralProjectPage_FileNotDirMessage=File {0} is not a directory
 GitCreateGeneralProjectPage_PorjectAlreadyExistsMessage=Project {0} already exists
 GitCreateGeneralProjectPage_ProjectNameLabel=Project name
-GitCreatePatchWizard_Browse=Browse
-GitCreatePatchWizard_Clipboard=Clipboard
-GitCreatePatchWizard_CreatePatchTitle=Create patch
-GitCreatePatchWizard_File=File
+GitCreatePatchWizard_Browse=B&rowse...
+GitCreatePatchWizard_Clipboard=&Clipboard
+GitCreatePatchWizard_CreatePatchTitle=Create Patch
+GitCreatePatchWizard_File=Fil&e
 GitCreatePatchWizard_GitFormat=Export in git patch format
 GitCreatePatchWizard_InternalError=An internal error occurred.
-GitCreatePatchWizard_SelectLocationDescription=Select the location to store the patch
-GitCreatePatchWizard_SelectLocationTitle=Select location
+GitCreatePatchWizard_SelectLocationDescription=Select the location for the patch.
+GitCreatePatchWizard_SelectLocationTitle=Create a Patch
 GitCreatePatchWizard_SelectOptionsDescription=Select options for patch creation
 GitCreatePatchWizard_SelectOptionsTitle=Select options
 GitCreateProjectViaWizardWizard_AbortedMessage=Action was aborted