Remove help button (? icon) from dialogs

Most EGit dialogs showed a help button that was unusable, i.e. did not
link to correct documentation but only opened a generic help pane.
This patch removes the help buttons for all Classes extending
org.eclipse.jface.dialogs.TitleAreaDialog.

Change-Id: I7c6ba2721a117940c568d260640f599f26d4486c
Signed-off-by: Philipp Thun <philipp.thun@sap.com>

7 files changed, 9 insertions, 0 deletions

diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/AbstractBranchSelectionDialog.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/AbstractBranchSelectionDialog.java
index 93fb734e9d..26b79c9d40 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/AbstractBranchSelectionDialog.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/AbstractBranchSelectionDialog.java
@@ -90,6 +90,7 @@ public abstract class AbstractBranchSelectionDialog extends TitleAreaDialog {
 	public AbstractBranchSelectionDialog(Shell parentShell,
 			Repository repository) {
 		this(parentShell, repository, null);
+		setHelpAvailable(false);
 	}
 
 	/**
@@ -109,6 +110,7 @@ public abstract class AbstractBranchSelectionDialog extends TitleAreaDialog {
 		remoteBranches = new RemoteTrackingNode(null, this.repo);
 		tags = new TagsNode(null, this.repo);
 		this.refToMark = refToMark;
+		setHelpAvailable(false);
 	}
 
 	/**
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CreateTagDialog.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CreateTagDialog.java
index 387e6d84cd..af2e31e84a 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CreateTagDialog.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CreateTagDialog.java
@@ -162,6 +162,7 @@ public class CreateTagDialog extends TitleAreaDialog {
 		this.branchName = branchName;
 		this.commitId = null;
 		this.repo = repo;
+		setHelpAvailable(false);
 	}
 
 	/**
@@ -178,6 +179,7 @@ public class CreateTagDialog extends TitleAreaDialog {
 		this.branchName = null;
 		this.commitId = commitId;
 		this.repo = repo;
+		setHelpAvailable(false);
 	}
 
 	/**
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/GitTraceConfigurationDialog.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/GitTraceConfigurationDialog.java
index 03793af5ac..67a4009c32 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/GitTraceConfigurationDialog.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/GitTraceConfigurationDialog.java
@@ -222,6 +222,7 @@ public class GitTraceConfigurationDialog extends TitleAreaDialog {
 	 */
 	public GitTraceConfigurationDialog(Shell shell) {
 		super(shell);
+		setHelpAvailable(false);
 	}
 
 	@Override
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/preferences/AddConfigEntryDialog.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/preferences/AddConfigEntryDialog.java
index dcc40d3b01..f5a14c9bf4 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/preferences/AddConfigEntryDialog.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/preferences/AddConfigEntryDialog.java
@@ -56,6 +56,7 @@ public class AddConfigEntryDialog extends TitleAreaDialog {
 		setHelpAvailable(false);
 		currentConfig = config;
 		this.suggestedKey = suggestedKey;
+		setHelpAvailable(false);
 	}
 
 	@Override
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushResultDialog.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushResultDialog.java
index 738a1c9a33..f8f3e1e27c 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushResultDialog.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/push/PushResultDialog.java
@@ -35,6 +35,7 @@ class PushResultDialog extends TitleAreaDialog {
 		this.localDb = localDb;
 		this.result = result;
 		this.destinationString = destinationString;
+		setHelpAvailable(false);
 	}
 
 	@Override
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositoryPropertySource.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositoryPropertySource.java
index 8bab8f5850..69fb249a95 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositoryPropertySource.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/repository/RepositoryPropertySource.java
@@ -453,6 +453,7 @@ public class RepositoryPropertySource implements IPropertySource {
 			myConfig = config;
 			setShellStyle(getShellStyle() | SWT.SHELL_TRIM);
 			myTitle = title;
+			setHelpAvailable(false);
 		}
 
 		@Override
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/SelectSynchronizeResourceDialog.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/SelectSynchronizeResourceDialog.java
index 9ffa40f892..5bc307388e 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/SelectSynchronizeResourceDialog.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/synchronize/SelectSynchronizeResourceDialog.java
@@ -68,6 +68,7 @@ public class SelectSynchronizeResourceDialog extends TitleAreaDialog {
 		this.repoName = repoDirectory.getParentFile().getName()
 				+ File.separator + repoDirectory.getName();
 		this.syncRepos = syncRepos;
+		setHelpAvailable(false);
 	}
 
 	/**