Don't set shell as invisible before disposing

Just calling Shell.dispose is sufficient and should be
done when the graph table is disposed to prevent dangling
tooltips

Bug: 369647
Change-Id: I07edf7930ca9b88f914f0db8b48e025661b7ca89
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

1 files changed, 10 insertions, 10 deletions

diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitGraphTable.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitGraphTable.java
index 7bfc737924..79a3c02d2e 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitGraphTable.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/CommitGraphTable.java
@@ -213,11 +213,7 @@ class CommitGraphTable {
 			@Override
 			public void mouseHover(MouseEvent e) {
 				synchronized (this) {
-					if (hoverShell != null) {
-						hoverShell.setVisible(false);
-						hoverShell.dispose();
-						hoverShell = null;
-					}
+					disposeHover();
 
 					TableItem item = table.getTable().getItem(
 							new Point(e.x, e.y));
@@ -264,11 +260,7 @@ class CommitGraphTable {
 		table.getTable().addMouseMoveListener(new MouseMoveListener() {
 			public void mouseMove(MouseEvent e) {
 				synchronized (this) {
-					if (hoverShell == null || hoverShell.isDisposed())
-						return;
-					hoverShell.setVisible(false);
-					hoverShell.dispose();
-					hoverShell = null;
+					disposeHover();
 				}
 			}
 		});
@@ -280,6 +272,7 @@ class CommitGraphTable {
 					allCommits.dispose();
 				if (renderer != null)
 					renderer.dispose();
+				disposeHover();
 			}
 		});
 
@@ -353,6 +346,13 @@ class CommitGraphTable {
 				getTableView(), site, copy));
 	}
 
+	void disposeHover() {
+		if (hoverShell == null)
+			return;
+		hoverShell.dispose();
+		hoverShell = null;
+	}
+
 	Control getControl() {
 		return table.getControl();
 	}