Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Wolf2019-10-18 10:51:07 +0000
committerThomas Wolf2019-10-26 09:29:04 +0000
commit67a046c5e80a572f663a79fcb8c33098e75eb8d9 (patch)
treefb6ebd9763eb143f597bad62da074fb7ce39f1a3 /org.eclipse.egit.ui.test
parent236c33d2dabc3ff1314ec66f22a6755000de2842 (diff)
downloadegit-67a046c5e80a572f663a79fcb8c33098e75eb8d9.tar.gz
egit-67a046c5e80a572f663a79fcb8c33098e75eb8d9.tar.xz
egit-67a046c5e80a572f663a79fcb8c33098e75eb8d9.zip
[repo view] Link with selection: immediate reaction, show open editors
React immediately when linking with selection is enabled. Track workbench parts even when linking is disabled. When linking is enabled, immediately react on the last selection before the repositories view became active. When the selection inside the view changes react to a FileNode being selected by bringing an already open editor of that file to the front. Activate and correct the already existing test for this. Remove the old LinkHelper. It wasn't used anymore since commit d6cf5241 in 2013. Bug: 409722 Change-Id: I49ebc0b361469f3058348199ff8bd3557d949634 Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
Diffstat (limited to 'org.eclipse.egit.ui.test')
-rw-r--r--org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/view/repositories/GitRepositoriesViewTest.java9
1 files changed, 0 insertions, 9 deletions
diff --git a/org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/view/repositories/GitRepositoriesViewTest.java b/org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/view/repositories/GitRepositoriesViewTest.java
index 1a62755aed..c593fafe51 100644
--- a/org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/view/repositories/GitRepositoriesViewTest.java
+++ b/org.eclipse.egit.ui.test/src/org/eclipse/egit/ui/view/repositories/GitRepositoriesViewTest.java
@@ -67,7 +67,6 @@ import org.eclipse.ui.wizards.IWizardCategory;
import org.eclipse.ui.wizards.IWizardDescriptor;
import org.junit.After;
import org.junit.Before;
-import org.junit.Ignore;
import org.junit.Test;
import org.junit.runner.RunWith;
@@ -527,13 +526,6 @@ public class GitRepositoriesViewTest extends GitRepositoriesViewTestBase {
// activate the link with selection
toggleLinkWithSelection();
- // the selection should be still be root
- assertTrue(tree.selection().get(0, 0).contains(REPO1));
-
- // select again the project
- projectExplorerTree = TestUtil.getExplorerTree();
- getProjectItem(projectExplorerTree, PROJ1).select();
-
// the selection should be project
assertTrue(tree.selection().get(0, 0).equals(PROJ1));
}
@@ -544,7 +536,6 @@ public class GitRepositoriesViewTest extends GitRepositoriesViewTestBase {
* @throws Exception
*/
@Test
- @Ignore("'Link with Selection' does not activate editor on selection change (bug 409722).")
public void testLinkWithSelectionEditor() throws Exception {
deleteAllProjects();
shareProjects(repositoryFile);

Back to the top