Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Wolf2016-12-30 12:19:01 +0000
committerThomas Wolf2016-12-30 14:22:33 +0000
commit46bf6862dfe4e77ed8f036a35f5b803a5974c0ab (patch)
tree087c6dff3a5afd08f1e2ec197f5220033a63604a
parentdb29d255a5a3920b81f16a97dba158688cd4a0d0 (diff)
downloadegit-46bf6862dfe4e77ed8f036a35f5b803a5974c0ab.tar.gz
egit-46bf6862dfe4e77ed8f036a35f5b803a5974c0ab.tar.xz
egit-46bf6862dfe4e77ed8f036a35f5b803a5974c0ab.zip
[findbugs] Resolve ...SHOULD_BE_STATIC warnings
Change-Id: I7e788e5e94e829e84d8d6bb99bb82e5cbb5998f1 Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
-rw-r--r--org.eclipse.egit.core.test/src/org/eclipse/egit/core/internal/indexdiff/IndexDiffCacheEntryTest.java2
-rw-r--r--org.eclipse.egit.core.test/src/org/eclipse/egit/core/internal/merge/VariantsTestCase.java4
-rw-r--r--org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/revision/GitCompareFileRevisionEditorInput.java2
3 files changed, 4 insertions, 4 deletions
diff --git a/org.eclipse.egit.core.test/src/org/eclipse/egit/core/internal/indexdiff/IndexDiffCacheEntryTest.java b/org.eclipse.egit.core.test/src/org/eclipse/egit/core/internal/indexdiff/IndexDiffCacheEntryTest.java
index 9e239c9dc8..7e3cd298f2 100644
--- a/org.eclipse.egit.core.test/src/org/eclipse/egit/core/internal/indexdiff/IndexDiffCacheEntryTest.java
+++ b/org.eclipse.egit.core.test/src/org/eclipse/egit/core/internal/indexdiff/IndexDiffCacheEntryTest.java
@@ -243,7 +243,7 @@ public class IndexDiffCacheEntryTest extends GitTestCase {
super.tearDown();
}
- class IndexDiffCacheEntry2 extends IndexDiffCacheEntry {
+ private static class IndexDiffCacheEntry2 extends IndexDiffCacheEntry {
boolean reloadScheduled;
diff --git a/org.eclipse.egit.core.test/src/org/eclipse/egit/core/internal/merge/VariantsTestCase.java b/org.eclipse.egit.core.test/src/org/eclipse/egit/core/internal/merge/VariantsTestCase.java
index dfb545bb84..0aa62d3d21 100644
--- a/org.eclipse.egit.core.test/src/org/eclipse/egit/core/internal/merge/VariantsTestCase.java
+++ b/org.eclipse.egit.core.test/src/org/eclipse/egit/core/internal/merge/VariantsTestCase.java
@@ -31,9 +31,9 @@ import org.junit.After;
import org.junit.Before;
public abstract class VariantsTestCase extends GitTestCase {
- protected final String INITIAL_CONTENT_1 = "some content for the first file";
+ protected static final String INITIAL_CONTENT_1 = "some content for the first file";
- protected final String INITIAL_CONTENT_2 = "some content for the second file";
+ protected static final String INITIAL_CONTENT_2 = "some content for the second file";
protected static final String MASTER = Constants.R_HEADS + Constants.MASTER;
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/revision/GitCompareFileRevisionEditorInput.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/revision/GitCompareFileRevisionEditorInput.java
index bcde8d75b1..bef8d195b7 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/revision/GitCompareFileRevisionEditorInput.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/revision/GitCompareFileRevisionEditorInput.java
@@ -502,7 +502,7 @@ public class GitCompareFileRevisionEditorInput extends SaveableCompareEditorInpu
}
}
- private class OpenWorkspaceVersionAction extends Action {
+ private static class OpenWorkspaceVersionAction extends Action {
private final ISelectionProvider selectionProvider;

Back to the top