Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatthias Sohn2010-05-24 22:32:48 +0000
committerMatthias Sohn2010-05-24 22:32:48 +0000
commitb597b37eb3df451d292eb4dbe7be63e2db7cec04 (patch)
tree818fbf106db3571984f0d57ff342edec9acf5b8c
parent055dec2839120054cf2d09c280c141b751e8dee1 (diff)
downloadegit-b597b37eb3df451d292eb4dbe7be63e2db7cec04.tar.gz
egit-b597b37eb3df451d292eb4dbe7be63e2db7cec04.tar.xz
egit-b597b37eb3df451d292eb4dbe7be63e2db7cec04.zip
Improve layout of tagging dialog
Width of commit selection combo and consequently also the tagging dialog grew too large if there were commit messages with a long header line. Also commit selection combo didn't get enough vertical space when opened initially. Bug: 314053 Change-Id: Icd65e211968ed87acc3c0e936ac29239a994743a Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
-rw-r--r--org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CreateTagDialog.java6
1 files changed, 3 insertions, 3 deletions
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CreateTagDialog.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CreateTagDialog.java
index a2ffdf5360..dfed134111 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CreateTagDialog.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/CreateTagDialog.java
@@ -248,7 +248,7 @@ public class CreateTagDialog extends Dialog {
UIText.CreateTagDialog_questionNewTagTitle, branchName));
}
- newShell.setMinimumSize(703, 345);
+ newShell.setMinimumSize(600, 400);
}
@Override
@@ -335,7 +335,7 @@ public class CreateTagDialog extends Dialog {
GridData data = new GridData(GridData.GRAB_HORIZONTAL
| GridData.HORIZONTAL_ALIGN_FILL
| GridData.VERTICAL_ALIGN_CENTER);
- data.widthHint = convertHorizontalDLUsToPixels(IDialogConstants.MINIMUM_MESSAGE_AREA_WIDTH);
+ data.widthHint = convertHorizontalDLUsToPixels(IDialogConstants.MINIMUM_MESSAGE_AREA_WIDTH/2);
label.setLayoutData(data);
label.setFont(left.getFont());
@@ -428,7 +428,7 @@ public class CreateTagDialog extends Dialog {
commitCombo = new CommitCombo(advancedComposite, SWT.NORMAL);
commitCombo.setLayoutData(GridDataFactory.fillDefaults().grab(true,
- false).create());
+ false).hint(300, SWT.DEFAULT).create());
for (RevCommit revCommit : revCommits)
commitCombo.add(revCommit);

Back to the top