Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMathias Kinzler2010-05-31 15:52:42 +0000
committerMatthias Sohn2010-06-02 14:17:13 +0000
commit322122c5bfc6caeec9f473972f3e3f13e868cc8f (patch)
tree3ef97ba07035ac4c4a27b931a442252b3df863e6
parent17a39091e77b09d99f8cdfccb6e03dee613db177 (diff)
downloadegit-322122c5bfc6caeec9f473972f3e3f13e868cc8f.tar.gz
egit-322122c5bfc6caeec9f473972f3e3f13e868cc8f.tar.xz
egit-322122c5bfc6caeec9f473972f3e3f13e868cc8f.zip
Missing Push URI
A "Remote" configuration should be usable for "Push" even if only a "Fetch" URI has been configured. Bug: 314573 Change-Id: I97e2d4c5991320fb8817cf27778b64e1496943ef Signed-off-by: Mathias Kinzler <mathias.kinzler@sap.com>
-rw-r--r--org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/components/RepositorySelectionPage.java8
1 files changed, 6 insertions, 2 deletions
diff --git a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/components/RepositorySelectionPage.java b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/components/RepositorySelectionPage.java
index 694e55e85b..e080a5f10c 100644
--- a/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/components/RepositorySelectionPage.java
+++ b/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/components/RepositorySelectionPage.java
@@ -555,7 +555,8 @@ public class RepositorySelectionPage extends BaseWizardPage {
for (RemoteConfig config : remotes)
if ((sourceSelection && !config.getURIs().isEmpty() || !sourceSelection
- && !config.getPushURIs().isEmpty()))
+ && (!config.getPushURIs().isEmpty() || !config.getURIs()
+ .isEmpty())))
result.add(config);
if (!result.isEmpty())
@@ -581,8 +582,11 @@ public class RepositorySelectionPage extends BaseWizardPage {
if (sourceSelection) {
uris = rc.getURIs();
} else {
- // TODO shouldn't this be getPushURIs?
uris = rc.getPushURIs();
+ // if no push URIs are defined, use fetch URIs instead
+ if (uris.isEmpty()) {
+ uris = rc.getURIs();
+ }
}
for (final URIish u : uris) {

Back to the top