Skip to main content
summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2011-09-15EGit GitHub v1.1.0.201109151100-rv1.1.0.201109151100-rMatthias Sohn16-16/+16
Change-Id: Ied55195df9a871a1c64d3cc13dc2ebc2bb67520c Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2011-09-15Support pagination of user and organization repositories.Kevin Sawicki3-12/+458
Also add unit tests for RepositoryService class. Change-Id: I4b3bed05fdb00eef87193aa165f266d22fd543b6 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-13Create paged request with start and size parameters.Kevin Sawicki1-1/+1
Previously parameters were being ignored and the default paged request was being created for paging over pull requests. Change-Id: Id8008e9eda1e60303f9b780683c89ed72dd6418e Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-13Add mirror URL field to repository modelKevin Sawicki2-0/+20
Change-Id: I15c596b1a7316e7daa8a9d620ea1980371343f73 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-13Mark non-NLS strings, organize imports, and format.Kevin Sawicki16-142/+143
Non-functional change. Change-Id: I6976b6aa55fd8cc79777bb9370e4bad82e6a4397 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-13Correct inconsistent usage of IGitHubConstants fields.Kevin Sawicki2-5/+4
There were two occurrences where both static and non-static imports were being used for constants. Change-Id: Ib042e9c1af182d11e58fded4074d45191a795b5f Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-13Use helper method instead of explicit id checks.Kevin Sawicki1-6/+3
Remove code duplication from 3 methods that weren't using local helper method to verify Gist id is non-null and non-empty when used in a URI path. Change-Id: Ie8afd3827fd01eac492a0c46ef336860d2e14a09 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-13Guard against null issue operation value.Kevin Sawicki1-11/+4
This makes the operation checking more defensive in the case that task operations are modified or removed between versions and fail to resolve from task data. Change-Id: I408dc213a89790a540491af7d961385e4db479d0 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-12Merge "Guard against null pull request operation value." into stable-1.1Kevin Sawicki1-11/+4
2011-09-12Guard against null pull request operation value.Kevin Sawicki1-11/+4
Previously the attribute was checked for but not if the attribute operation value was non-null. Change-Id: I559e292633bcd50280a096caa5a7da6053a3df68 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-12Merge "Don't add task operations if pull request is merged." into stable-1.1Kevin Sawicki1-3/+7
2011-09-12Don't add task operations if pull request is merged.Kevin Sawicki1-3/+7
Merged pull requests cannot be reopened and so the task attribute operations should not be added when this condition is met. Change-Id: I7a99789a60089a3da3c5e1915a19a5d6f646f264 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-12Merge "Update to eclipse-signing-maven-plugin 1.0.3" into stable-1.1Matthias Sohn1-1/+1
2011-09-11Update exception message to place field name first.Kevin Sawicki4-15/+117
Also add unit tests of RequestException class. Change-Id: Iebc93b2bddc988919bc58f31b2a94322519a375d Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-11Update to eclipse-signing-maven-plugin 1.0.3Matthias Sohn1-1/+1
Bug: 356931 Change-Id: Ic765bcf4f0939c5d9181bb2ef92eaedb75134e21 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2011-09-11Add message for field error code of already_existsKevin Sawicki4-11/+29
Change-Id: I020f1e80aa36ee1dd5070d79fb8e58ad4640e3b4 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-11[findBugs] Don't pass null value to MessageFormat.formatKevin Sawicki3-8/+6
Change-Id: If3a873632e144a1718a3292ac24fccd50d41ab62 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-10Show dialog when opening commit fails due to missing repositoryKevin Sawicki5-31/+45
Change-Id: I16bbf217b22f82e252a5977a780219771c97058e Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-10Add more documentation to classes and methods.Kevin Sawicki7-8/+26
Non-functional change. Change-Id: I673a2d28c015568ebeadcb5d50e532037edff977 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-08Show dialog when pull request does not resolve to Git repository.Kevin Sawicki3-1/+31
This message prompts the user to add or clone the repository using the Git Repositories view. Change-Id: I69983133baa0f9280276e7ccacb5fc2e0ef3960c Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-08Merge branch 'master'Kevin Sawicki1-1/+1
* master Correct inconsistent parameter names. Use long for comment id instead of int. Add service support for editing pull request comments Add service support for editing and getting issue comments Add service support for editing and getting Gist comments Add service support for issue events API Add unit tests of download service Remove validation of pull request model inputs. Use origin remote if pull request is intra-repository Remove checkout, rebase, and merge actions from toolbar. Only allow collaborators or reporter to update pull requests Always allow reporter to edit issue. Use issue connector kind constant when adding repository Add more service package unit tests. Add unit tests of date formatter and paged request. Add more unit tests of UrlUtils class. Add missing unit tests for all model classes. Add unit tests of util package. Add more unit tests of label service and model classes. Add more unit tests of milestone service and model classes. Add more unit tests of issue service and model classes. Verify URIs of GET requests in unit tests. Change-Id: If87b116c073829a5f46c53faa0802da3355d8a2e Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-08Correct inconsistent parameter names.Kevin Sawicki3-19/+19
No functional change. Change-Id: I6f967a8a2131e5cd52393d5e2269308868cc1f0e Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-08Use long for comment id instead of int.Kevin Sawicki5-12/+12
Comments for gists, commits, issues, and pull requests share a common id namespace and so a larger id value should be expected and accepted. Change-Id: I18941514e076d4a591e68fb4b52811f16833e141 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-08Add service support for editing pull request commentsKevin Sawicki2-1/+47
Change-Id: Ic478522904b9fcb9670a0a37d2d4433b0841fc82 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-08Add service support for editing and getting issue commentsKevin Sawicki2-0/+81
Change-Id: Ie8f2aeaf84eda7eaceabfe147b008d1fae7938ca Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-08Add service support for editing and getting Gist commentsKevin Sawicki2-0/+68
Change-Id: I4bd21acb351e6175b4afcf97e36c28a543e5dacc Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-08Add service support for issue events APIKevin Sawicki7-12/+482
Change-Id: I373f013d575da87c73a59d3d7deef406f85f4c4e Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-08Prepare post v1.1.0.201109071825-rc3 buildsMatthias Sohn16-16/+16
Change-Id: I9c94d3bdb0f2feab4ecba6400bc28cff7e8b8d7f Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2011-09-08EGit GitHub v1.1.0.201109071825-rc3v1.1.0.201109071825-rc3Matthias Sohn16-16/+16
Change-Id: I8722915742c61ca10834a318f8c5540b258fcc9d Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2011-09-08Add unit tests of download serviceKevin Sawicki3-21/+171
Change-Id: I7ced6e73a333ccdf3b19bd32dc8c2d09f2c63512 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-08Remove validation of pull request model inputs.Kevin Sawicki2-42/+271
This makes the service consistent with issues where the only inputs verified as valid are URL segments, not model elements. Also adds remaining unit tests for the pull request service to properly verify these cases. Change-Id: I3ebc1d9691bdad2687cc319695d8e7e278841549 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-07Use origin remote if pull request is intra-repositoryKevin Sawicki1-4/+27
Change-Id: I1fc1185c2d41bef2d958d61bf89f04a939d01d14 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-07Remove checkout, rebase, and merge actions from toolbar.Kevin Sawicki1-4/+5
The workflow for these actions requires more refining than time permits for the 1.1 release. Change-Id: Ic3cd5290a2c41565504acb6b5abe91b0e2d455a5 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-07Only allow collaborators or reporter to update pull requestsKevin Sawicki1-18/+23
Change-Id: I72c059dc4834e6b066adac3ff761efb504d2513d Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-07Always allow reporter to edit issue.Kevin Sawicki2-1/+22
Change-Id: I8bc8d04405b1097ba1065e09d7b57b7c08bb283e Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-07Use issue connector kind constant when adding repositoryKevin Sawicki2-5/+4
Change-Id: I09b668660e5ca7a5e7b627edfcb2f480a827c9cf Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-07Add more service package unit tests.Kevin Sawicki18-80/+2663
Change-Id: I369a245088dadd6cd4bde51a66a6063802fa43d3 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-07Add unit tests of date formatter and paged request.Kevin Sawicki3-9/+97
Change-Id: I98e9c161272de828afde71150899450fa86d19a7 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-07Add more unit tests of UrlUtils class.Kevin Sawicki2-19/+50
Also be consistent with imports from IGitHubConstants in UrlUtils, other classes in github.core use static imports for constants from that interface. Change-Id: Ib6b18068513ce8d56c51b17070d57be3d88e4b01 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-07Add missing unit tests for all model classes.Kevin Sawicki36-263/+1982
Change-Id: I04f4c8d09ab85042bea00369af1de54b20392a50 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-07Add unit tests of util package.Kevin Sawicki7-7/+225
Also add missing unit tests to AllHeadlessTests suite. Change-Id: I1c689baad618d329277aeccbe813e98f8ed51fb4 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-07Add more unit tests of label service and model classes.Kevin Sawicki3-20/+220
Change-Id: I1119bad62368a30f224736c81709f234b5c4c2cd Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-07Add more unit tests of milestone service and model classes.Kevin Sawicki3-16/+287
Change-Id: I5e6864d71234a3d1e7e3f5054aff8ddd3e668b73 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-07Add more unit tests of issue service and model classes.Kevin Sawicki5-43/+394
Change-Id: If0cc1a034527d7a38f20468572a94baeb4379da0 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-07Verify URIs of GET requests in unit tests.Kevin Sawicki5-20/+73
Change-Id: I796d75d6d1a1d681d4ba2ba7dd7acb62b3f4a648 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-05Update Eclipse IP log for 1.1Matthias Sohn1-1/+1
Change-Id: I97a5478d589dc13631dc5d09d1d605b1bdf0af8a Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
2011-09-05Implement toString, hashCode, and equals in GitHubRequest.Kevin Sawicki1-5/+31
This allows unit tests to verify the request that was generated by creating a request with the expected full URI. Change-Id: I9cec3370240c23181763f3bcdccb0a781604703b Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-05Add more unit tests of Gist service and model classes.Kevin Sawicki7-9/+478
Change-Id: I38ae72b057a84d20e5fbd6c1fb2113c09fd41cb3 Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-05Overload put and post methods on GitHubClient.Kevin Sawicki1-6/+26
The new version take only a URI and is used for cases where no data is sent and the returned body is not needed. This follows the pattern previously added for delete calls. Change-Id: I3f68048f992a0cd60a957a5840f96673cc54d57b Signed-off-by: Kevin Sawicki <kevin@github.com>
2011-09-04Return empty collection when response body is null.Kevin Sawicki1-13/+17
Page iterator should always return non-null collections when pages still exist and the response is successful. Change-Id: I1f6e37dce286eff240d1ff3102defa5bf0c1544b Signed-off-by: Kevin Sawicki <kevin@github.com>

Back to the top