diff options
| author | Kevin Sawicki | 2011-04-07 22:45:13 +0000 |
|---|---|---|
| committer | Kevin Sawicki | 2011-04-07 22:45:13 +0000 |
| commit | 37149b81b93e8cbf89ccac42150acc1d0ba891cf (patch) | |
| tree | ed5a08531b14c5fc3ec020736a664e4c0d54a3d1 | |
| parent | 0cc416511934c71fb9c3e0ab7c6312d733ffc16c (diff) | |
| download | egit-github-37149b81b93e8cbf89ccac42150acc1d0ba891cf.tar.gz egit-github-37149b81b93e8cbf89ccac42150acc1d0ba891cf.tar.xz egit-github-37149b81b93e8cbf89ccac42150acc1d0ba891cf.zip | |
Close reader and use StringBuilder instead of StringBuffer.
Change-Id: I33506b4399918c4b4194b73ed6cb1f34a26b286f
Signed-off-by: Kevin Sawicki <kevin@github.com>
| -rw-r--r-- | org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/github/ui/internal/CreateGistHandler.java | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/github/ui/internal/CreateGistHandler.java b/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/github/ui/internal/CreateGistHandler.java index 0573d99a..6392809c 100644 --- a/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/github/ui/internal/CreateGistHandler.java +++ b/org.eclipse.mylyn.github.ui/src/org/eclipse/mylyn/github/ui/internal/CreateGistHandler.java @@ -73,10 +73,11 @@ public class CreateGistHandler extends AbstractHandler { } private void createGistJob(IFile file) { + BufferedReader br = null; try { - BufferedReader br = new BufferedReader(new InputStreamReader(file.getContents())); + br = new BufferedReader(new InputStreamReader(file.getContents())); String line; - StringBuffer result = new StringBuffer(); + StringBuilder result = new StringBuilder(); while ((line = br.readLine()) != null) { result.append(line); result.append('\n'); @@ -87,6 +88,13 @@ public class CreateGistHandler extends AbstractHandler { GitHubUi.logError(e); } catch (IOException e) { GitHubUi.logError(e); + } finally { + if (br != null) + try { + br.close(); + } catch (IOException e) { + GitHubUi.logError(e); + } } } |