Skip to main content
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKevin Sawicki2011-09-11 19:38:24 +0000
committerKevin Sawicki2011-09-11 19:38:24 +0000
commita850e9b287b7203d974f077eb2c2ecf7d5409f73 (patch)
tree0a2ff8e716dad611d7ac7691885163373f9c0b95 /org.eclipse.mylyn.github.core/src/org/eclipse
parent510d92a72550368c561fbd7d9869175a2fcad8c1 (diff)
downloadegit-github-a850e9b287b7203d974f077eb2c2ecf7d5409f73.tar.gz
egit-github-a850e9b287b7203d974f077eb2c2ecf7d5409f73.tar.xz
egit-github-a850e9b287b7203d974f077eb2c2ecf7d5409f73.zip
[findBugs] Don't pass null value to MessageFormat.format
Change-Id: If3a873632e144a1718a3292ac24fccd50d41ab62 Signed-off-by: Kevin Sawicki <kevin@github.com>
Diffstat (limited to 'org.eclipse.mylyn.github.core/src/org/eclipse')
-rw-r--r--org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/GitHubException.java10
-rw-r--r--org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/messages.properties2
2 files changed, 5 insertions, 7 deletions
diff --git a/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/GitHubException.java b/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/GitHubException.java
index c6bde874..e57a839c 100644
--- a/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/GitHubException.java
+++ b/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/GitHubException.java
@@ -23,15 +23,13 @@ import org.eclipse.egit.github.core.client.RequestException;
*/
public class GitHubException extends IOException {
- /**
- *
- */
+ /** serialVersionUID */
private static final long serialVersionUID = -1456910662911777231L;
/**
* Wraps the given {@link IOException} with a {@link GitHubException} if it
* is a {@link RequestException} instance.
- *
+ *
* @param exception
* @return wrapped exception
*/
@@ -42,7 +40,7 @@ public class GitHubException extends IOException {
/**
* Create GitHub exception from {@link RequestException}
- *
+ *
* @param cause
*/
public GitHubException(RequestException cause) {
@@ -77,7 +75,7 @@ public class GitHubException extends IOException {
value, field);
else
return MessageFormat.format(Messages.FieldError_InvalidField,
- field, value);
+ field);
else if (FieldError.CODE_MISSING_FIELD.equals(code))
return MessageFormat
.format(Messages.FieldError_MissingField, field);
diff --git a/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/messages.properties b/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/messages.properties
index 52d8a86a..afff5176 100644
--- a/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/messages.properties
+++ b/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/messages.properties
@@ -1,4 +1,4 @@
-FieldError_InvalidField=Invalid value for field {1}
+FieldError_InvalidField=Invalid value for field {0}
FieldError_InvalidFieldWithValue=Invalid value of {0} for field {1}
FieldError_MissingField=Missing required field {0}
FieldError_ResourceError=Error with field {0} in {1} resource

Back to the top