diff options
author | Aaron S. Hawley | 2019-06-21 10:22:55 +0000 |
---|---|---|
committer | Thomas Wolf | 2019-06-21 18:22:21 +0000 |
commit | 2565bf7ae358f156fcac7f5d007dc7cd4bf7e2d8 (patch) | |
tree | 21042aed79de03cda8abcf2a0b02d6513948beb0 /org.eclipse.egit.github.core.tests/src/org/eclipse | |
parent | 7a8c24d36f2214f6d7a97bb09249974d978188fe (diff) | |
download | egit-github-2565bf7ae358f156fcac7f5d007dc7cd4bf7e2d8.tar.gz egit-github-2565bf7ae358f156fcac7f5d007dc7cd4bf7e2d8.tar.xz egit-github-2565bf7ae358f156fcac7f5d007dc7cd4bf7e2d8.zip |
Change mergeable in PullRequest to Boolean
According to [1], mergeable field needs to be a null-able reference
type, and not a boolean primitive:
The value of the mergeable attribute can be true, false, or null.
If the value is null, then GitHub has started a background job to
compute the mergeability. After giving the job time to complete,
resubmit the request. When the job finishes, you will see a
non-null value for the mergeable attribute in the response.
[1] https://developer.github.com/v3/pulls/#response-1
Bug: 537774
Change-Id: I0cfb83933afb18386a2390138c738ce78d700a18
Signed-off-by: Aaron S. Hawley <aaron.s.hawley@gmail.com>
Diffstat (limited to 'org.eclipse.egit.github.core.tests/src/org/eclipse')
-rwxr-xr-x | org.eclipse.egit.github.core.tests/src/org/eclipse/egit/github/core/tests/PullRequestTest.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/org.eclipse.egit.github.core.tests/src/org/eclipse/egit/github/core/tests/PullRequestTest.java b/org.eclipse.egit.github.core.tests/src/org/eclipse/egit/github/core/tests/PullRequestTest.java index 6245e7c1..86c833b1 100755 --- a/org.eclipse.egit.github.core.tests/src/org/eclipse/egit/github/core/tests/PullRequestTest.java +++ b/org.eclipse.egit.github.core.tests/src/org/eclipse/egit/github/core/tests/PullRequestTest.java @@ -39,7 +39,7 @@ public class PullRequestTest { @Test
public void defaultState() {
PullRequest request = new PullRequest();
- assertFalse(request.isMergeable());
+ assertNull(request.isMergeable());
assertFalse(request.isMerged());
assertEquals(0, request.getAdditions());
assertNull(request.getBase());
|