Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStéphane Bégaudeau2017-03-09 08:57:28 +0000
committerStéphane Bégaudeau2017-04-19 09:07:18 +0000
commit991c16f04234c328f046b3367726ce37cac1c082 (patch)
tree64f816e3c12de12ba3179ffe422ceeb4c396e290
parent79dd2bc4413dc3d0de7b68319617b2d1e222d8bc (diff)
downloadorg.eclipse.eef-991c16f04234c328f046b3367726ce37cac1c082.tar.gz
org.eclipse.eef-991c16f04234c328f046b3367726ce37cac1c082.tar.xz
org.eclipse.eef-991c16f04234c328f046b3367726ce37cac1c082.zip
[refactoring] Fix a warning for an unused exception
Change-Id: I231f6627c5be3b2cef63b579ad530d19aa7763a6 Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
-rw-r--r--plugins/org.eclipse.eef.properties.ui/plugin.properties3
-rw-r--r--plugins/org.eclipse.eef.properties.ui/src/org/eclipse/eef/properties/ui/internal/Messages.java4
-rw-r--r--plugins/org.eclipse.eef.properties.ui/src/org/eclipse/eef/properties/ui/internal/extension/impl/EEFDescriptorRegistryEventListener.java9
3 files changed, 9 insertions, 7 deletions
diff --git a/plugins/org.eclipse.eef.properties.ui/plugin.properties b/plugins/org.eclipse.eef.properties.ui/plugin.properties
index 945b9d0d5..84c42f451 100644
--- a/plugins/org.eclipse.eef.properties.ui/plugin.properties
+++ b/plugins/org.eclipse.eef.properties.ui/plugin.properties
@@ -1,4 +1,4 @@
-# Copyright (c) 2015, 2016 Obeo.
+# Copyright (c) 2015, 2017 Obeo.
# All rights reserved. This program and the accompanying materials
# are made available under the terms of the Eclipse Public License v1.0
# which accompanies this distribution, and is available at
@@ -12,5 +12,6 @@ eefTabDescriptorFilterExtensionPoint.name = EEF Tab Descriptor Filter
DescriptorRegistryEventListener_missingAttribute=The attribute {1} is missing from the configuration element {0}.
DescriptorRegistryEventListener_extensionAlreadyContributed=The extension {0} has already been contributed.
+DescriptorRegistryEventListener_cannotInstantiateExtension=The extension {0} has not been successfully instantiated.
EEFTabbedPropertyRegistry_MissingSectionDescriptorId=The section descriptor does not have an identifier, it cannot be used. \ No newline at end of file
diff --git a/plugins/org.eclipse.eef.properties.ui/src/org/eclipse/eef/properties/ui/internal/Messages.java b/plugins/org.eclipse.eef.properties.ui/src/org/eclipse/eef/properties/ui/internal/Messages.java
index df704e0d3..2cf37f860 100644
--- a/plugins/org.eclipse.eef.properties.ui/src/org/eclipse/eef/properties/ui/internal/Messages.java
+++ b/plugins/org.eclipse.eef.properties.ui/src/org/eclipse/eef/properties/ui/internal/Messages.java
@@ -1,5 +1,5 @@
/*******************************************************************************
- * Copyright (c) 2015, 2016 Obeo.
+ * Copyright (c) 2015, 2017 Obeo.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0
* which accompanies this distribution, and is available at
@@ -25,6 +25,8 @@ public final class Messages {
public static String EEFTabbedPropertyRegistry_MissingSectionDescriptorId;
+ public static String DescriptorRegistryEventListener_cannotInstantiateExtension;
+
// CHECKSTYLE:ON
/**
diff --git a/plugins/org.eclipse.eef.properties.ui/src/org/eclipse/eef/properties/ui/internal/extension/impl/EEFDescriptorRegistryEventListener.java b/plugins/org.eclipse.eef.properties.ui/src/org/eclipse/eef/properties/ui/internal/extension/impl/EEFDescriptorRegistryEventListener.java
index 4ceff3cad..64db3238c 100644
--- a/plugins/org.eclipse.eef.properties.ui/src/org/eclipse/eef/properties/ui/internal/extension/impl/EEFDescriptorRegistryEventListener.java
+++ b/plugins/org.eclipse.eef.properties.ui/src/org/eclipse/eef/properties/ui/internal/extension/impl/EEFDescriptorRegistryEventListener.java
@@ -1,5 +1,5 @@
/*******************************************************************************
- * Copyright (c) 2015, 2016 Obeo.
+ * Copyright (c) 2015, 2017 Obeo.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0
* which accompanies this distribution, and is available at
@@ -136,10 +136,9 @@ public class EEFDescriptorRegistryEventListener<T> extends AbstractRegistryEvent
EEFTabbedPropertyViewPlugin.getPlugin().error(message);
}
} catch (CoreException e) {
- // String message =
- // MessageFormat.format(Messages.DescriptorRegistryEventListener_cannotInstantiateExtension,
- // configurationElement.getAttribute(IMPL_CLASS_DESCRIPTOR_ATTR));
- // EEFTabbedPropertyViewPlugin.getInstance().logError(message);
+ String message = MessageFormat.format(Messages.DescriptorRegistryEventListener_cannotInstantiateExtension,
+ configurationElement.getAttribute(IMPL_CLASS_DESCRIPTOR_ATTR));
+ EEFTabbedPropertyViewPlugin.getPlugin().error(message, e);
return false;
}

Back to the top