From 8f6cb46a980adeecc6e68e1fe8d772a4ebbdb860 Mon Sep 17 00:00:00 2001 From: slewis Date: Fri, 24 Jan 2014 14:11:34 -0800 Subject: Fix for bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=425868 Change-Id: I811b30c3fda2808c276d3998bd982d908713f305 --- .../org.eclipse.ecf.provider.filetransfer/META-INF/MANIFEST.MF | 2 +- .../filetransfer/retrieve/AbstractRetrieveFileTransfer.java | 10 ++++++++-- 2 files changed, 9 insertions(+), 3 deletions(-) (limited to 'providers') diff --git a/providers/bundles/org.eclipse.ecf.provider.filetransfer/META-INF/MANIFEST.MF b/providers/bundles/org.eclipse.ecf.provider.filetransfer/META-INF/MANIFEST.MF index b620e00bf..674f8f6d3 100644 --- a/providers/bundles/org.eclipse.ecf.provider.filetransfer/META-INF/MANIFEST.MF +++ b/providers/bundles/org.eclipse.ecf.provider.filetransfer/META-INF/MANIFEST.MF @@ -2,7 +2,7 @@ Manifest-Version: 1.0 Bundle-ManifestVersion: 2 Bundle-Name: %plugin.name Bundle-SymbolicName: org.eclipse.ecf.provider.filetransfer;singleton:=true -Bundle-Version: 3.2.0.qualifier +Bundle-Version: 3.2.100.qualifier Bundle-Activator: org.eclipse.ecf.internal.provider.filetransfer.Activator Bundle-Vendor: %plugin.provider Bundle-Localization: plugin diff --git a/providers/bundles/org.eclipse.ecf.provider.filetransfer/src/org/eclipse/ecf/provider/filetransfer/retrieve/AbstractRetrieveFileTransfer.java b/providers/bundles/org.eclipse.ecf.provider.filetransfer/src/org/eclipse/ecf/provider/filetransfer/retrieve/AbstractRetrieveFileTransfer.java index 3ecfd66f4..8ae247c2b 100644 --- a/providers/bundles/org.eclipse.ecf.provider.filetransfer/src/org/eclipse/ecf/provider/filetransfer/retrieve/AbstractRetrieveFileTransfer.java +++ b/providers/bundles/org.eclipse.ecf.provider.filetransfer/src/org/eclipse/ecf/provider/filetransfer/retrieve/AbstractRetrieveFileTransfer.java @@ -137,7 +137,7 @@ public abstract class AbstractRetrieveFileTransfer implements IIncomingFileTrans } protected InputStream wrapTransferReadInputStream(InputStream inputStream, IProgressMonitor monitor) { - return new PollingInputStream(remoteFileContents, getRetryAttempts(), monitor, readTimeoutMessage, closeTimeoutMessage); + return new PollingInputStream(inputStream, getRetryAttempts(), monitor, readTimeoutMessage, closeTimeoutMessage); } private int getRetryAttempts() { @@ -165,8 +165,14 @@ public abstract class AbstractRetrieveFileTransfer implements IIncomingFileTrans double factor = (totalWork > Integer.MAX_VALUE) ? (((double) Integer.MAX_VALUE) / ((double) totalWork)) : 1.0; int work = (totalWork > Integer.MAX_VALUE) ? Integer.MAX_VALUE : (int) totalWork; monitor.beginTask(getRemoteFileURL().toString() + Messages.AbstractRetrieveFileTransfer_Progress_Data, work); - InputStream readInputStream = wrapTransferReadInputStream(remoteFileContents, monitor); + InputStream readInputStream = null; try { + // We will test for remoteFileContents is null...if it is null then we can't continue. + // See bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=425868 + if (remoteFileContents == null) + throw new IOException("input stream cannot be null"); //$NON-NLS-1$ + // Create read input stream + readInputStream = wrapTransferReadInputStream(remoteFileContents, monitor); while (!isDone() && !isPaused()) { try { final int bytes = readInputStream.read(buf); -- cgit v1.2.3