From aa9b4b319c5b4e3367a23f6b6f0789ddeb92738c Mon Sep 17 00:00:00 2001 From: slewis Date: Wed, 26 Mar 2014 22:51:41 -0700 Subject: Reused AdapterManagerFactory Change-Id: I93698b040d124ece9d804ad3be921f138d3b41d6 --- .../eclipse/ecf/internal/provider/ProviderPlugin.java | 16 +++++----------- .../ecf/internal/provider/datashare/Activator.java | 13 ++++--------- 2 files changed, 9 insertions(+), 20 deletions(-) diff --git a/framework/bundles/org.eclipse.ecf.provider/src/org/eclipse/ecf/internal/provider/ProviderPlugin.java b/framework/bundles/org.eclipse.ecf.provider/src/org/eclipse/ecf/internal/provider/ProviderPlugin.java index 52099e772..0a388ee69 100644 --- a/framework/bundles/org.eclipse.ecf.provider/src/org/eclipse/ecf/internal/provider/ProviderPlugin.java +++ b/framework/bundles/org.eclipse.ecf.provider/src/org/eclipse/ecf/internal/provider/ProviderPlugin.java @@ -13,7 +13,8 @@ package org.eclipse.ecf.internal.provider; import javax.net.ssl.SSLServerSocketFactory; import javax.net.ssl.SSLSocketFactory; -import org.eclipse.core.runtime.*; +import org.eclipse.core.runtime.IAdapterManager; +import org.eclipse.core.runtime.IStatus; import org.eclipse.ecf.core.util.*; import org.osgi.framework.BundleActivator; import org.osgi.framework.BundleContext; @@ -36,7 +37,7 @@ public class ProviderPlugin implements BundleActivator { private ServiceTracker logServiceTracker = null; - private ServiceTracker adapterManagerTracker = null; + private AdapterManagerTracker adapterManagerTracker = null; private ServiceTracker sslServerSocketFactoryTracker; private ServiceTracker sslSocketFactoryTracker; @@ -46,17 +47,10 @@ public class ProviderPlugin implements BundleActivator { return null; // First, try to get the adapter manager via if (adapterManagerTracker == null) { - adapterManagerTracker = new ServiceTracker(this.context, IAdapterManager.class.getName(), null); + adapterManagerTracker = new AdapterManagerTracker(this.context); adapterManagerTracker.open(); } - IAdapterManager adapterManager = (IAdapterManager) adapterManagerTracker.getService(); - // Then, if the service isn't there, try to get from Platform class via - // PlatformHelper class - if (adapterManager == null) - adapterManager = PlatformHelper.getPlatformAdapterManager(); - if (adapterManager == null) - getDefault().log(new Status(IStatus.ERROR, PLUGIN_ID, IStatus.ERROR, "Cannot get adapter manager", null)); //$NON-NLS-1$ - return adapterManager; + return adapterManagerTracker.getAdapterManager(); } /** diff --git a/providers/bundles/org.eclipse.ecf.provider.datashare/src/org/eclipse/ecf/internal/provider/datashare/Activator.java b/providers/bundles/org.eclipse.ecf.provider.datashare/src/org/eclipse/ecf/internal/provider/datashare/Activator.java index 1c29ebfcf..e2bacf0c4 100644 --- a/providers/bundles/org.eclipse.ecf.provider.datashare/src/org/eclipse/ecf/internal/provider/datashare/Activator.java +++ b/providers/bundles/org.eclipse.ecf.provider.datashare/src/org/eclipse/ecf/internal/provider/datashare/Activator.java @@ -14,8 +14,8 @@ package org.eclipse.ecf.internal.provider.datashare; import org.eclipse.core.runtime.IAdapterManager; import org.eclipse.core.runtime.IStatus; import org.eclipse.ecf.core.IContainerManager; +import org.eclipse.ecf.core.util.AdapterManagerTracker; import org.eclipse.ecf.core.util.LogHelper; -import org.eclipse.ecf.core.util.PlatformHelper; import org.osgi.framework.BundleActivator; import org.osgi.framework.BundleContext; import org.osgi.service.log.LogService; @@ -35,7 +35,7 @@ public class Activator implements BundleActivator { private ServiceTracker logServiceTracker = null; - private ServiceTracker adapterManagerTracker = null; + private AdapterManagerTracker adapterManagerTracker = null; private ServiceTracker containerManagerTracker = null; @@ -103,15 +103,10 @@ public class Activator implements BundleActivator { public IAdapterManager getAdapterManager() { // First, try to get the adapter manager via if (adapterManagerTracker == null) { - adapterManagerTracker = new ServiceTracker(this.context, IAdapterManager.class.getName(), null); + adapterManagerTracker = new AdapterManagerTracker(this.context); adapterManagerTracker.open(); } - IAdapterManager adapterManager = (IAdapterManager) adapterManagerTracker.getService(); - // Then, if the service isn't there, try to get from Platform class via - // PlatformHelper class - if (adapterManager == null) - adapterManager = PlatformHelper.getPlatformAdapterManager(); - return adapterManager; + return adapterManagerTracker.getAdapterManager(); } /** -- cgit v1.2.3