Added IJoinContext interface for generalizing ISharedObjectContainer.joinGroup() parameters

2 files changed, 20 insertions, 2 deletions

diff --git a/framework/bundles/org.eclipse.ecf/src/org/eclipse/ecf/core/IJoinContext.java b/framework/bundles/org.eclipse.ecf/src/org/eclipse/ecf/core/IJoinContext.java
index 63c61b464..3b7c89ec6 100644
--- a/framework/bundles/org.eclipse.ecf/src/org/eclipse/ecf/core/IJoinContext.java
+++ b/framework/bundles/org.eclipse.ecf/src/org/eclipse/ecf/core/IJoinContext.java
@@ -12,6 +12,6 @@ package org.eclipse.ecf.core;
 import javax.security.auth.callback.CallbackHandler;
 
 public interface IJoinContext {
-	public Object [] getParameters();
+	public Object [] getRawParameters();
 	public CallbackHandler getCallbackHandler();
 }
diff --git a/framework/bundles/org.eclipse.ecf/src/org/eclipse/ecf/core/ISharedObjectContainer.java b/framework/bundles/org.eclipse.ecf/src/org/eclipse/ecf/core/ISharedObjectContainer.java
index d4f941a65..76ac7ccb7 100644
--- a/framework/bundles/org.eclipse.ecf/src/org/eclipse/ecf/core/ISharedObjectContainer.java
+++ b/framework/bundles/org.eclipse.ecf/src/org/eclipse/ecf/core/ISharedObjectContainer.java
@@ -72,7 +72,25 @@ public interface ISharedObjectContainer {
     public void joinGroup(ID groupID, Object loginData)
             throws SharedObjectContainerJoinException;
 	
-	// public void joinGroup(ID groupID, CallbackHandler handler) throws SharedObjectContainerJoinException;
+    /**
+     * Join a container group. The group to join is identified by the first
+     * parameter (groupID) using any required authentication provided via the
+     * second parameter (joinContext). This method provides an implementation
+     * independent way for container implementations to connect, authenticate,
+     * and communicate with a remote service or group of services. Providers are
+     * responsible for implementing this operation in a way appropriate to the
+     * given remote service and expected protocol.
+     * 
+     * @param groupID
+     *            the ID of the remote service to join
+     * @param joinContext
+     *            any required login/authentication context to allow this container
+     *            to authenticate
+     * @exception SharedObjectContainerJoinException
+     *                thrown if communication cannot be established with remote
+     *                service
+     */
+	//public void joinGroup(ID groupID, IJoinContext joinContext) throws SharedObjectContainerJoinException;
 	
     /**
      * Leave a container group. This operation will disconnect the local