From 3cf61d45b2081fb58975c506e598cf2445ec8d10 Mon Sep 17 00:00:00 2001 From: bvosburgh Date: Tue, 9 Sep 2008 16:52:41 +0000 Subject: reviewed new CachingTransformationPVMs - minor tweaks, comments --- .../value/CachingTransformationPropertyValueModelTests.java | 10 ++++++---- .../CachingTransformationWritablePropertyValueModelTests.java | 3 ++- 2 files changed, 8 insertions(+), 5 deletions(-) (limited to 'jpa/tests/org.eclipse.jpt.utility.tests/src/org/eclipse/jpt/utility/tests/internal/model') diff --git a/jpa/tests/org.eclipse.jpt.utility.tests/src/org/eclipse/jpt/utility/tests/internal/model/value/CachingTransformationPropertyValueModelTests.java b/jpa/tests/org.eclipse.jpt.utility.tests/src/org/eclipse/jpt/utility/tests/internal/model/value/CachingTransformationPropertyValueModelTests.java index fd6ff2ae34..62c56b993f 100644 --- a/jpa/tests/org.eclipse.jpt.utility.tests/src/org/eclipse/jpt/utility/tests/internal/model/value/CachingTransformationPropertyValueModelTests.java +++ b/jpa/tests/org.eclipse.jpt.utility.tests/src/org/eclipse/jpt/utility/tests/internal/model/value/CachingTransformationPropertyValueModelTests.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2007, 2008 Oracle. All rights reserved. + * Copyright (c) 2008 Oracle. All rights reserved. * This program and the accompanying materials are made available under the * terms of the Eclipse Public License v1.0, which accompanies this distribution * and is available at http://www.eclipse.org/legal/epl-v10.html. @@ -20,6 +20,7 @@ import org.eclipse.jpt.utility.model.value.PropertyValueModel; import org.eclipse.jpt.utility.model.value.WritablePropertyValueModel; import org.eclipse.jpt.utility.tests.internal.TestTools; +@SuppressWarnings("nls") public class CachingTransformationPropertyValueModelTests extends TestCase { private WritablePropertyValueModel objectHolder; PropertyChangeEvent event; @@ -58,7 +59,6 @@ public class CachingTransformationPropertyValueModelTests extends TestCase { public void testValue() { PropertyChangeListener listener = this.buildTransformationListener(); this.transformationObjectHolder.addPropertyChangeListener(listener); - Person person = this.objectHolder.getValue(); assertEquals("Karen", person.getName()); @@ -174,10 +174,10 @@ public class CachingTransformationPropertyValueModelTests extends TestCase { private class Person extends AbstractModel { private String name; - public static final String NAME_PROPERTY = "nameProperty"; + public static final String NAME_PROPERTY = "name"; private String parentName; - public static final String PARENT_NAME_PROPERTY = "parentNameProperty"; + public static final String PARENT_NAME_PROPERTY = "parentName"; private Person child; @@ -214,5 +214,7 @@ public class CachingTransformationPropertyValueModelTests extends TestCase { public Person getChild() { return this.child; } + } + } diff --git a/jpa/tests/org.eclipse.jpt.utility.tests/src/org/eclipse/jpt/utility/tests/internal/model/value/CachingTransformationWritablePropertyValueModelTests.java b/jpa/tests/org.eclipse.jpt.utility.tests/src/org/eclipse/jpt/utility/tests/internal/model/value/CachingTransformationWritablePropertyValueModelTests.java index 023c3134dd..72fd1288c3 100644 --- a/jpa/tests/org.eclipse.jpt.utility.tests/src/org/eclipse/jpt/utility/tests/internal/model/value/CachingTransformationWritablePropertyValueModelTests.java +++ b/jpa/tests/org.eclipse.jpt.utility.tests/src/org/eclipse/jpt/utility/tests/internal/model/value/CachingTransformationWritablePropertyValueModelTests.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2007, 2008 Oracle. All rights reserved. + * Copyright (c) 2008 Oracle. All rights reserved. * This program and the accompanying materials are made available under the * terms of the Eclipse Public License v1.0, which accompanies this distribution * and is available at http://www.eclipse.org/legal/epl-v10.html. @@ -21,6 +21,7 @@ import org.eclipse.jpt.utility.tests.internal.TestTools; import junit.framework.TestCase; +@SuppressWarnings("nls") public class CachingTransformationWritablePropertyValueModelTests extends TestCase { private WritablePropertyValueModel objectHolder; PropertyChangeEvent event; -- cgit v1.2.3