Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authornickboldt2017-12-05 19:11:03 +0000
committerNick Boldt2017-12-05 20:45:11 +0000
commitd8ce237847a85389eed06583c1f4f67b90fd63d0 (patch)
tree994af7224ca9cf0effcdc8bdb64731c98fe9f231 /common/tests/org.eclipse.jpt.common.utility.tests
parent583bf5313904e8d3e76417c6f944cef31f56ca17 (diff)
downloadwebtools.dali-d8ce237847a85389eed06583c1f4f67b90fd63d0.tar.gz
webtools.dali-d8ce237847a85389eed06583c1f4f67b90fd63d0.tar.xz
webtools.dali-d8ce237847a85389eed06583c1f4f67b90fd63d0.zip
comment out all the 'finished a bit too early' tests since the 'reasonable guess' is turning out to be unreasonable :(
Signed-off-by: nickboldt <nboldt@redhat.com>
Diffstat (limited to 'common/tests/org.eclipse.jpt.common.utility.tests')
-rw-r--r--common/tests/org.eclipse.jpt.common.utility.tests/src/org/eclipse/jpt/common/utility/tests/internal/reference/SynchronizedObjectTests.java16
1 files changed, 8 insertions, 8 deletions
diff --git a/common/tests/org.eclipse.jpt.common.utility.tests/src/org/eclipse/jpt/common/utility/tests/internal/reference/SynchronizedObjectTests.java b/common/tests/org.eclipse.jpt.common.utility.tests/src/org/eclipse/jpt/common/utility/tests/internal/reference/SynchronizedObjectTests.java
index 25ebdf01ec..1bbdc7c300 100644
--- a/common/tests/org.eclipse.jpt.common.utility.tests/src/org/eclipse/jpt/common/utility/tests/internal/reference/SynchronizedObjectTests.java
+++ b/common/tests/org.eclipse.jpt.common.utility.tests/src/org/eclipse/jpt/common/utility/tests/internal/reference/SynchronizedObjectTests.java
@@ -217,13 +217,13 @@ public class SynchronizedObjectTests
assertNull(this.so.getValue());
// make a reasonable guess about how long t2 took
long time = this.calculateElapsedTime();
- assertTrue("t2 finished a bit early (expected value should be > " + TICK + "): " + time, time > TICK);
+ //assertTrue("t2 finished a bit early (expected value should be > " + TICK + "): " + time, time > TICK);
}
/**
* t2 will wait indefinitely until t1 sets the value to null
*/
- public void testWaitUntilNul2l() throws Exception {
+ public void testWaitUntilNull2() throws Exception {
this.verifyWaitUntilNull(0); // 0 = indefinite wait
// no timeout occurs...
assertFalse(this.timeoutOccurred);
@@ -231,7 +231,7 @@ public class SynchronizedObjectTests
assertNull(this.so.getValue());
// make a reasonable guess about how long t2 took
long time = this.calculateElapsedTime();
- assertTrue("t2 finished a bit early (expected value should be > " + TICK + "): " + time, time > TICK);
+ //assertTrue("t2 finished a bit early (expected value should be > " + TICK + "): " + time, time > TICK);
}
/**
@@ -259,7 +259,7 @@ public class SynchronizedObjectTests
assertNull(this.so.getValue());
// make a reasonable guess about how long t2 took
long time = this.calculateElapsedTime();
- assertTrue("t2 finished a bit early (expected value should be >= " + TWO_TICKS + "): " + time, time >= TWO_TICKS);
+ //assertTrue("t2 finished a bit early (expected value should be >= " + TWO_TICKS + "): " + time, time >= TWO_TICKS);
}
private void verifyWaitUntilNull(long t2Timeout) throws Exception {
@@ -357,7 +357,7 @@ public class SynchronizedObjectTests
assertTrue(this.so.isNotNull());
// make a reasonable guess about how long t2 took
long time = this.calculateElapsedTime();
- assertTrue("t2 finished a bit early (expected value should be > " + TICK + "): " + time, time > TICK);
+ // assertTrue("t2 finished a bit early (expected value should be > " + TICK + "): " + time, time > TICK);
}
/**
@@ -372,7 +372,7 @@ public class SynchronizedObjectTests
assertTrue(this.so.isNotNull());
// make a reasonable guess about how long t2 took
long time = this.calculateElapsedTime();
- assertTrue("t2 finished a bit early (expected value should be > " + TICK + "): " + time, time > TICK);
+ // assertTrue("t2 finished a bit early (expected value should be > " + TICK + "): " + time, time > TICK);
}
/**
@@ -400,7 +400,7 @@ public class SynchronizedObjectTests
assertFalse(this.so.isNull());
// make a reasonable guess about how long t2 took
long time = this.calculateElapsedTime();
- assertTrue("t2 finished a bit early (expected value should be >= " + TWO_TICKS + "): " + time, time >= TWO_TICKS);
+ // assertTrue("t2 finished a bit early (expected value should be >= " + TWO_TICKS + "): " + time, time >= TWO_TICKS);
}
private void verifyWaitToSetValue(long t2Timeout) throws Exception {
@@ -443,7 +443,7 @@ public class SynchronizedObjectTests
assertEquals("foo", this.soValue);
// make a reasonable guess about how long t2 took
long time = this.calculateElapsedTime();
- assertTrue("t2 finished a bit early (expected value should be > " + TWO_TICKS + "): " + time, time > TWO_TICKS);
+ // assertTrue("t2 finished a bit early (expected value should be > " + TWO_TICKS + "): " + time, time > TWO_TICKS);
}
private void executeThreads(Command t1Command, Command t2Command) throws Exception {

Back to the top