1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
|
/*******************************************************************************
* Copyright (c) 2011, 2012 Patrick Hofer and others.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-v10.html
*
* Contributors:
* Patrick Hofer - Initial API and implementation
* Tomasz Wesolowski
* Sergey Prigogin (Google)
*******************************************************************************/
package org.eclipse.cdt.codan.core.internal.checkers;
import org.eclipse.cdt.codan.core.test.CheckerTestCase;
import org.eclipse.cdt.codan.internal.checkers.NonVirtualDestructor;
import org.eclipse.core.resources.IMarker;
/**
* Test for {@link NonVirtualDestructor} class.
*/
public class NonVirtualDestructorCheckerTest extends CheckerTestCase {
@Override
public boolean isCpp() {
return true;
}
@Override
public void setUp() throws Exception {
super.setUp();
enableProblems(NonVirtualDestructor.PROBLEM_ID);
}
// struct A {
// virtual void f() = 0;
// virtual ~A(); // ok.
// };
public void testVirtualDtorInClass() throws Exception {
loadCodeAndRun(getAboveComment());
checkNoErrors();
}
// struct A {
// virtual void f() = 0;
// protected:
// ~A(); // ok.
// };
public void testNonPublicVirtualDtorInClass() throws Exception {
loadCodeAndRun(getAboveComment());
checkNoErrors();
}
// struct A {
// virtual void f() { };
// ~A(); // warn! public non-virtual dtor.
// };
public void testPublicVirtualDtorInClass() throws Exception {
loadCodeAndRun(getAboveComment());
checkErrorLines(3);
}
// struct A {
// virtual void f() { };
// // warn! implicit public non-virtual dtor.
// };
public void testImplicitPublicNonVirtualDtorInClass() throws Exception {
loadCodeAndRun(getAboveComment());
checkErrorLines(1);
}
// struct F { };
//
// struct A {
// virtual void f() { };
// private:
// friend class F;
// ~A(); // warn! can be called from class F.
// };
public void testPublicNonVirtualDtorCanBeCalledFromFriendClass() throws Exception {
loadCodeAndRun(getAboveComment());
checkErrorLines(7);
}
// struct A {
// virtual void f() { };
// virtual ~A();
// };
//
// struct B {
// ~B(); // ok.
// };
public void testVirtualDtorInBaseClass1() throws Exception {
loadCodeAndRun(getAboveComment());
checkNoErrors();
}
// struct A {
// virtual void f() { };
// virtual ~A(); // ok.
// };
//
// struct B : public A { };
//
// struct C { };
//
// struct D : public B, C { };
//
// struct E : public D { };
public void testVirtualDtorInBaseClass2() throws Exception {
loadCodeAndRun(getAboveComment());
checkNoErrors();
}
// class A {
// public:
// virtual ~A();
// };
//
// class B : public A {
// public:
// ~B();
// virtual void m();
// friend class C;
// };
public void testVirtualDtorInBaseClass3() throws Exception {
loadCodeAndRun(getAboveComment());
checkNoErrors();
}
// struct A {
// virtual void f() { };
// ~A(); // warn! public non-virtual dtor.
// // this affects B, D and E further down in the hierarchy as well
// };
//
// struct B : public A { };
//
// struct C { };
//
// struct D : public B, C { };
//
// struct E : public D {
// };
public void testNonVirtualDtorInBaseClass() throws Exception {
loadCodeAndRun(getAboveComment());
checkErrorLines(3, 7, 11, 13);
}
// class A {
// virtual void f1() { };
// virtual void f2() = 0;
// };
//
// class B : public A {
// virtual void f1() { };
// virtual void f2() { };
// virtual ~B();
// };
public void testAbstractBaseClass() throws Exception {
loadCodeAndRun(getAboveComment());
// It doesn't matter if the class is abstract or not - dtor can be called polymorphically.
checkErrorLines(1);
}
// struct Base {
// };
// struct Derived : Base {
// virtual void bar();
// };
public void testImplicitDtorInBaseClass() throws Exception {
loadCodeAndRun(getAboveComment());
checkErrorLines(3);
}
// struct Base {
// ~Base();
// };
// struct Derived : Base {
// virtual void bar();
// };
public void testExplicitDtorInBaseClass() throws Exception {
loadCodeAndRun(getAboveComment());
checkErrorLines(4);
}
// class C : public C {};
public void testBug368446_stackOverflow() throws Exception {
loadCodeAndRun(getAboveComment());
checkNoErrors();
}
// class B;
// class A : public B {};
// class B : public A {};
public void testBug368446_stackOverflow_indirect() throws Exception {
loadCodeAndRun(getAboveComment());
checkNoErrors();
}
// class Foo {
// virtual void bar();
// };
public void testBug372009_wrongClassNameInMessage() throws Exception {
loadCodeAndRun(getAboveComment());
assertMessageContains("Foo", markers[0]);
}
// class Foo {
// virtual void bar();
// };
public void testBug496628_MarkerBounds() throws Exception {
String code = getAboveComment();
loadCodeAndRun(code);
IMarker marker = checkErrorLine(1);
int start = marker.getAttribute(IMarker.CHAR_START, -1);
int end = marker.getAttribute(IMarker.CHAR_END, -1);
// The error should not cover the entire class
assertTrue((start == -1 && end == -1) || // ok, not multi-line
!code.substring(start, end).contains("\n"));
}
}
|
