Skip to main content
AgeCommit message (Collapse)AuthorFilesLines
2018-11-24Bug 540373: Update the compiler warnings/ignoresJonah Graham1-1/+1
The previous alignment of all the warnings/ignores led to too many warnings that weren't there before. This commit relaxes them a bit. The core/org.eclipse.cdt.core/.settings/org.eclipse.jdt.core.prefs is still the "master" copy, with releng/scripts/ containing the exceptions that apply to test plug-ins. Change-Id: Ibd4e31ade0b42b31e7cbe5a94f06c6fc15183a56
2018-11-23Bug 540373: Cleanup: Remove trailing whitespace in properties filesJonah Graham2-4/+4
Command used: # Remove space at eol in comments find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/^(#.*)[ \t]+$/\1/' {} + # Remove space at eol in blank lines find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/^[ \t]+$//' {} + # Replace escaped spaces at eol with unicode find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/([^\\])\\ $/\1\\u0020/' {} + # Replace unescaped spaces at eol with unicode find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/([^\\]) $/\1\\u0020/' {} + # Replace escaped tabs at eol with unicode find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/([^\\])\\\t$/\1\\u0009/' {} + # Replace unescaped tabs at eol with unicode find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/([^\\])\t$/\1\\u0009/' {} + # Stage all changes git add -A . # trim any remaining whitespace and then identify and fixup # manually # Only dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/ui/viewmodel/ # needed this due to missing newline at end of the file find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/[ \t]+$//' {} + Change-Id: I858f16891fe001f4f7e62d5a4f904146e891cd39
2018-11-22Bug 540373: Cleanup: Organize ImportsJonah Graham1-0/+2
This was done by selecting all projects in Eclipse then Source -> Clean Up... -> choosing: - Organize Imports and completing the wizard Change-Id: Ia7b305a4c967d0e6f4e8fb8c1041e7028b24006c
2018-11-22Bug 540373: Cleanup: Format & Remove trailing whitespaceJonah Graham32-809/+721
This was done by selecting all projects in Eclipse then Source -> Clean Up... -> choosing: - Format source code - Remove trailing white spaces on all lines and completing the wizard Change-Id: I63685372c6bcc67719bcf145123bcb72e5b00394
2018-11-22Bug 540373: Standard .settings auto appliedJonah Graham5-25/+683
The releng/scripts/ was run to copy standard settings to all other projects. Change-Id: I4436c947d7f0142f56b709e661379c3eb54f666b
2018-11-22Bug 540371: Update to EPLv2 using releng/scripts/change_to_eplv2.shJonah Graham41-136/+264
Change-Id: Ifbb1d5af2a00bd5634dea200320e8c4303ffca6c
2018-11-20Bug 540373: Normalize newlines with .gitattributesJonah Graham1-100/+100
There is also a new script to verify completeness of .gitattributes: releng/scripts/ Change-Id: I2ce270852ab54b66b6c474a6ec94203fe5bba78b
2018-11-02Bug 540699 - NoClassDefFoundError in AutotoolsNewMakeGeneratorJeff Johnston1-1/+1
- use of CommandLaunchManager requires higher version of cdt.core than Autotools specified so up to 6.5.0 Change-Id: I315e69defeee9d7d1e6c016edff2d96013fe13e9
2018-10-30Bug 540610 - Add Automatic-Module-Name headerKarsten Thoms1-0/+1
Change-Id: Ia990b24469751050dd9ec8f9b5550804816308b3 Signed-off-by: Karsten Thoms <>
2018-10-23Bug 540367 - Increment version numbersWilliam Riley1-1/+1
Change-Id: I4a355170a7075f0a98ba3c1a5131c235c89b07d2
2018-01-31Bug 530478 - Relax AC_INIT macro validation in AutoconfEditorChin Huat Ang1-2/+3
When AutoconfEditor is set to 2.67 or newer, relax the validation of AC_INIT version string. Change-Id: I65221857905e867e3eea2de219ddf68c60f6d39b Signed-off-by: Chin Huat Ang <>
2018-01-11Bug 528169 - Run autotools commands within containersJeff Johnston1-6/+19
- add new optional build property to run all Autotool commands in Container - for Autotool nature projects only, add a checkbox to the ContainerPropertyTab to turn this new option on/off - change the AbstractAutotoolsHandler class to look at the optional build properties for the project to determine if the fallback CommandLauncher used to run commands should come from the CommandLauncherManager to run in Container or to a local CommandLauncher - change AutotoolsNewMakeGenerator the same way - add new messages as needed (add a tooltip to warn user that choosing new option may cause inconsistencies for files shared among configurations) Change-Id: Id828ec3015f32f320d2247bd0577944164c71df8
2018-01-03Bug 529386 - NoSuchMethodError in AutotoolsNewMakeGenerator.runScriptJeff Johnston1-1/+1
- bump up org.eclipse.cdt.remote.core so that autotools.core can refer to the latest version in its dependencies Change-Id: I4ec198d7c5d367a4a479a1dd39839f3c2d8c4a96
2017-11-02Bug 526730 - Autotools should not run autotool commands in the ContainerJeff Johnston1-43/+40
- modify runCommand and runScript methods in AutotoolsNewMakeGenerator class to take an ICommandLauncher to use - modify AutotoolsNewMakeGenerator regenerateMakefile method to pass a local CommandLauncher when running autotool commands, but using one from the CommandLauncherManager when running configure or config.status to do the configuration - modify RemoteCommandLauncher to add a constructor that includes the ICommandLauncher to use if the project is not remote - fix AbstractAutotoolsHandler to use local CommandLauncher Change-Id: Ib3f0deff3cca4b7b40459b5dd691d73dcbf2a87c Signed-off-by: Jeff Johnston <>
2017-10-22Bug 513589 - Add support to build CDT projects in a Docker ContainerJeff Johnston1-3/+3
- add IOptionalBuildObjectPropertiesContainer interface to use for objects that supply optional build properties - add new IOptionalBuildProperties interface that defines optional build properties donated by external plug-ins - add new - change IConfiguration to an IOptionalBuildObjectPropertiesContainer - change IManagedProject to be an IOptionalBuildObjectPropertiesContainer - fix ProcessClosure to ensure that readers are not null before accessing them - fix Container launch delegate to look at project optional build properties for active configuration to fetch connection and image info and use said info to find a matching launch or create a new one - have Container launch delegate use the image name as part of the launch config name - have Container launch short-cut also use the project's optional build properties for the active config to get connection and image information before any defaulting - change AutotoolsNewMarkerGenerator to store the command launcher as an ICommandLauncher - add new CommandLauncherFactory extension to cdt.core that allows plug-ins to specify a CommandLauncherFactory that will return an ICommandLauncher based on the project - add macros for new extension to CCorePlugin - add new CommandLauncherManager class that loads CommandLauncherFactory extensions and is used to give an ICommandLauncher wrapper that will go through the list of CommandLauncherFactory extensions until one returns non-null ICommandLauncher - add code to RemoteCommandLauncher so it will use the CommandLauncherManager to get the local launcher - also change RemoteCommandLauncher to check at execution time whether the command is local and in that case use the local command launcher - add new ICommandLauncherFactory interface - add new ContainerCommandLauncher to launch - add new ContainerCommandLauncherFactory class for returning a ContainerCommandLauncher instance to launch commands in a Docker Container - change MakeBuilder to use CommandLauncherManager to get its ICommandLauncher - change CommandBuilder to use CommandLauncherManager too - ditto for Builder and AbstractBuiltinSpecsDetector and ExternalToolInvoker - change Configuration to load/store optional build properties as well as return the properties to get/set - ditto for MultiConfiguration - change ManagedProject to implement IOptionalBuildOptionProperties interface - ditto for ProjectType - create new OptionalBuildProperties class to store optional build properties for a configuration - bump cdt.docker.launcher to 1.1.0 - use CommandLauncherFactory extension to define ContainerCommandLauncherFactory - add optional ContainerPropertyTab which allows the end-user to optionally choose to build a C/C++ project in a Container and specify the connection/image to use - in LanguageSettingsSerializableSettings class, call the CommandLauncherManager getLanguageSettingEntries method to get the massaged language setting entries based on the current list - in LanguageSettingsProviderSerializer, try and get the pooled entries using the cfg description so that it will have the project and can use the CommandLauncherManager to get entries from image - in ContainerCommandLauncherFactory move cached headers under a HEADERS directory in the plug-in area - create a sub-directory for the connection and a sub-directory for the image based on cleansed names - store the real names of the connection and image to use later in the DockerHeaderPreferencePage - modify LanguageSettingsEntriesTab to force the horizontal scroll bar to appear (this is a bug in SWT SashForm support and the fix here isn't quite correct, but is better) - add new DockerHeaderPreferencePage that allows user to remove cached headers from images - change C/C++ Docker preferences to be titled: Docker Container - fix LanguageSettingsWorkspaceProvider.getSettingEntries method to use the CommandLauncherManager so entries will be transformed to use cached headers - add BaseDatabindingModel class - add DataVolumeModel class to model a volume mount - add ContainerPropertyVolumes model to model volume specification and selected volumes - add properties to ContainerCommandLauncher to represent volumes and selected volumes for a configuration - add ContainerDataVolumeDialog for specifying a volume mount by the end-user - add a null detector for cfgDescription in LanguageSettingsSerializableProvider - fix AutotoolsNewMakeGenerator.getWinOSType to not specify "." for working dir - fix GCCBuiltinSpecsDetectorCygwin to not map paths to Cygwin if the current configuration is enabled for container build - add logic to ContainerCommandLauncher to look for Windows file formats and change them to unix format and map any "." working dir to be /tmp - fix ContainerLauncherConfigurationDelegate similarly - fix AbstractBuiltinSpecsDetector to pass in the current configuration description when getting the CommandLauncher since the current configuration may not be the active configuration - change ContainerPropertyTab to add Elf and GNU Elf binary parsers when build in Container is chosen so that output executables are treated as Binaries by the CDT project - add documentationl for the ContainerPropertyTab in Build Settings and the Data Volume dialog pop-up it brings up - change CommandBuilder to accept a project as an argument to its constructor and to pass this as an argument to the CommandLauncherManager - have StepBuilder pass project when creating a CommandBuilder Change-Id: Ia78488b93056e6ec7ca83a6c87b3a9d2b9424943
2017-02-14releng: Make use of Tycho POM-less functionalityMarc-Andre Laperle1-17/+0
This removes a lot of pom.xml from the source tree. This is using the "POM-less" Tycho functionality. See One advantage of this is that you do not need to update the version in the pom.xml when you change it in the MANIFEST.MF because the pom.xml is automatically generated. This also reduces a lot of the duplicated information and pom.xml repetition. - Maven 3.3 and up is required. - Only eclipse-plugins and eclipse-features can be pom-less. Repositories, target and others still have pom.xml. - New parent poms are added because a parent is necessary directly one level above the plug-in/feature that will have its pom generated - Some test plug-ins had to be renamed .test -> .tests because it's required so that it detects that it's a test plug-in - Some suites were renamed so that they all use the same consistent name "AutomatedIntegrationSuite" - Profiles were added for the more common test configurations. They are activated by the presence of simple .properties files that only serve to activate the correct profile. The profiles: - One for UI tests (UI present and start in UI thread) - One for SWTBot tests (UI present and do not start in UI thread) Other test plug-ins that are too different are kept intact and still have a pom.xml - Fragments are kept intact since they all have different target platform configurations Change-Id: I9d73380eb766f547830c552daf08053a30b1845c Signed-off-by: Marc-Andre Laperle <>
2016-11-16Update version to 9.3.0Marc Khouzam1-1/+1
Change-Id: Ic953ccc5d38ff3661ca44de21ed8c4b7dad5b246
2016-11-15Update version to 9.2.0Marc Khouzam1-1/+1
Change-Id: I36ad4218b20b8ea70584c89f5be45c757bf4c714
2016-08-17Update version to 9.1.0Marc Khouzam1-1/+1
This commit used the script releng/scripts/ Change-Id: I8274a6e8dd5c0f1e450f07952e138b265a441a62
2016-05-16Add a Debug configuration for Autotools projectsJeff Johnston4-11/+150
- set default CFLAGS and CXXFLAGS for debug configuration Autotool projects - pass project when creating a new AutotoolsConfiguration - add new Debug (GNU) configuration - add new build type property to Debug configuration - look for property when initializing AutotoolsConfiguration Change-Id: I95e6fa59f854dad3aff71507a4a85ffa55f4b2bc
2016-04-25Bug 492210 - Remove ChangeLog files from projectAlex Blewitt1-4416/+0
ChangeLog is an archaic format for identifying what has changed in a project. Fortunately more powerful version control systems are capable of generating this information and displaying information such as this paragraph in order to determine what has changed in a project and when. Change-Id: Ia71a05fa51869c1adb193d94f71c28b3b36beb37 Signed-off-by: Alex Blewitt <>
2016-04-25Bug 492304 - Fix NLS warningsAlex Blewitt13-125/+125
Eclipse warns if a String literal does not have a `//$NON-NLS-<n>$` entry at the end of the line. However, for historic or formatting reasons, many such occurrences in the CDT source have an intermediate whitespace, such as `// $NON-NLS-<n>$` Fix these so that the whitespace is removed between the // and $ characters. Change-Id: Idc12398fe6e9d619af1d0b1b73fb8b6180da223c Signed-off-by: Alex Blewitt <>
2016-04-25Bug 492230 - Replace buffer.append(a+b) callsAlex Blewitt2-7/+7
When using a `StringBuilder` or `StringBuffer` to create a string message, using implicit string concatenation inside an `.append()` call will create a nested StringBuilder for the purposes of creating the arguments, which will subsequently be converted to a String and then passed to the outer StringBuilder. Skip the creation of the intermediate object and String by simply replacing such calls with `buffer.append(a).append(b)`. Where values are compile time String constants, leave as is so that the javac compiler can perform compile-time String concatenation. Ensure that NEWLINE isn't appended in such a way since it is not a compile time constant `System.getProperty("line.separator")` Change-Id: I4126aefb2272f06b08332e004d7ea76b6f02cdba Signed-off-by: Alex Blewitt <>
2016-04-21Bug 492200 - Replace StringBuffer with StringBuilderAlex Blewitt4-10/+10
There are many opportunities for replacing `StringBuffer` with `StringBuilder` provided that the type isn't visible from the public API and is used only in internal methods. Replace these where appropriate. Change-Id: I769ceb6eaee18d183fb0e00fa0d730651f8a7edb Signed-off-by: Alex Blewitt <>
2016-04-19Bug 491984 - Replace .equals("") with .isEmpty()Alex Blewitt4-9/+9
In many cases a String's empty status is tested with `.equals("")`. However, Java 1.6 added `.isEmpty()` which can be more efficient since it compares the internal length parameter only for testing. Replace code using the `.isEmpty()` variant instead. Some tests for `"".equals(expr)` can be replaced with `expr.isEmpty()` where it is already known that the `expr` is not null; however, these have to be reviewed on a case-by-case basis. Change-Id: I3c6af4d8b7638e757435914ac76cb3a67899a5fd Signed-off-by: Alex Blewitt <>
2016-04-16Bug 491825 - Remove primitive wrapper creationAlex Blewitt1-3/+3
Using `new Integer` and other wrapper types such as `new Character` results in potential extra heap utilisation as the values are not cached. The built-in `Integer.valueOf` will perform caching on numbers in the range -128..127 (at least) using a flyweight pattern. In addition, parsing `int` values can be done with `Integer.parseInt` which avoids object construction. Adjust tests such as `"true".equals(expr)` to `Boolean.parseBoolean(expr)`. Change-Id: I0408a5c69afc4ca6ede71acaf6cc4abd67538006 Signed-off-by: Alex Blewitt <>
2016-04-15Bug 491825 - Remove uses of new Boolean and friendsSergey Prigogin1-3/+3
Change-Id: Ie358c8385c278472f3b86851f6fc219007bb9b5c
2016-04-15autotools; Use try-with-resources.Alexander Kurtakov1-18/+6
Change-Id: I424a07664a587ac65210dbe33b96e3f914a1c274 Signed-off-by: Alexander Kurtakov <>
2016-03-15Missing @since tagMarc Khouzam1-0/+3
Change-Id: I96a054aa3c8806bfa642184084a82e33d25bb0ae
2016-03-14Bug 467771 - add basis to support autotools option as NAME=VALUEWainer dos Santos Moschetta7-0/+99
It is not obvious in autotools preferences UI how to set variables like CC=/sbin/gcc Introduces the basis to allow extend the UI to include such as kind of variables. Change-Id: Ife0aada50d8c253f3fff39e7087f5fd54803ba48 Signed-off-by: Wainer dos Santos Moschetta <>
2016-02-01Missing copyright header.Marc Khouzam4-0/+28
Copyright assigned to company of the committer who did the first commit of the file. Change-Id: Ia133694018c798f9558258810982f5276737a0b0
2016-01-18Incremented CDT features version to 9.0.0Marc Khouzam1-1/+1
This includes bumping the standalone debugger to 9.0.0 Change-Id: I55fae1cec995b5f6865a5b174c004ed1b76e9bea
2016-01-04Fix copyright of all CDT plugins using the copyright tool from platform.Marc Khouzam31-31/+31
This commit does not add missing copyrights, just updates the date on the existing ones. Change-Id: I646f5afd533a1fcc539bdf2e0686b22f406ecf65
2015-12-18autotools: CosmeticsAlexander Kurtakov1-161/+153
Try-with-resources for ErrorParserManager. Change-Id: I5c36d3d68545cb50fcd416caefdc878212b57a88 Signed-off-by: Alexander Kurtakov <>
2015-12-18autotools: Creating default config doesn't need project.Alexander Kurtakov1-4/+4
AutotoolsConfigurationManager.createDefaultConfiguration doesn't need the project as parameter, that's why it's default one :). Change-Id: I55f39edf5867f874e38524042572329bc7e34f66 Signed-off-by: Alexander Kurtakov <>
2015-12-14autotools: Additional generification.Alexander Kurtakov3-48/+2
Properly generify now that o.e.text is generified. This alows removing a number of suppressed warnings. In a few places it is better to use wildcard than suppressing warnings. Also remove DefaultNoDependencyCalculator as it was suppressing warnings but better to remove directly as it's not use anywhere. Change-Id: I70c4ac073ce5b6c2a45443372037fa61b7c36c76 Signed-off-by: Alexander Kurtakov <>
2015-12-02autotools: Sanitize activators.Alexander Kurtakov2-114/+1
Reduce coupling by changing UI bundle to use UI activator and drop UI getters (e.g. workbench, window, shell) from the core bundle. Also remove other unused methods. Change-Id: Ida510d5a0e991c08332a998aefaba5843743172a Signed-off-by: Alexander Kurtakov <>
2015-12-01cosmetics: Autotools core bundle cleanups.Alexander Kurtakov5-27/+7
Various improvements: * Remove useless comments * Remove unused methods * Use String.isEmpty * Multi-catch Change-Id: I5d4e6ca5d4bcc925aad4db5c47f82d5d51d24522 Signed-off-by: Alexander Kurtakov <>
2015-11-26Bug 481971 - Detect cc compiler in the build output parserMarc-Andre Laperle1-1/+1
Change-Id: If667583eb3f720aa9ad7907af4673da8437d15d7 Signed-off-by: Marc-Andre Laperle <>
2015-11-12autotools: Change order of binary parsers.Alexander Kurtakov1-1/+1
Putting ELF before GNU_ELF by default means that the former will never be used (unless manually configured by user) as the first match will serve. This patch puts GNU_ELF first giving objdump and all other benefits. Inspired by 4303bc5cbb55e5b4e80c21fb51c1fe062294d79d . Change-Id: Ib37c174c216758f36cd0574c7980a38461794837 Signed-off-by: Alexander Kurtakov <>
2015-10-28autotools: Another round of core bundle cleanups.Alexander Kurtakov17-216/+200
* Use try-with-resources. * More efficient cycles. * Use collections interfaces instead of concrete classes. * Turn non-javadoc with actual comments into javadoc. * Adapt to proper Java naming conventions. * Modifiers order. * Unused modifiers. Change-Id: I5e4ca3e5f2900b72b53338a455dbaaa65273d812 Signed-off-by: Alexander Kurtakov <>
2015-10-27autotools: Remove redundant and unused modifiers.Alexander Kurtakov4-41/+67
Reducing sonar warnings is good strategy to keep new warnings easily noticable. Interface methods/fields have strict modifiers so no need to specify it. Change-Id: I8c453b5dbdc3c7fcc37e4e0a4fdf1c600e23fb1a Signed-off-by: Alexander Kurtakov <>
2015-10-27Allow autotools.ui to use autotools.coreMarc Khouzam1-3/+3
This change removes around 300 warnings Change-Id: I5704e99307e8d9117328a76e705a4ba25201be51
2015-10-20autotools: Migrate core bundle to SubMonitor.Alexander Kurtakov1-14/+11
Migrate org.eclipse.cdt.autotools.core from deprecated SubProgressMonitor to SubMonitor. Change-Id: Icad7c666fc88852554c5d7dbc70b4ecf26b9bc88 Signed-off-by: Alexander Kurtakov <>
2015-10-20autotools: Bump o.e.cdt.autotools.core BREE to 1.8.Alexander Kurtakov4-14/+11
Change-Id: I38ed3dfc834bcdbc77ebe0f2f11645d734c6ea0d Signed-off-by: Alexander Kurtakov <>
2015-10-19autotools: Fix API errors. Make internal packages actually internal.Marc-Andre Laperle4-5/+14
Change-Id: I014a7e778f247124239b7c6087b2f0107a11a7fc Signed-off-by: Marc-Andre Laperle <>
2015-10-16autotools: Modernize o.e.cdt.autotools.core. Alexander Kurtakov26-154/+324
* Enable warnings and save actions. * Replace useless @see comments with proper Override annotations. * Remove redundant type declarations. * Add missing Deprecated annotations. * Remove useless throws declarations. * Remove useless casts. * Remove useless method parameters. Change-Id: I632c1c811b5d01c80279fab30010cec7d285a971 Signed-off-by: Alexander Kurtakov <>
2015-06-10Incremented CDT feature version to 8.8.0Marc Khouzam1-1/+1
Change-Id: Ib1189a08a5f0225fd676b682dc8a10477ad3acc5 Signed-off-by: Marc Khouzam <>
2015-05-28Bug 468713 - CDT should explicitly require eclipse.remote 2.0.0Marc-Andre Laperle1-1/+1
Change-Id: Ifd0b8a54e93300f1970b887385ee01de1de2cfa3 Signed-off-by: Marc-Andre Laperle <>
2015-05-05Incremented CDT feature version to 8.7.0Marc Khouzam1-1/+1
Change-Id: Ife0feaaa9263d2b7797e31d628250bd26caff1b5 Signed-off-by: Marc Khouzam <>

Back to the top