Skip to main content
aboutsummaryrefslogtreecommitdiffstats
path: root/releng
diff options
context:
space:
mode:
authorJonah Graham2018-11-24 09:14:47 +0000
committerJonah Graham2018-11-24 10:55:06 +0000
commit37ed2c406d0a019c18b65ecd418addf7af808f1f (patch)
tree0cbfc2437ea68df675ae9af8ac678ff264770f4f /releng
parent1ca30675219c639ea9cdf713d686dbb862f00d29 (diff)
downloadorg.eclipse.cdt-37ed2c406d0a019c18b65ecd418addf7af808f1f.tar.gz
org.eclipse.cdt-37ed2c406d0a019c18b65ecd418addf7af808f1f.tar.xz
org.eclipse.cdt-37ed2c406d0a019c18b65ecd418addf7af808f1f.zip
Bug 540373: Update the compiler warnings/ignores
The previous alignment of all the warnings/ignores led to too many warnings that weren't there before. This commit relaxes them a bit. The core/org.eclipse.cdt.core/.settings/org.eclipse.jdt.core.prefs is still the "master" copy, with releng/scripts/check_code_cleanliness.sh containing the exceptions that apply to test plug-ins. Change-Id: Ibd4e31ade0b42b31e7cbe5a94f06c6fc15183a56
Diffstat (limited to 'releng')
-rw-r--r--releng/org.eclipse.cdt.repo/.settings/org.eclipse.jdt.core.prefs2
-rw-r--r--releng/org.eclipse.cdt.sdk/.settings/org.eclipse.jdt.core.prefs2
-rw-r--r--releng/org.eclipse.cdt.target/.settings/org.eclipse.jdt.core.prefs2
-rw-r--r--releng/org.eclipse.cdt.testing.repo/.settings/org.eclipse.jdt.core.prefs2
-rw-r--r--releng/org.eclipse.cdt.testing/.settings/org.eclipse.jdt.core.prefs2
-rw-r--r--releng/org.eclipse.cdt/.settings/org.eclipse.jdt.core.prefs2
-rwxr-xr-xreleng/scripts/check_code_cleanliness.sh23
7 files changed, 27 insertions, 8 deletions
diff --git a/releng/org.eclipse.cdt.repo/.settings/org.eclipse.jdt.core.prefs b/releng/org.eclipse.cdt.repo/.settings/org.eclipse.jdt.core.prefs
index b43f4a41768..2b6ecff8a01 100644
--- a/releng/org.eclipse.cdt.repo/.settings/org.eclipse.jdt.core.prefs
+++ b/releng/org.eclipse.cdt.repo/.settings/org.eclipse.jdt.core.prefs
@@ -62,7 +62,7 @@ org.eclipse.jdt.core.compiler.problem.includeNullInfoFromAsserts=disabled
org.eclipse.jdt.core.compiler.problem.incompatibleNonInheritedInterfaceMethod=warning
org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=warning
org.eclipse.jdt.core.compiler.problem.indirectStaticAccess=ignore
-org.eclipse.jdt.core.compiler.problem.invalidJavadoc=warning
+org.eclipse.jdt.core.compiler.problem.invalidJavadoc=ignore
org.eclipse.jdt.core.compiler.problem.invalidJavadocTags=enabled
org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsDeprecatedRef=disabled
org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsNotVisibleRef=enabled
diff --git a/releng/org.eclipse.cdt.sdk/.settings/org.eclipse.jdt.core.prefs b/releng/org.eclipse.cdt.sdk/.settings/org.eclipse.jdt.core.prefs
index b43f4a41768..2b6ecff8a01 100644
--- a/releng/org.eclipse.cdt.sdk/.settings/org.eclipse.jdt.core.prefs
+++ b/releng/org.eclipse.cdt.sdk/.settings/org.eclipse.jdt.core.prefs
@@ -62,7 +62,7 @@ org.eclipse.jdt.core.compiler.problem.includeNullInfoFromAsserts=disabled
org.eclipse.jdt.core.compiler.problem.incompatibleNonInheritedInterfaceMethod=warning
org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=warning
org.eclipse.jdt.core.compiler.problem.indirectStaticAccess=ignore
-org.eclipse.jdt.core.compiler.problem.invalidJavadoc=warning
+org.eclipse.jdt.core.compiler.problem.invalidJavadoc=ignore
org.eclipse.jdt.core.compiler.problem.invalidJavadocTags=enabled
org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsDeprecatedRef=disabled
org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsNotVisibleRef=enabled
diff --git a/releng/org.eclipse.cdt.target/.settings/org.eclipse.jdt.core.prefs b/releng/org.eclipse.cdt.target/.settings/org.eclipse.jdt.core.prefs
index b43f4a41768..2b6ecff8a01 100644
--- a/releng/org.eclipse.cdt.target/.settings/org.eclipse.jdt.core.prefs
+++ b/releng/org.eclipse.cdt.target/.settings/org.eclipse.jdt.core.prefs
@@ -62,7 +62,7 @@ org.eclipse.jdt.core.compiler.problem.includeNullInfoFromAsserts=disabled
org.eclipse.jdt.core.compiler.problem.incompatibleNonInheritedInterfaceMethod=warning
org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=warning
org.eclipse.jdt.core.compiler.problem.indirectStaticAccess=ignore
-org.eclipse.jdt.core.compiler.problem.invalidJavadoc=warning
+org.eclipse.jdt.core.compiler.problem.invalidJavadoc=ignore
org.eclipse.jdt.core.compiler.problem.invalidJavadocTags=enabled
org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsDeprecatedRef=disabled
org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsNotVisibleRef=enabled
diff --git a/releng/org.eclipse.cdt.testing.repo/.settings/org.eclipse.jdt.core.prefs b/releng/org.eclipse.cdt.testing.repo/.settings/org.eclipse.jdt.core.prefs
index b43f4a41768..2b6ecff8a01 100644
--- a/releng/org.eclipse.cdt.testing.repo/.settings/org.eclipse.jdt.core.prefs
+++ b/releng/org.eclipse.cdt.testing.repo/.settings/org.eclipse.jdt.core.prefs
@@ -62,7 +62,7 @@ org.eclipse.jdt.core.compiler.problem.includeNullInfoFromAsserts=disabled
org.eclipse.jdt.core.compiler.problem.incompatibleNonInheritedInterfaceMethod=warning
org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=warning
org.eclipse.jdt.core.compiler.problem.indirectStaticAccess=ignore
-org.eclipse.jdt.core.compiler.problem.invalidJavadoc=warning
+org.eclipse.jdt.core.compiler.problem.invalidJavadoc=ignore
org.eclipse.jdt.core.compiler.problem.invalidJavadocTags=enabled
org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsDeprecatedRef=disabled
org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsNotVisibleRef=enabled
diff --git a/releng/org.eclipse.cdt.testing/.settings/org.eclipse.jdt.core.prefs b/releng/org.eclipse.cdt.testing/.settings/org.eclipse.jdt.core.prefs
index b43f4a41768..2b6ecff8a01 100644
--- a/releng/org.eclipse.cdt.testing/.settings/org.eclipse.jdt.core.prefs
+++ b/releng/org.eclipse.cdt.testing/.settings/org.eclipse.jdt.core.prefs
@@ -62,7 +62,7 @@ org.eclipse.jdt.core.compiler.problem.includeNullInfoFromAsserts=disabled
org.eclipse.jdt.core.compiler.problem.incompatibleNonInheritedInterfaceMethod=warning
org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=warning
org.eclipse.jdt.core.compiler.problem.indirectStaticAccess=ignore
-org.eclipse.jdt.core.compiler.problem.invalidJavadoc=warning
+org.eclipse.jdt.core.compiler.problem.invalidJavadoc=ignore
org.eclipse.jdt.core.compiler.problem.invalidJavadocTags=enabled
org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsDeprecatedRef=disabled
org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsNotVisibleRef=enabled
diff --git a/releng/org.eclipse.cdt/.settings/org.eclipse.jdt.core.prefs b/releng/org.eclipse.cdt/.settings/org.eclipse.jdt.core.prefs
index b43f4a41768..2b6ecff8a01 100644
--- a/releng/org.eclipse.cdt/.settings/org.eclipse.jdt.core.prefs
+++ b/releng/org.eclipse.cdt/.settings/org.eclipse.jdt.core.prefs
@@ -62,7 +62,7 @@ org.eclipse.jdt.core.compiler.problem.includeNullInfoFromAsserts=disabled
org.eclipse.jdt.core.compiler.problem.incompatibleNonInheritedInterfaceMethod=warning
org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=warning
org.eclipse.jdt.core.compiler.problem.indirectStaticAccess=ignore
-org.eclipse.jdt.core.compiler.problem.invalidJavadoc=warning
+org.eclipse.jdt.core.compiler.problem.invalidJavadoc=ignore
org.eclipse.jdt.core.compiler.problem.invalidJavadocTags=enabled
org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsDeprecatedRef=disabled
org.eclipse.jdt.core.compiler.problem.invalidJavadocTagsNotVisibleRef=enabled
diff --git a/releng/scripts/check_code_cleanliness.sh b/releng/scripts/check_code_cleanliness.sh
index be8b9f04e03..29952c4f7e4 100755
--- a/releng/scripts/check_code_cleanliness.sh
+++ b/releng/scripts/check_code_cleanliness.sh
@@ -53,9 +53,28 @@ git ls-files -- \*\*/.project ':!core/org.eclipse.cdt.core/.project' | while re
if test ! -e $d/feature.xml; then
mkdir -p $d/.settings
cp core/org.eclipse.cdt.core/.settings/org.eclipse.jdt.* core/org.eclipse.cdt.core/.settings/org.eclipse.pde.* $d/.settings
- # For test plug-ins, don't warn on missing NLS
+ # For test plug-ins we are more lenient so don't warn on some items
if echo $i | grep '\.tests[/\.]' > /dev/null; then
- sed -i '-es@org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=warning@org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore@' $d/.settings/org.eclipse.jdt.core.prefs
+ sed -i \
+ '-es@org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=warning@org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore@' \
+ '-es@org.eclipse.jdt.core.compiler.problem.discouragedReference=warning@org.eclipse.jdt.core.compiler.problem.discouragedReference=ignore@' \
+ '-es@org.eclipse.jdt.core.compiler.problem.deprecation=warning@org.eclipse.jdt.core.compiler.problem.deprecation=ignore@' \
+ '-es@org.eclipse.jdt.core.compiler.problem.discouragedReference=warning@org.eclipse.jdt.core.compiler.problem.discouragedReference=ignore@' \
+ '-es@org.eclipse.jdt.core.compiler.problem.emptyStatement=warning@org.eclipse.jdt.core.compiler.problem.emptyStatement=ignore@' \
+ '-es@org.eclipse.jdt.core.compiler.problem.fieldHiding=warning@org.eclipse.jdt.core.compiler.problem.fieldHiding=ignore@' \
+ '-es@org.eclipse.jdt.core.compiler.problem.finalParameterBound=warning@org.eclipse.jdt.core.compiler.problem.finalParameterBound=ignore@' \
+ '-es@org.eclipse.jdt.core.compiler.problem.forbiddenReference=error@org.eclipse.jdt.core.compiler.problem.forbiddenReference=warning@' \
+ '-es@org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning@org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=ignore@' \
+ '-es@org.eclipse.jdt.core.compiler.problem.unusedLocal=warning@org.eclipse.jdt.core.compiler.problem.unusedLocal=ignore@' \
+ '-es@org.eclipse.jdt.core.compiler.problem.unusedPrivateMember=warning@org.eclipse.jdt.core.compiler.problem.unusedPrivateMember=ignore@' \
+ '-es@org.eclipse.jdt.core.compiler.problem.potentialNullReference=warning@org.eclipse.jdt.core.compiler.problem.potentialNullReference=ignore@' \
+ '-es@org.eclipse.jdt.core.compiler.problem.rawTypeReference=warning@org.eclipse.jdt.core.compiler.problem.rawTypeReference=ignore@' \
+ '-es@org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=warning@org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=ignore@' \
+ $d/.settings/org.eclipse.jdt.core.prefs
+ sed -i \
+ '-es@compilers.p.not-externalized-att=1@compilers.p.not-externalized-att=2@' \
+ $d/.settings/org.eclipse.pde.prefs
+
fi
fi
done

Back to the top