Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlvaro Sanchez-Leon2016-12-09 14:49:46 +0000
committerAlvaro Sanchez-Leon2017-01-23 14:03:59 +0000
commit377f0cc81501b2098cd8105089c641c1dcb60f32 (patch)
treec1b1670ec94251c63dbf8e61bc9cb553e16118f8 /memory/org.eclipse.cdt.debug.ui.memory.floatingpoint
parent0169f0a907995b31bd0d7de8d13bcffbdad65377 (diff)
downloadorg.eclipse.cdt-377f0cc81501b2098cd8105089c641c1dcb60f32.tar.gz
org.eclipse.cdt-377f0cc81501b2098cd8105089c641c1dcb60f32.tar.xz
org.eclipse.cdt-377f0cc81501b2098cd8105089c641c1dcb60f32.zip
Bug 508446 - [memory] Preferences dialog empty tree on the left
This apply to the Floating Point and Traditional Renderings, When calling these preferences from the drop down inside the memory view, the associated preferences dialog comes up with the left side empty, this left side shall reflect the preference page three path. The call to the preference dialog has been replaced to use PreferenceUtil.createPreferenceDialogOn which takes care of this. Change-Id: I89d6b1289a7eac5ffcca54a1ca6d8b3c3ed831df
Diffstat (limited to 'memory/org.eclipse.cdt.debug.ui.memory.floatingpoint')
-rw-r--r--memory/org.eclipse.cdt.debug.ui.memory.floatingpoint/src/org/eclipse/cdt/debug/ui/memory/floatingpoint/FPRenderingPreferenceAction.java16
1 files changed, 2 insertions, 14 deletions
diff --git a/memory/org.eclipse.cdt.debug.ui.memory.floatingpoint/src/org/eclipse/cdt/debug/ui/memory/floatingpoint/FPRenderingPreferenceAction.java b/memory/org.eclipse.cdt.debug.ui.memory.floatingpoint/src/org/eclipse/cdt/debug/ui/memory/floatingpoint/FPRenderingPreferenceAction.java
index ac158b1e6d9..e7fe2cb69e0 100644
--- a/memory/org.eclipse.cdt.debug.ui.memory.floatingpoint/src/org/eclipse/cdt/debug/ui/memory/floatingpoint/FPRenderingPreferenceAction.java
+++ b/memory/org.eclipse.cdt.debug.ui.memory.floatingpoint/src/org/eclipse/cdt/debug/ui/memory/floatingpoint/FPRenderingPreferenceAction.java
@@ -13,16 +13,12 @@
package org.eclipse.cdt.debug.ui.memory.floatingpoint;
import org.eclipse.jface.action.IAction;
-import org.eclipse.jface.preference.IPreferenceNode;
import org.eclipse.jface.preference.IPreferencePage;
-import org.eclipse.jface.preference.PreferenceDialog;
-import org.eclipse.jface.preference.PreferenceManager;
-import org.eclipse.jface.preference.PreferenceNode;
-import org.eclipse.jface.window.Window;
import org.eclipse.swt.custom.BusyIndicator;
import org.eclipse.ui.IViewActionDelegate;
import org.eclipse.ui.IViewPart;
import org.eclipse.ui.actions.ActionDelegate;
+import org.eclipse.ui.dialogs.PreferencesUtil;
public class FPRenderingPreferenceAction extends ActionDelegate implements IViewActionDelegate
{
@@ -51,20 +47,12 @@ public class FPRenderingPreferenceAction extends ActionDelegate implements IView
protected void showPreferencePage(String id, IPreferencePage page)
{
- final IPreferenceNode targetNode = new PreferenceNode(id, page);
-
- PreferenceManager manager = new PreferenceManager();
- manager.addToRoot(targetNode);
- final PreferenceDialog dialog = new PreferenceDialog(FPRenderingPlugin.getShell(), manager);
- final boolean[] result = new boolean[] { false };
BusyIndicator.showWhile(FPRenderingPlugin.getStandardDisplay(), new Runnable()
{
@Override
public void run()
{
- dialog.create();
- dialog.setMessage(targetNode.getLabelText());
- result[0] = (dialog.open() == Window.OK);
+ PreferencesUtil.createPreferenceDialogOn(FPRenderingPlugin.getShell(), id, new String[] { id }, null).open();
}
});
}

Back to the top