diff options
| author | Alex Blewitt | 2016-04-21 22:35:17 +0000 |
|---|---|---|
| committer | Sergey Prigogin | 2016-04-22 03:17:03 +0000 |
| commit | 2356a29c7015ad41cfe8630568a1c3ab5c3c5eb3 (patch) | |
| tree | 834bab2dc4a5287047b0ee87c96903bb9d4f20e2 /llvm | |
| parent | e901d4a7d4298b999365288b6b5b8d018b75ae73 (diff) | |
| download | org.eclipse.cdt-2356a29c7015ad41cfe8630568a1c3ab5c3c5eb3.tar.gz org.eclipse.cdt-2356a29c7015ad41cfe8630568a1c3ab5c3c5eb3.tar.xz org.eclipse.cdt-2356a29c7015ad41cfe8630568a1c3ab5c3c5eb3.zip | |
Bug 492200 - Replace StringBuffer with StringBuilder
There are many opportunities for replacing `StringBuffer` with
`StringBuilder` provided that the type isn't visible from the
public API and is used only in internal methods. Replace these
where appropriate.
Change-Id: Ic2f50c5b6f3c3a4eae301bb3b40fb6faed235f79
Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
Diffstat (limited to 'llvm')
3 files changed, 8 insertions, 8 deletions
diff --git a/llvm/org.eclipse.cdt.managedbuilder.llvm.ui/src/org/eclipse/cdt/managedbuilder/llvm/ui/LlvmEnvironmentVariableSupplier.java b/llvm/org.eclipse.cdt.managedbuilder.llvm.ui/src/org/eclipse/cdt/managedbuilder/llvm/ui/LlvmEnvironmentVariableSupplier.java index 25fb9f08ec4..64e92c6ebfc 100755 --- a/llvm/org.eclipse.cdt.managedbuilder.llvm.ui/src/org/eclipse/cdt/managedbuilder/llvm/ui/LlvmEnvironmentVariableSupplier.java +++ b/llvm/org.eclipse.cdt.managedbuilder.llvm.ui/src/org/eclipse/cdt/managedbuilder/llvm/ui/LlvmEnvironmentVariableSupplier.java @@ -1,5 +1,5 @@ /*******************************************************************************
- * Copyright (c) 2010, 2015 Nokia Siemens Networks Oyj, Finland.
+ * Copyright (c) 2010, 2016 Nokia Siemens Networks Oyj, Finland.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0
* which accompanies this distribution, and is available at
@@ -381,7 +381,7 @@ public class LlvmEnvironmentVariableSupplier implements IConfigurationEnvironmen if (oldPath!=null) {
//if the oldPath isn't empty
if (!oldPath.trim().isEmpty()) {
- StringBuffer sB = new StringBuffer();
+ StringBuilder sB = new StringBuilder();
// append old path
sB.append(oldPath);
// append a path separator
diff --git a/llvm/org.eclipse.cdt.managedbuilder.llvm.ui/src/org/eclipse/cdt/managedbuilder/llvm/ui/preferences/LlvmPreferenceStore.java b/llvm/org.eclipse.cdt.managedbuilder.llvm.ui/src/org/eclipse/cdt/managedbuilder/llvm/ui/preferences/LlvmPreferenceStore.java index fe6842ab545..1f2622106fa 100755 --- a/llvm/org.eclipse.cdt.managedbuilder.llvm.ui/src/org/eclipse/cdt/managedbuilder/llvm/ui/preferences/LlvmPreferenceStore.java +++ b/llvm/org.eclipse.cdt.managedbuilder.llvm.ui/src/org/eclipse/cdt/managedbuilder/llvm/ui/preferences/LlvmPreferenceStore.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2010-2013 Nokia Siemens Networks Oyj, Finland. + * Copyright (c) 2010, 2016 Nokia Siemens Networks Oyj, Finland. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Eclipse Public License v1.0 * which accompanies this distribution, and is available at @@ -165,7 +165,7 @@ public class LlvmPreferenceStore { * @param value the string-valued preference */ public static void appendValue(String name, String value) { - StringBuffer sB = new StringBuffer(); + StringBuilder sB = new StringBuilder(); String paths = null; //get existing paths paths = getExistingPaths(name); @@ -233,7 +233,7 @@ public class LlvmPreferenceStore { * @param value Value to remove from the preference store */ public static void removeValue(String name, String value) { - StringBuffer sB = new StringBuffer(); + StringBuilder sB = new StringBuilder(); String existingValues = null; String newValue = null; //get existing values @@ -250,7 +250,7 @@ public class LlvmPreferenceStore { exValArray = LlvmToolOptionPathUtil.removePathFromExistingPathList(exValArray, value); //if the array isn't empty if (exValArray.length > 0) { - //append all values to the StringBuffer excluding the removed one + //append all values to the StringBuilder excluding the removed one for (String val : exValArray) { //append a value sB.append(val); diff --git a/llvm/org.eclipse.cdt.managedbuilder.llvm.ui/src/org/eclipse/cdt/managedbuilder/llvm/util/LlvmToolOptionPathUtil.java b/llvm/org.eclipse.cdt.managedbuilder.llvm.ui/src/org/eclipse/cdt/managedbuilder/llvm/util/LlvmToolOptionPathUtil.java index 362614cc156..c888af63a2b 100755 --- a/llvm/org.eclipse.cdt.managedbuilder.llvm.ui/src/org/eclipse/cdt/managedbuilder/llvm/util/LlvmToolOptionPathUtil.java +++ b/llvm/org.eclipse.cdt.managedbuilder.llvm.ui/src/org/eclipse/cdt/managedbuilder/llvm/util/LlvmToolOptionPathUtil.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2010-2016 Nokia Siemens Networks Oyj, Finland. + * Copyright (c) 2010, 2016 Nokia Siemens Networks Oyj, Finland. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Eclipse Public License v1.0 * which accompanies this distribution, and is available at @@ -831,7 +831,7 @@ public class LlvmToolOptionPathUtil { * a String array separated by a path separator. */ public static String arrayToString(String[] array) { - StringBuffer sB = new StringBuffer(); + StringBuilder sB = new StringBuilder(); //if array isn't empty and doesn't contain an empty String if (array.length>0 /*&& !array[0].isEmpty()*/) { for (String i : array) { |