Skip to main content
aboutsummaryrefslogtreecommitdiffstats
path: root/dsf
diff options
context:
space:
mode:
authorJonah Graham2018-06-13 08:39:01 +0000
committerJonah Graham2018-06-13 15:15:09 +0000
commitac2363cb925ceaa477699497c2f252d72f47f45d (patch)
treec2f4fc02ebbbd0d137126280f4303611fa963b67 /dsf
parent231ec3e5403c88aa45b79e7001762e5c83bde04f (diff)
downloadorg.eclipse.cdt-ac2363cb925ceaa477699497c2f252d72f47f45d.tar.gz
org.eclipse.cdt-ac2363cb925ceaa477699497c2f252d72f47f45d.tar.xz
org.eclipse.cdt-ac2363cb925ceaa477699497c2f252d72f47f45d.zip
Bug 535836: Log instead of pop-up errors in disassembly view
All sorts of views, variables, memory, etc can do a DSF operation that causes an error. But for some reason only the disassembly view generally displays this error to the user in a pop-up. This change converts the pop-up (which says things like "Target not available" or "Failed to execute MI command: -var-create - * symbol_that_user_typed_that_doesnt_exist Error message from debugger back end: -var-create: unable to create variable object") to just log the error instead. Errors are dealt with in the UI already (example, bad location in text box in toolbar gets an exclamation next to it). However, I don't know if there are some errors that really do need to be displayed to the user with a pop-up. Change-Id: I27b398c34e558db98d34cef773a2689fa9222149
Diffstat (limited to 'dsf')
-rw-r--r--dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/DisassemblyBackendDsf.java7
1 files changed, 6 insertions, 1 deletions
diff --git a/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/DisassemblyBackendDsf.java b/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/DisassemblyBackendDsf.java
index 6b5dd4ff4e7..df33422e44f 100644
--- a/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/DisassemblyBackendDsf.java
+++ b/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/DisassemblyBackendDsf.java
@@ -1327,4 +1327,9 @@ public class DisassemblyBackendDsf extends AbstractDisassemblyBackend implements
protected IExecutionDMContext getExecutionDMContext() {
return fTargetContext;
}
-} \ No newline at end of file
+
+ @Override
+ protected void handleError(IStatus status) {
+ DsfUIPlugin.log(status);
+ }
+}

Back to the top