[304434] ISourceLookupParticipant.getSourceName(Object) should return null, not empty string

1 files changed, 6 insertions, 1 deletions

diff --git a/dsf/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/debug/sourcelookup/DsfSourceLookupParticipant.java b/dsf/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/debug/sourcelookup/DsfSourceLookupParticipant.java
index 722d467b394..bdf571366b3 100644
--- a/dsf/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/debug/sourcelookup/DsfSourceLookupParticipant.java
+++ b/dsf/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/debug/sourcelookup/DsfSourceLookupParticipant.java
@@ -193,7 +193,12 @@ public class DsfSourceLookupParticipant implements ISourceLookupParticipant {
             }};
             fExecutor.execute(query);
             try {
-                return query.get();
+                String result = query.get();
+                if ((result != null) && (result.length() == 0)) {
+                	// interface javadoc says we should return null 
+                	result = null; 
+                }
+                return result;
             } catch (InterruptedException e) { assert false : "Interrupted exception in DSF executor";  //$NON-NLS-1$
             } catch (ExecutionException e) { 
                 if (e.getCause() instanceof CoreException) {