diff options
author | Marc Dumais | 2016-08-05 13:09:41 +0000 |
---|---|---|
committer | Gerrit Code Review @ Eclipse.org | 2016-11-04 14:58:29 +0000 |
commit | 735b1ab48853d1e8bd5dcee102c6343588c00cd4 (patch) | |
tree | a7b0c3a3cf7744f868ad5489fa4c4694daf2df86 /dsf-gdb/org.eclipse.cdt.dsf.gdb | |
parent | c7526e8a04a421fcd051d9c4b99a114060e3dd08 (diff) | |
download | org.eclipse.cdt-735b1ab48853d1e8bd5dcee102c6343588c00cd4.tar.gz org.eclipse.cdt-735b1ab48853d1e8bd5dcee102c6343588c00cd4.tar.xz org.eclipse.cdt-735b1ab48853d1e8bd5dcee102c6343588c00cd4.zip |
Bug 499230 - Duplicated "-thread-select" and "-stack-select-frame"
Most GDB MI commands support the "--thread" and "--frame" options, that
tells GDB on which thread/stack frame the command is meant to act-on.
For those that don't, CDT has a mechanism to first have GDB switch
thread (MIThreadSelect) or frame (MIStackSelectFrame), before issuing
the command that will act on that entity. Ironically, those two commands
are wrongly identified as not supporting those parameters, and so are
sometimes sent in duplicate, when a single command including the thread
or frame would be possible. This commit correctly identifies those
commands as supporting the thread/frame parameter.
Change-Id: I6e7fc4e873abe36ad024c7131efda7c0aa89dc44
Diffstat (limited to 'dsf-gdb/org.eclipse.cdt.dsf.gdb')
2 files changed, 0 insertions, 10 deletions
diff --git a/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/MIStackSelectFrame.java b/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/MIStackSelectFrame.java index 2303559e5c7..1e4d474c165 100644 --- a/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/MIStackSelectFrame.java +++ b/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/MIStackSelectFrame.java @@ -28,9 +28,4 @@ public class MIStackSelectFrame extends MICommand<MIInfo> { public MIStackSelectFrame(IDMContext ctx, int frameNum) { super(ctx, "-stack-select-frame", new String[]{Integer.toString(frameNum)}); //$NON-NLS-1$ } - - @Override - public boolean supportsThreadAndFrameOptions() { - return false; - } } diff --git a/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/MIThreadSelect.java b/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/MIThreadSelect.java index 181b797c0e2..c954399075b 100644 --- a/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/MIThreadSelect.java +++ b/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/MIThreadSelect.java @@ -37,9 +37,4 @@ public class MIThreadSelect extends MICommand<MIInfo> public MIThreadSelect(IDMContext ctx, String threadNum) { super(ctx, "-thread-select", new String[]{threadNum}); //$NON-NLS-1$ } - - @Override - public boolean supportsThreadAndFrameOptions() { - return false; - } } |