Skip to main content
aboutsummaryrefslogtreecommitdiffstats
path: root/cross
diff options
context:
space:
mode:
authorMarc-Andre Laperle2021-06-20 04:03:44 +0000
committerMarc-Andre Laperle2021-06-20 04:38:08 +0000
commit987d11ef428699dc68bc5b89d5c54960a2ec41a2 (patch)
tree874411c5acdfb2aae205fdf7be6e5d5d8639de59 /cross
parent90b3ebc1df54d2b76b038b405bb59f9a0ac7017d (diff)
downloadorg.eclipse.cdt-master.tar.gz
org.eclipse.cdt-master.tar.xz
org.eclipse.cdt-master.zip
Bug 574333 - Per-project Doxygen options are not flushed until saved a second timeHEADmaster
When the options are applied in performApply, the call DocCommentOwnerManager.setCommentOwner causes to set the CProjectDescription, which causes UserDefinedEnvironmentSupplier to flush cdt.core preferences. Then DocCommentOwnerArea.apply populates the preference storage, but the preferences are not flushed after that therefore the new options values only exist in memory. Swapping the calls of DocCommentOwnerManager.setCommentOwner and DocCommentOwnerArea.apply works but it makes no sense for the flushing of Documentation options to depend on UserDefinedEnvironmentSupplier flushing the preferences - it would work by a lucky accident. A clean option would be to go through the preference's page IWorkingCopyManager but this would involve a lot of more risky changes in the DocOwner/Doxygen code and a vast majority of CDT code does not do that. Instead, this change explicitly calls CCoreInternals.savePreferences which flushes the preferences, just like Indexer options does. Change-Id: Id9a57cde47794f57f26ae295ec01eeb1df9aa120 Signed-off-by: Marc-Andre Laperle <malaperle@gmail.com>
Diffstat (limited to 'cross')
0 files changed, 0 insertions, 0 deletions

Back to the top