Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJonah Graham2022-01-14 17:19:46 +0000
committerJonah Graham2022-01-14 17:58:33 +0000
commita7746e4e9ef25140f9029fdf6e1ac5d2dbb28369 (patch)
tree45b2ed2ca3b70611e570c48ea33d9cd779eb8120 /core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal
parent51f7c4b4e4ed6c2e2a4ec8f83dcc25243595a227 (diff)
downloadorg.eclipse.cdt-a7746e4e9ef25140f9029fdf6e1ac5d2dbb28369.tar.gz
org.eclipse.cdt-a7746e4e9ef25140f9029fdf6e1ac5d2dbb28369.tar.xz
org.eclipse.cdt-a7746e4e9ef25140f9029fdf6e1ac5d2dbb28369.zip
Bug 578219: Make the FileDialog in Copy Build Log a Save dialog
Prior to this it was SWT.NONE which is now being interpreted as an Open dialog which means an existing file must be selected. In some conditions the SWT.NONE would allow a new file to be entered that didn't exist already, so this did not affect everyone. With this change a normal Save dialog is presented, and the OS confirm overwrite is enabled. Change-Id: Iea8c4211f8d9fe0c2f4d423780d91a62f6d3edab
Diffstat (limited to 'core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal')
-rw-r--r--core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/buildconsole/CopyBuildLogAction.java3
1 files changed, 2 insertions, 1 deletions
diff --git a/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/buildconsole/CopyBuildLogAction.java b/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/buildconsole/CopyBuildLogAction.java
index a66c17f9695..e576db8b085 100644
--- a/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/buildconsole/CopyBuildLogAction.java
+++ b/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/buildconsole/CopyBuildLogAction.java
@@ -80,7 +80,8 @@ public class CopyBuildLogAction extends Action {
}
// open file dialog
- FileDialog dialog = new FileDialog(shell, SWT.NONE);
+ FileDialog dialog = new FileDialog(shell, SWT.SAVE);
+ dialog.setOverwrite(true);
dialog.setText(ConsoleMessages.CopyLog_ChooseDestination);
String destLocation = dialog.open();

Back to the top