Skip to main content
path: root/codan
diff options
authorAlex Blewitt2016-04-19 10:35:21 +0000
committerGerrit Code Review @ Eclipse.org2016-04-19 17:35:54 +0000
commit2114f6b108763ff027fe0936e1f7b4d7e9cc655c (patch)
treeafd55872d8d3dae5de15300ef63cc6acffdc6e92 /codan
parent10ba077124e266fb7cfa661241d044a3ee91e0d3 (diff)
Bug 491984 - Replace .equals("") with .isEmpty()
In many cases a String's empty status is tested with `.equals("")`. However, Java 1.6 added `.isEmpty()` which can be more efficient since it compares the internal length parameter only for testing. Replace code using the `.isEmpty()` variant instead. Some tests for `"".equals(expr)` can be replaced with `expr.isEmpty()` where it is already known that the `expr` is not null; however, these have to be reviewed on a case-by-case basis. Change-Id: I3c6af4d8b7638e757435914ac76cb3a67899a5fd Signed-off-by: Alex Blewitt <>
Diffstat (limited to 'codan')
1 files changed, 2 insertions, 2 deletions
diff --git a/codan/org.eclipse.cdt.codan.ui.cfgview/src/org/eclipse/cdt/codan/ui/cfgview/views/ b/codan/org.eclipse.cdt.codan.ui.cfgview/src/org/eclipse/cdt/codan/ui/cfgview/views/
index eb6f492f0c..11d393da2c 100644
--- a/codan/org.eclipse.cdt.codan.ui.cfgview/src/org/eclipse/cdt/codan/ui/cfgview/views/
+++ b/codan/org.eclipse.cdt.codan.ui.cfgview/src/org/eclipse/cdt/codan/ui/cfgview/views/
@@ -1,5 +1,5 @@
- * Copyright (c) 2010 QNX Software Systems and others.
+ * Copyright (c) 2010, 2016 QNX Software Systems and others.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0
* which accompanies this distribution, and is available at
@@ -355,7 +355,7 @@ public class ControlFlowGraphView extends ViewPart {
protected boolean open(String filename) throws PartInitException, CModelException {
- if (filename.equals(""))
+ if (filename.isEmpty())
return false;
IResource r = ParserUtil.getResourceForFilename(filename);
if (r != null) {

Back to the top