Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndrew Eidsness2014-01-28 12:38:30 +0000
committerDoug Schaefer2014-01-30 16:30:01 +0000
commitc3733d0473c9504467759f300f264fb4c0936dea (patch)
tree9f4bac2247df25e7421f09b9c86bde90c5a0ebb7
parent69e866058d4fc5186bdd90b4955498d8cf855403 (diff)
downloadorg.eclipse.cdt-c3733d0473c9504467759f300f264fb4c0936dea.tar.gz
org.eclipse.cdt-c3733d0473c9504467759f300f264fb4c0936dea.tar.xz
org.eclipse.cdt-c3733d0473c9504467759f300f264fb4c0936dea.zip
Bug 426784: Qt Codan checker uses wrong type
view.connect( view.engine(), SIGNAL( quit() ), ... The return type of view.engine() should be checked for the quit() signal. The implementation was actually checking the type of view. I've fixed a copy/paste error in a utility function. Change-Id: Id483015214f04951fb30e3271d43499f31614446 Signed-off-by: Andrew Eidsness <eclipse@jfront.com> Reviewed-on: https://git.eclipse.org/r/21189 Reviewed-by: Doug Schaefer <dschaefer@qnx.com> IP-Clean: Doug Schaefer <dschaefer@qnx.com> Tested-by: Doug Schaefer <dschaefer@qnx.com>
-rw-r--r--qt/org.eclipse.cdt.qt.core/src/org/eclipse/cdt/internal/qt/core/ASTUtil.java2
1 files changed, 1 insertions, 1 deletions
diff --git a/qt/org.eclipse.cdt.qt.core/src/org/eclipse/cdt/internal/qt/core/ASTUtil.java b/qt/org.eclipse.cdt.qt.core/src/org/eclipse/cdt/internal/qt/core/ASTUtil.java
index 4deccf48a94..e18152b0b95 100644
--- a/qt/org.eclipse.cdt.qt.core/src/org/eclipse/cdt/internal/qt/core/ASTUtil.java
+++ b/qt/org.eclipse.cdt.qt.core/src/org/eclipse/cdt/internal/qt/core/ASTUtil.java
@@ -130,7 +130,7 @@ public class ASTUtil {
if (node instanceof IASTIdExpression)
return getBaseType((IASTIdExpression) node);
if (node instanceof IASTFunctionCallExpression)
- return getReceiverType((IASTFunctionCallExpression) node);
+ return getBaseType((IASTFunctionCallExpression) node);
if (node instanceof IASTExpression)
return getBaseType(((IASTExpression) node).getExpressionType());

Back to the top