Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEike Stepper2012-07-23 09:36:12 +0000
committerEike Stepper2012-07-23 09:36:12 +0000
commitc77eb6b61ae891fdd974249ccf84aa6c9e3ed7d0 (patch)
tree30cafdb1f161c0a81597b1cfcdd2a946127f336d /plugins
parent91e725972ce9595aaded8ce93d1abfa875d34a1e (diff)
downloadcdo-c77eb6b61ae891fdd974249ccf84aa6c9e3ed7d0.tar.gz
cdo-c77eb6b61ae891fdd974249ccf84aa6c9e3ed7d0.tar.xz
cdo-c77eb6b61ae891fdd974249ccf84aa6c9e3ed7d0.zip
Make addition less magical
Diffstat (limited to 'plugins')
-rw-r--r--plugins/org.eclipse.emf.cdo.releng.version/src/org/eclipse/emf/cdo/releng/version/VersionBuilder.java6
1 files changed, 4 insertions, 2 deletions
diff --git a/plugins/org.eclipse.emf.cdo.releng.version/src/org/eclipse/emf/cdo/releng/version/VersionBuilder.java b/plugins/org.eclipse.emf.cdo.releng.version/src/org/eclipse/emf/cdo/releng/version/VersionBuilder.java
index dd5f224f62..01878b3026 100644
--- a/plugins/org.eclipse.emf.cdo.releng.version/src/org/eclipse/emf/cdo/releng/version/VersionBuilder.java
+++ b/plugins/org.eclipse.emf.cdo.releng.version/src/org/eclipse/emf/cdo/releng/version/VersionBuilder.java
@@ -60,6 +60,8 @@ public class VersionBuilder extends IncrementalProjectBuilder
private static final Path FEATURE_PATH = new Path("feature.xml");
+ private static final Version ADDITION = new Version(Integer.MAX_VALUE, Integer.MAX_VALUE, Integer.MAX_VALUE);
+
private static final Version REMOVAL = new Version(Integer.MAX_VALUE, Integer.MAX_VALUE, Integer.MAX_VALUE);
private static final int NO_CHANGE = 0;
@@ -363,7 +365,7 @@ public class VersionBuilder extends IncrementalProjectBuilder
Element releasedElementsChild = releasedElement.getChild(childElement);
if (releasedElementsChild == null)
{
- addWarning(childElement, null, warnings);
+ addWarning(childElement, ADDITION, warnings);
return MINOR_CHANGE; // ADDITION
}
@@ -650,7 +652,7 @@ public class VersionBuilder extends IncrementalProjectBuilder
String regex = "<" + tag + "\\s+.*?id\\s*=\\s*[\"'](" + name.replace(".", "\\.") + ")";
String msg;
- if (version == null)
+ if (version == ADDITION)
{
msg = type + " reference '" + name + "' has been added with " + releasedElement.getVersion();
}

Back to the top