Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPierre-Charles David2017-08-08 13:07:33 +0000
committerPierre-Charles David2017-08-08 14:57:14 +0000
commitb314dac1423b93fcd7060c64c41e787fda320491 (patch)
tree46b9856713864c83b46c2584d2f659cc17e75cd6
parentcb6ded54ff9ff84e78c2cf9b8119d93d80bf5377 (diff)
downloadorg.eclipse.amalgam-b314dac1423b93fcd7060c64c41e787fda320491.tar.gz
org.eclipse.amalgam-b314dac1423b93fcd7060c64c41e787fda320491.tar.xz
org.eclipse.amalgam-b314dac1423b93fcd7060c64c41e787fda320491.zip
[509735] Encapsulate CommonActivityExplorerPage.pluginId
This was missed in commit a434a1609dc9cba43003d99aac1ab6dbace62759. Bug: 509735 Change-Id: Iffbb26a4f6b523195680856df98e00481da0c6c2 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
-rw-r--r--plugins/org.eclipse.amalgam.explorer.activity.ui/src/org/eclipse/amalgam/explorer/activity/ui/api/configuration/CommonActivityExplorerPageConfiguration.java10
-rw-r--r--plugins/org.eclipse.amalgam.explorer.activity.ui/src/org/eclipse/amalgam/explorer/activity/ui/api/editor/pages/CommonActivityExplorerPage.java4
2 files changed, 11 insertions, 3 deletions
diff --git a/plugins/org.eclipse.amalgam.explorer.activity.ui/src/org/eclipse/amalgam/explorer/activity/ui/api/configuration/CommonActivityExplorerPageConfiguration.java b/plugins/org.eclipse.amalgam.explorer.activity.ui/src/org/eclipse/amalgam/explorer/activity/ui/api/configuration/CommonActivityExplorerPageConfiguration.java
index 4cd022aa..40a41fd5 100644
--- a/plugins/org.eclipse.amalgam.explorer.activity.ui/src/org/eclipse/amalgam/explorer/activity/ui/api/configuration/CommonActivityExplorerPageConfiguration.java
+++ b/plugins/org.eclipse.amalgam.explorer.activity.ui/src/org/eclipse/amalgam/explorer/activity/ui/api/configuration/CommonActivityExplorerPageConfiguration.java
@@ -27,7 +27,7 @@ public class CommonActivityExplorerPageConfiguration {
private String tabName;
- public String pluginId;
+ private String pluginId;
private boolean overview;
@@ -102,6 +102,14 @@ public class CommonActivityExplorerPageConfiguration {
public void setPredicate(IPredicate predicate) {
this.predicate = predicate;
}
+
+ public String getPluginId() {
+ return pluginId;
+ }
+
+ public void setPluginId(String pluginId) {
+ this.pluginId = pluginId;
+ }
} \ No newline at end of file
diff --git a/plugins/org.eclipse.amalgam.explorer.activity.ui/src/org/eclipse/amalgam/explorer/activity/ui/api/editor/pages/CommonActivityExplorerPage.java b/plugins/org.eclipse.amalgam.explorer.activity.ui/src/org/eclipse/amalgam/explorer/activity/ui/api/editor/pages/CommonActivityExplorerPage.java
index f64fffb6..d52c1546 100644
--- a/plugins/org.eclipse.amalgam.explorer.activity.ui/src/org/eclipse/amalgam/explorer/activity/ui/api/editor/pages/CommonActivityExplorerPage.java
+++ b/plugins/org.eclipse.amalgam.explorer.activity.ui/src/org/eclipse/amalgam/explorer/activity/ui/api/editor/pages/CommonActivityExplorerPage.java
@@ -83,7 +83,7 @@ public class CommonActivityExplorerPage extends FormPage implements IExecutableE
parseConfiguration(cfg);
setPartName(config.getTabName());
- String plugin_id = config.pluginId;
+ String plugin_id = config.getPluginId();
if (config.getOverviewImageOffPath().equals(IImageKeys.IMAGE_DEFAULT_OVERVIEW_OFF)) {
plugin_id = ActivityExplorerActivator.ID;
}
@@ -103,7 +103,7 @@ public class CommonActivityExplorerPage extends FormPage implements IExecutableE
config.setTabName(config.getTitle());
}
config.setOverview(ActivityExplorerExtensionManager.getOverviewElement(cfig) != null);
- config.pluginId = ActivityExplorerExtensionManager.getPluginId(cfig);
+ config.setPluginId(ActivityExplorerExtensionManager.getPluginId(cfig));
if (config.isOverview()) {
config.setOverviewImageOffPath(ActivityExplorerExtensionManager.getOverviewImageOff(cfig));
config.setOverviewImageOnPath(ActivityExplorerExtensionManager.getOverviewImageOn(cfig));

Back to the top