Skip to main content
summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSumit Singh2014-05-12 10:29:10 +0000
committerVictor Rubezhny2014-05-21 22:07:16 +0000
commita1550239ad8a2a516acba8dea9743232683b0050 (patch)
treeffdf6fea50cb9ca00a71ae2650667b1d4f007be8
parent5d8923315a3325e58f5128470598c6a24ece1beb (diff)
downloadwebtools.maps-201405221454.tar.gz
webtools.maps-201405221454.tar.xz
webtools.maps-201405221454.zip
Bug 423274 - Debug breakpoints not skip after selecting "Skip allv201405221454
Breakpoints" from breakpoints view after starting debug session. Change-Id: I9c0e68142042bc73955227e94038a397a5b370c5 Signed-off-by: Sumit Singh <sumit.singh@infineon.com>
-rw-r--r--bundles/org.eclipse.wst.jsdt.debug.core/src/org/eclipse/wst/jsdt/debug/internal/core/breakpoints/JavaScriptBreakpoint.java15
1 files changed, 12 insertions, 3 deletions
diff --git a/bundles/org.eclipse.wst.jsdt.debug.core/src/org/eclipse/wst/jsdt/debug/internal/core/breakpoints/JavaScriptBreakpoint.java b/bundles/org.eclipse.wst.jsdt.debug.core/src/org/eclipse/wst/jsdt/debug/internal/core/breakpoints/JavaScriptBreakpoint.java
index 5d9d6a1da..dde86fd86 100644
--- a/bundles/org.eclipse.wst.jsdt.debug.core/src/org/eclipse/wst/jsdt/debug/internal/core/breakpoints/JavaScriptBreakpoint.java
+++ b/bundles/org.eclipse.wst.jsdt.debug.core/src/org/eclipse/wst/jsdt/debug/internal/core/breakpoints/JavaScriptBreakpoint.java
@@ -1,5 +1,5 @@
/*******************************************************************************
- * Copyright (c) 2010, 2012 IBM Corporation and others.
+ * Copyright (c) 2010, 2014 IBM Corporation and others.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0
* which accompanies this distribution, and is available at
@@ -7,6 +7,9 @@
*
* Contributors:
* IBM Corporation - initial API and implementation
+ * Sumit Singh <sumit.singh@infineon.com> - 423274 - Debug breakpoints not
+ * skip after selecting "Skip all Breakpoints" from breakpoints view after
+ * starting debug session.
*******************************************************************************/
package org.eclipse.wst.jsdt.debug.internal.core.breakpoints;
@@ -435,9 +438,15 @@ public abstract class JavaScriptBreakpoint extends Breakpoint implements IJavaSc
// get the thread and suspend it
if (event instanceof BreakpointEvent) {
JavaScriptThread thread = target.findThread(((BreakpointEvent) event).thread());
- if (thread != null) {
- return !thread.suspendForBreakpoint(this, suspendVote);
+ boolean skipBreakpoint = false;
+ try {
+ skipBreakpoint = shouldSkipBreakpoint();
+ } catch (CoreException e) {
+ JavaScriptDebugPlugin.log(e);
}
+ if (thread != null && !skipBreakpoint) {
+ return !thread.suspendForBreakpoint(this, suspendVote);
+ }
}
if (event instanceof ScriptLoadEvent) {
ScriptLoadEvent sevent = (ScriptLoadEvent) event;

Back to the top