tmf.ui: Remove functions from CallStackView when trace is closed.

Bug 531861 - [TMF] Call Stack view leaks function map entries
Function names were cached to display in the tree viewer,
but not removed when traces are deleted.

Change-Id: I5f293ccb8eae5231fad4f6876d5387339e69afe6
Signed-off-by: Loic Prieur-Drevon <loic.prieurdrevon@gmail.com>
Reviewed-on: https://git.eclipse.org/r/118432
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/118811
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

1 files changed, 19 insertions, 0 deletions

diff --git a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/views/callstack/CallStackView.java b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/views/callstack/CallStackView.java
index 4d114f11a0..ddb4ddcbd8 100644
--- a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/views/callstack/CallStackView.java
+++ b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/views/callstack/CallStackView.java
@@ -55,6 +55,7 @@ import org.eclipse.tracecompass.statesystem.core.StateSystemUtils;
 import org.eclipse.tracecompass.tmf.core.dataprovider.DataProviderManager;
 import org.eclipse.tracecompass.tmf.core.signal.TmfSelectionRangeUpdatedSignal;
 import org.eclipse.tracecompass.tmf.core.signal.TmfSignalHandler;
+import org.eclipse.tracecompass.tmf.core.signal.TmfTraceClosedSignal;
 import org.eclipse.tracecompass.tmf.core.signal.TmfTraceSelectedSignal;
 import org.eclipse.tracecompass.tmf.core.signal.TmfWindowRangeUpdatedSignal;
 import org.eclipse.tracecompass.tmf.core.symbols.ISymbolProvider;
@@ -364,6 +365,10 @@ public class CallStackView extends AbstractTimeGraphView {
             @Override
             public void mouseDoubleClick(MouseEvent event) {
                 ITimeGraphEntry selection = getTimeGraphViewer().getSelection();
+                if (!(selection instanceof TimeGraphEntry)) {
+                    // also null checks
+                    return;
+                }
                 ITimeGraphState function = fFunctions.get(((TimeGraphEntry) selection).getModel().getId());
                 if (function != null) {
                     long entryTime = function.getStartTime();
@@ -925,4 +930,18 @@ public class CallStackView extends AbstractTimeGraphView {
         getConfigureSymbolsAction().setEnabled(providerPages.length > 0);
     }
 
+    @TmfSignalHandler
+    @Override
+    public void traceClosed(TmfTraceClosedSignal signal) {
+        List<@NonNull TimeGraphEntry> traceEntries = getEntryList(signal.getTrace());
+        if (traceEntries != null) {
+            /*
+             * remove functions associated to the trace's entries.
+             */
+            Iterable<TimeGraphEntry> all = Iterables.concat(Iterables.transform(traceEntries, Utils::flatten));
+            all.forEach(entry -> fFunctions.remove(entry.getModel().getId()));
+        }
+        super.traceClosed(signal);
+    }
+
 }