diff options
author | Uwe Stieber | 2012-04-25 16:27:35 +0000 |
---|---|---|
committer | Uwe Stieber | 2012-04-25 16:27:35 +0000 |
commit | ac996bb47b63d2bd693fe4199d8b46b0060a24c1 (patch) | |
tree | 09b93525fe879cf47cfc2bcc36a0ad07bd3fac18 /target_explorer/plugins/org.eclipse.tcf.te.tcf.log.core/src/org/eclipse/tcf/te/tcf/log | |
parent | fa064aa92068bda5d57f50ef2ef23cdaf9001f6b (diff) | |
download | org.eclipse.tcf-ac996bb47b63d2bd693fe4199d8b46b0060a24c1.tar.gz org.eclipse.tcf-ac996bb47b63d2bd693fe4199d8b46b0060a24c1.tar.xz org.eclipse.tcf-ac996bb47b63d2bd693fe4199d8b46b0060a24c1.zip |
Target Explorer: Fix findbugs warnings, ignore serialization warnings
Diffstat (limited to 'target_explorer/plugins/org.eclipse.tcf.te.tcf.log.core/src/org/eclipse/tcf/te/tcf/log')
-rw-r--r-- | target_explorer/plugins/org.eclipse.tcf.te.tcf.log.core/src/org/eclipse/tcf/te/tcf/log/core/internal/LogManager.java | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/target_explorer/plugins/org.eclipse.tcf.te.tcf.log.core/src/org/eclipse/tcf/te/tcf/log/core/internal/LogManager.java b/target_explorer/plugins/org.eclipse.tcf.te.tcf.log.core/src/org/eclipse/tcf/te/tcf/log/core/internal/LogManager.java index 645420027..f95aadd83 100644 --- a/target_explorer/plugins/org.eclipse.tcf.te.tcf.log.core/src/org/eclipse/tcf/te/tcf/log/core/internal/LogManager.java +++ b/target_explorer/plugins/org.eclipse.tcf.te.tcf.log.core/src/org/eclipse/tcf/te/tcf/log/core/internal/LogManager.java @@ -302,8 +302,9 @@ public final class LogManager implements IProtocolStateChangeListener { try {
File file = CoreBundleActivator.getDefault().getStateLocation().append(".logs").toFile(); //$NON-NLS-1$
- if (!file.exists()) file.mkdirs();
- if (file.canRead() && file.isDirectory()) {
+ boolean exists = file.exists();
+ if (!exists) exists = file.mkdirs();
+ if (exists && file.canRead() && file.isDirectory()) {
logDir = new Path(file.toString());
}
} catch (IllegalStateException e) {
@@ -313,8 +314,9 @@ public final class LogManager implements IProtocolStateChangeListener { if (logDir == null) {
// First fallback: ${HOME}/.tcf/.logs
File file = new Path(System.getProperty("user.home")).append(".tcf/.logs").toFile(); //$NON-NLS-1$ //$NON-NLS-2$
- if (!file.exists()) file.mkdirs();
- if (file.canRead() && file.isDirectory()) {
+ boolean exists = file.exists();
+ if (!exists) exists = file.mkdirs();
+ if (exists && file.canRead() && file.isDirectory()) {
logDir = new Path(file.toString());
}
}
@@ -322,8 +324,9 @@ public final class LogManager implements IProtocolStateChangeListener { if (logDir == null) {
// Second fallback: ${TEMP}/.tcf/.logs
File file = new Path(System.getProperty("java.io.tmpdir")).append(".tcf/.logs").toFile(); //$NON-NLS-1$ //$NON-NLS-2$
- if (!file.exists()) file.mkdirs();
- if (file.canRead() && file.isDirectory()) {
+ boolean exists = file.exists();
+ if (!exists) exists = file.mkdirs();
+ if (exists && file.canRead() && file.isDirectory()) {
logDir = new Path(file.toString());
}
}
|